From: no-reply@sashiko.virtuozzo.com
To: Konstantin Khorenko <khorenko@virtuozzo.com>,
Pavel Tikhomirov <ptikhomirov@virtuozzo.com>,
Vasileios Almpanis <vasileios.almpanis@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.2 v2 2/3] mm/memcontrol: say where the numa_migrate code comes from
Date: Tue, 17 Nov 2026 16:28:02 +0000 [thread overview]
Message-ID: <010701a1ea563cb1-5931dfbe-5e1a-4642-8b9d-87fa98722e4d-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261117-b4-prep-khorenko-vstor-152197-numa-migrate-cleanup-v2-2-1dce69bd115c@virtuozzo.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] mm: memcg_numa_migrate_new_folio() comment wrongly says gfp
follows alloc_migration_target()
--
commit 2b0b5c5c2e0f48e28f410ad926fddeacad923c4a
Author: Konstantin Khorenko <khorenko@virtuozzo.com>
mm/memcontrol: say where the numa_migrate code comes from
The patch replaces the rebase-history comment in memcg_numa_isolate_pages() with the names of the upstream functions it copies. It also names alloc_migration_target() as the original of the allocator and removes leftover commented-out conditions. No functional change is intended.
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index a82d5e7bc869..4c3c06cfcf9f 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
[ ... ]
> @@ -3473,7 +3473,8 @@ struct memcg_numa_migrate_struct {
>
> /*
> * Used as an argument for migrate_pages(). Allocated pages are spread evenly
> - * among destination nodes.
> + * among destination nodes. The order and gfp choice follow
> + * alloc_migration_target().
> */
> static struct folio *memcg_numa_migrate_new_folio(struct folio *old_folio,
> unsigned long private)
[Severity: Low]
Is the claim that the gfp choice follows alloc_migration_target() accurate?
Only the order matches. alloc_migration_target() clears __GFP_RECLAIM and ORs in GFP_TRANSHUGE for large folios. It also adds __GFP_HIGHMEM based on the source zone. memcg_numa_migrate_new_folio() hardcodes GFP_HIGHUSER_MOVABLE | __GFP_NORETRY | __GFP_NOWARN. For large folios it uses GFP_TRANSHUGE_LIGHT | __GFP_THISNODE, and it has no hugetlb or zone-based highmem handling.
The commit message says the point is to give a rebase the functions to compare against, so a comment claiming gfp parity could mislead that rebase. Could the comment be limited to the large-folio order and the __folio_alloc() usage, and say that the gfp mask is deliberately different? The series tip (f81bad5580ae) still carries this comment text, so a later patch does not correct it.
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261117-b4-prep-khorenko-vstor-152197-numa-migrate-cleanup-v2-0-1dce69bd115c@virtuozzo.com?part=2
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-17 16:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 16:24 [Devel] [PATCH hci-8.2 v2 0/3] mm/memcontrol: tidy up the memory.numa_migrate code Konstantin Khorenko
2026-11-17 16:24 ` [Devel] [PATCH hci-8.2 v2 1/3] mm/memcontrol: drop the unused update_lru_sizes() Konstantin Khorenko
2026-11-17 16:27 ` no-reply
2026-11-17 16:24 ` [Devel] [PATCH hci-8.2 v2 2/3] mm/memcontrol: say where the numa_migrate code comes from Konstantin Khorenko
2026-11-17 16:28 ` no-reply [this message]
2026-11-17 16:24 ` [Devel] [PATCH hci-8.2 v2 3/3] mm/memcontrol: say what memcg_numa_isolate_pages() limits Konstantin Khorenko
2026-11-17 16:27 ` no-reply
2026-11-17 16:27 ` [Devel] [PATCH hci-8.2 v2 0/3] mm/memcontrol: tidy up the memory.numa_migrate code Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a1ea563cb1-5931dfbe-5e1a-4642-8b9d-87fa98722e4d-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=devel@openvz.org \
--cc=khorenko@virtuozzo.com \
--cc=ptikhomirov@virtuozzo.com \
--cc=vasileios.almpanis@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox