From: no-reply@sashiko.virtuozzo.com
To: Alexander Ivanov <alexander.ivanov@virtuozzo.com>,
andrey.zhadchenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v7 10/10] dm-ploop: truncate unused tail of top delta on suspend
Date: Tue, 17 Nov 2026 17:40:51 +0000 [thread overview]
Message-ID: <010701a1ea98e76a-d16bf8a4-5bd9-4f3d-8f89-a03b0e75d0ad-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261117171743.3216794-11-alexander.ivanov@virtuozzo.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] dm-ploop: ploop_calc_used_end() reads the whole BAT on every
suspend
- [Low] dm-ploop: ploop_postsuspend() holds ctl_rwsem across unbounded
waits
--
commit 1bc9305c23ed033ac0c00538c0091d4e15947faa
Author: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
dm-ploop: truncate unused tail of top delta on suspend
This commit adds ploop_calc_used_end(), which computes the used end of the top delta from the on-disk BAT and format extension header. ploop_postsuspend() now uses it to truncate the unused tail of the top delta under ctl_rwsem.
> diff --git a/drivers/md/dm-ploop-bat.c b/drivers/md/dm-ploop-bat.c
> --- a/drivers/md/dm-ploop-bat.c
> +++ b/drivers/md/dm-ploop-bat.c
[ ... ]
> + ret = ploop_read_delta_metadata(ploop, file, &md_root, &nr_be);
> + if (ret)
> + return ret;
[Severity: Low]
Does this read the whole on-disk BAT on every suspend of a writable, non-raw device? ploop_read_delta_metadata() allocates md pages for the entire BAT, reads and converts it, and frees it again. This happens even when there is no unused tail, because the early checks in ploop_truncate_unused_tail() cannot detect that case. Suspend latency therefore grows with BAT size, and resume then reloads the metadata a second time. Could a cheap pre-check skip the read when nothing can be reclaimed? For example, compare top->file_size with the used end computed from the in-memory state.
> diff --git a/drivers/md/dm-ploop-target.c b/drivers/md/dm-ploop-target.c
> --- a/drivers/md/dm-ploop-target.c
> +++ b/drivers/md/dm-ploop-target.c
[ ... ]
> static void ploop_postsuspend(struct dm_target *ti)
> {
> struct ploop *ploop = ti->private;
> + unsigned int noio_flags;
>
> + down_write(&ploop->ctl_rwsem);
> /*
> * Let the next resumed ploop (maybe of reloaded table)
> * see final size of the top delta. Don't wait in standby
[Severity: Low]
As reported by no-reply@sashiko.virtuozzo.com on v4 [1], is it necessary to take ctl_rwsem for write before the waits in ploop_postsuspend()? The write lock is now held across ploop_wait_prealloc(), the uninterruptible wait_event() on inflight_md_wq, and the fsync and truncate I/O.
If any of these stalls, for example a stuck backing file with unfinished BAT writeback, ploop_status() and every ploop_message() handler except get_event sleep in down_read() or down_write() on ctl_rwsem. Messages such as set_noresume then cannot run during the stall. Before the patch, ctl_rwsem was taken only briefly in ploop_set_suspended(), after both waits.
The truncate path already re-checks ploop_no_pending_prealloc() and the i_size equality. A message slipping in between the waits and the lock would at worst make the truncation skip. Would taking ctl_rwsem after the waits avoid the extra blocking?
[1] https://lore.kernel.org/r/010701a1305e757d-fdba1b14-3cb2-40e0-98a8-66720e942d61-000000@eu-central-1.amazonses.com
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261117171743.3216794-1-alexander.ivanov@virtuozzo.com?part=10
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-17 17:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 17:17 [Devel] [PATCH hci-8.1 v7 00/10] dm-ploop: give back " Alexander Ivanov
2026-11-17 17:17 ` [Devel] [PATCH hci-8.1 v7 01/10] dm-ploop: reject a delta header whose BAT does not cover the target Alexander Ivanov
2026-11-17 17:22 ` no-reply
2026-11-17 17:17 ` [Devel] [PATCH hci-8.1 v7 02/10] dm-ploop: reject empty deltas Alexander Ivanov
2026-11-17 17:22 ` no-reply
2026-11-17 17:17 ` [Devel] [PATCH hci-8.1 v7 03/10] dm-ploop: set delta is_raw before applying its mappings Alexander Ivanov
2026-11-17 17:25 ` no-reply
2026-11-17 18:23 ` Konstantin Khorenko
2026-11-17 17:17 ` [Devel] [PATCH hci-8.1 v7 04/10] dm-ploop: factor out ploop_read_delta() from ploop_add_delta() Alexander Ivanov
2026-11-17 17:24 ` no-reply
2026-11-17 17:17 ` [Devel] [PATCH hci-8.1 v7 05/10] dm-ploop: take bat_lock around md page lookup in ploop_llseek_hole() Alexander Ivanov
2026-11-17 17:27 ` no-reply
2026-11-17 17:17 ` [Devel] [PATCH hci-8.1 v7 06/10] dm-ploop: use wake_up() for inflight_md_wq Alexander Ivanov
2026-11-17 17:26 ` no-reply
2026-11-17 18:23 ` Konstantin Khorenko
2026-11-17 17:17 ` [Devel] [PATCH hci-8.1 v7 07/10] dm-ploop: fix use-after-free on the last inflight_md decrement Alexander Ivanov
2026-11-17 17:32 ` no-reply
2026-11-17 18:23 ` Konstantin Khorenko
2026-11-17 17:17 ` [Devel] [PATCH hci-8.1 v7 08/10] dm-ploop: fix flip_upper_deltas racing with resume Alexander Ivanov
2026-11-17 17:28 ` no-reply
2026-11-17 17:17 ` [Devel] [PATCH hci-8.1 v7 09/10] dm-ploop: reload metadata on resume Alexander Ivanov
2026-11-17 17:36 ` no-reply
2026-11-17 18:23 ` Konstantin Khorenko
2026-11-17 17:17 ` [Devel] [PATCH hci-8.1 v7 10/10] dm-ploop: truncate unused tail of top delta on suspend Alexander Ivanov
2026-11-17 17:40 ` no-reply [this message]
2026-11-17 18:23 ` Konstantin Khorenko
2026-11-17 18:23 ` [Devel] [PATCH hci-8.1 v7 00/10] dm-ploop: give back " Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a1ea98e76a-d16bf8a4-5bd9-4f3d-8f89-a03b0e75d0ad-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=alexander.ivanov@virtuozzo.com \
--cc=andrey.zhadchenko@virtuozzo.com \
--cc=devel@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox