From: "Denis V. Lunev" <den@virtuozzo.com>
To: Konstantin Khorenko <khorenko@virtuozzo.com>,
Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v5 3/3] dm-qcow2: truncate unused tail of image on suspend
Date: Wed, 21 Oct 2026 19:53:31 +0200 [thread overview]
Message-ID: <0b8a5c9b-99e8-43fa-88ef-7df4236c0903@virtuozzo.com> (raw)
In-Reply-To: <179259732233.3864599.9993825844420241421.b4-review@b4>
On 10/21/26 18:42, Konstantin Khorenko wrote:
> I'd rather not truncate the image in the kernel at all. My comments
> below are for the case we keep it.
>
> The scan trusts the refcounts and never checks them against L1/L2. A
> wrong refcount or a wrong scan start then costs data on the first
> suspend: stop, snapshot or compact.
Wrong refcount already means data loss during ordinary cluster
allocation.
Den
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-10-21 17:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 12:46 [Devel] [PATCH hci-8.1 v5 0/3] " Alexander Ivanov
2026-10-10 12:46 ` [Devel] [PATCH hci-8.1 v5 1/3] dm-qcow2: add qcow2_md_page_read_sync() helper Alexander Ivanov
2026-10-10 12:51 ` no-reply
2026-10-21 15:42 ` Konstantin Khorenko
2026-10-10 12:46 ` [Devel] [PATCH hci-8.1 v5 2/3] dm-qcow2: drop duplicate prefix from QC_ERR/QC_INFO messages Alexander Ivanov
2026-10-10 12:50 ` no-reply
2026-10-21 15:42 ` Konstantin Khorenko
2026-10-10 12:46 ` [Devel] [PATCH hci-8.1 v5 3/3] dm-qcow2: truncate unused tail of image on suspend Alexander Ivanov
2026-10-10 12:53 ` no-reply
2026-10-12 9:35 ` Andrey Zhadchenko
2026-10-21 15:42 ` Konstantin Khorenko
2026-10-21 17:53 ` Denis V. Lunev [this message]
2026-10-22 8:35 ` Alexander Ivanov
2026-10-12 9:59 ` [Devel] [PATCH hci-8.1 v5 0/3] " Andrey Zhadchenko
2026-10-21 15:42 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b8a5c9b-99e8-43fa-88ef-7df4236c0903@virtuozzo.com \
--to=den@virtuozzo.com \
--cc=alexander.ivanov@virtuozzo.com \
--cc=devel@openvz.org \
--cc=khorenko@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox