From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasileios Almpanis Date: Mon, 24 Aug 2026 07:54:58 +0000 Subject: Re: [Devel] [PATCH vz10] selftests: livepatch: do not require a kernel build tree to run In-Reply-To: <20260821150254.791935-1-eva.kurchatova@virtuozzo.com> References: <20260821150254.791935-1-eva.kurchatova@virtuozzo.com> Message-ID: <178755809816.184044.17563652020953853473.b4-review@b4> List-Id: On Fri, 21 Aug 2026 18:02:51 +0300, Eva Kurchatova wrote: > setup_config() calls has_kdir(), which skips every livepatch test when > /lib/modules/$(uname -r)/build is missing. The tests do not compile > anything though, they insmod the pre-built modules from test_modules/, > so the check tests a proxy rather than the thing it cares about. > > That proxy holds only for a source tree or a machine with kernel-devel > installed. A packaged testsuite ships the modules pre-built and runs on > machines with no kernel build tree at all, and there every single test > reports "ok ... # SKIP". A harness that looks for "not ok" then reports > the suite as passed, so the whole suite silently tests nothing. > > [...] Reviewed-by: Vasileios Almpanis -- Vasileios Almpanis