From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 328DC8013F for ; Wed, 2 Sep 2026 13:47:47 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 682DkQFF024031; Wed, 2 Sep 2026 16:46:27 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 682DkQFF024031 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="Wu1bzhPL" Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 682DkOB6024027 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 2 Sep 2026 16:46:25 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 682DkOB6024027 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-c11f2b9f62fso74860266b.2 for ; Wed, 02 Sep 2026 06:46:24 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBxGpj0uMPQ2S+shk5gTT8Iy0T3skNUREttZQs3AnQvll423Hu24lVVrIVLhHjKihVShXjEIpQ==@openvz.org X-Gm-Message-State: AFuF++lMpwWqJa5nK0im8Rq3AdYAPT9tEr93ONe1XpZmTQc3ClSAEC71 kEqBEWE9udELLoVCNznUfO5kFi23EKy4wHu4rEMrzf/dtkA1Nrqov2e9lYHSTiKKG29lwN2sRgs mZbKfPuLlnNLFamuy1SN4sg2sC3+yxBS91EPtU8FNF0/PkOU8KyrB3Q== X-Gm-Gg: AYBFou2RGt9bAdlUsuyqsekMWMafuQdRQF/0SoeYZ5fwbsg7APJcJKWFCjZ0xyrKYyf 3WB2fvVRuvqQHWGGp5jHzcwTCATjMz15P8bWei3uE2shVGYfXYXJlCDAmokAyA+940tdU4bUDqQ siB/kNS15zNXP+XBDVTEDA/6OJjk6+j3VvD3wh2BTNNTSAkkCa2Eu7RPSmBDXAn4g9k5nb/UWJ9 hsoRXX2s+66ckAziRD+JC4Bq0CQ9hMinKw60ZIC+3NPlTnvascD8RUwk8DGiWZ4DgnqeCpZHr6E 96/S5O+A3BztcmQEh5YcP5RIpiUUSfvjIRDaOnH2jPWx8aGhbcJR5pCsHSOdRfA0HccVjnpfqUM yZHUv691n5uezYWar X-Received: by 2002:a17:906:4fd5:b0:c21:9cf4:e1b0 with SMTP id a640c23a62f3a-c25d520b2e8mr301334266b.3.1788356783965; Wed, 02 Sep 2026 06:46:23 -0700 (PDT) X-Received: by 2002:a17:906:4fd5:b0:c21:9cf4:e1b0 with SMTP id a640c23a62f3a-c25d520b2e8mr301320566b.3.1788356783238; Wed, 02 Sep 2026 06:46:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1788356783; cv=none; d=google.com; s=arc-20260327; b=p7MXvdbc+N494W1kBaQj0Ya2xo1+gqmPz2UMDeJ8ZGo1teGhVjFVV7P0G/akwJNVm2 m+5rrsdnhsIvX0A8eMnXpoQxtHUdBLQzoACHxJvpEhWERmNifhl/zFWz7F6zqDMFYGpc b8v1GH/XqOjAip9TZEJUObNiMHVTmhFL+y6+funPzhGd4XVMBHdkuB0JkWHVA3t7TLTQ 8MDTlXcZnx+Vl7tUT4/61NzGs/3LTYw3KDlTI8UAVQsDMLHn3ECG30nWGWF0VLvxwERg WE0QC8ImkQtnJshaPjNShG0pyNgkkHAg2O2oZlRS5gA52pViTM2goIM9Ki2JTvWJldMD tCJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=8rXDs4k9RYSgoWoPiH0/cplKeWlviH/uE1uCc1JLQK0=; fh=CTF2GHyV+XdzB5TROrdG4fdLri6JSHNOBC+LNuNq5bA=; b=KIx4FkOQnhINuMyHOWLOth6yAKbOHVZXGaqcrGny7I6tpwhWJa9xqZN9BHx0WFGr1Y AGZWF/Vif0kxkcLco1DJdtr1KmiZ5N21rJ3FnK/x93baIdwk+LCkOXfDqj/d26dvq+UT zrqW/kUkoeFHx/sXloJEBSR0MlOZGDf4IBl47qU1UY2fY3TP/IueZjuGYle+v98KlJMr cWQUphO0UxNJEoBzU+bLgVwlSQP9F8FArh9S5BWOFhWOpKWGj3OUXePjT/dMnf5uu1cK OnPuEURWb9oHr38pjznwdM8PxvaGsG/TYWbDjpj81N2prwpeByqACG5O2wZvtPPMKp2o +kpw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=Wu1bzhPL; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-4844951bb31si5576759f8f.482.2026.09.02.06.46.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 06:46:23 -0700 (PDT) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=Wu1bzhPL; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=8rXDs4k9RYSgoWoPiH0/cplKeWlviH/uE1uCc1JLQK0=; b=Wu1bzhPL9XvA ncIBY1fCyxy1IkFdQ505LMJa7pP7/VIgIq2IZcYeKo+vPhepnh3ZFSBrQ5p18eYoCVsHAqiREs6EN xDLJ9oC/zBMaYLwahUAILpLjJ+uik/v9nwB20YwtdCv969i1n9+eT6VNOHYe7iAUVTVLkucx6tLU7 ah5yQLLv194+6hTXVkhTIWbsnmfmmFgoPRAri7kfitlr23R4K1P1VcDt5Jn/qiOTTW21scBGz1kCi mnbG2Gly7knSEH+QbCVJs9JKt7f4yL5wMxHSnc2KLFBs54igteJAXBNAI4ATVsmNd9QwD1PAnDgKj Zc0U28A2Ry8BL6vtuaOpxg==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1x1lFp-001w3N-1l; Wed, 02 Sep 2026 15:46:22 +0200 MIME-Version: 1.0 From: Konstantin Khorenko To: Eva Kurchatova In-Reply-To: <20260901004003.1654339-1-eva.kurchatova@virtuozzo.com> References: <20260901004003.1654339-1-eva.kurchatova@virtuozzo.com> Date: Wed, 02 Sep 2026 15:46:19 +0200 Message-Id: <178835677986.1218357.13737236208498757758.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1968; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=M3JEGWSlDHPcP5DuRUkTrU7r66GavJILZTw7s+CxdAo=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBqmCiusKAagV4jcshBfKMrcG/S/iRw6eQ9jEVe2 8LyE5HflzyJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCapgorgAKCRBRlgpH+WFc KotkEACK+tiANIjM4GAu43o3/CepOpRudNvGGyl2/1W0wGeeniNV+aTTmZkP0oOQ7HxEez7GgPh tW1uliCEqfrjzpFxYq1UJO7qmTHKfgLNno73NkMtO/qYo8n4zUUKP+AhR9kNmDJTPIXdQShDBwL gobizBdWY4FmgX0t4SUb62hpgppzcjDJTNbH97zTLtlidiOqnCCkhZqm+eeq/g9o6cFzSrDXoBA J3hnhU/smZXI6N43hIN89Ae56efUbmeFPwqEipYNEstaNR3rzC1C35VtBJUoYLOhbSy+uSqKNnO Qp761vmCUAPCfqhEcrGWuhLM70N/Wzpdp8IwDxvTzFzlffW+CpntJwcenJzmLjyHbmwSOmXKBl3 blP2MQ5hrE99ygSoA51V4t+I8FtClSzHwr5YlyzbbB+VY35Fn6f9rJnXRriQYR1QTwPdZZi2Twr JNS7ZvyFRmXyjHV3Evh3FkHdfMP3eITDn/GaOZU6UF2Yxmdm6u1lcYwtj0FWdNRex7cB04BY1Sp 53zQ5Rt73AYKBnUqt4gTuIIpUz1KsPoZCcHlm/CVFbzm4zGeBPtj0CB9Ryiqws+idYTNyfZJzvR 8r8/Ip8tyAN4mQpkT2YTpoCmncalA9A6lhIQVUn824oSBQ9cIlCJJp0U55PjXuaDfJnYjfSIp0v Zg289lPk5DXfQjA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH vz10] selftests: connector: make proc_filter terminate on its own X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org > proc_filter listens for process events until a signal interrupts it, > so a caller that waits for it to finish waits forever. Generate one > event, stop after five seconds, and fail if nothing was received. > > https://virtuozzo.atlassian.net/browse/VSTOR-142450 > Feature: fix selftests > Signed-off-by: Eva Kurchatova > > diff --git a/tools/testing/selftests/connector/proc_filter.c b/tools/testing/selftests/connector/proc_filter.c > index 4a825b997666e..f269b0b67db6c 100644 > --- a/tools/testing/selftests/connector/proc_filter.c > +++ b/tools/testing/selftests/connector/proc_filter.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include > > #include "../kselftest.h" > @@ -279,6 +280,16 @@ int main(int argc, char *argv[]) > exit(1); > } > > + /* > + * Generate one event to observe and stop listening shortly after, > + * so that the test terminates on its own. > + */ > + signal(SIGALRM, sigint); > + alarm(5); > + if (fork() == 0) > + _exit(0); > + wait(NULL); > + > while (!interrupted) { > err = handle_events(epoll_fd, &proc_ev); > if (err < 0) { > @@ -306,5 +317,5 @@ int main(int argc, char *argv[]) > close(nl_sock); > > printf("Done total count: %d\n", tcount); > - exit(0); > + exit(tcount > 0 ? KSFT_PASS : KSFT_FAIL); > } AFAIS this is not a test at all, but a monitor developed to grab and show the events from kernel. A manual monitor which is never run as a real kselftest. If we would like to write a proper test on this, we need to generate all the types of events and check that expected events are received - nothing of that done here. And adding 1 simple event to make the test pass - i do not think we need such a test at all. => let's disable this test at all and not patch it. -- Konstantin Khorenko _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel