From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 1124280275 for ; Fri, 4 Sep 2026 11:24:49 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 684BNRJf031372; Fri, 4 Sep 2026 14:23:28 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 684BNRJf031372 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="HlmWtXKf" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 684BNQ5B031368 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Fri, 4 Sep 2026 14:23:26 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 684BNQ5B031368 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-482a5e9400eso987633f8f.2 for ; Fri, 04 Sep 2026 04:23:26 -0700 (PDT) X-Gm-Message-State: AFuF++myxVkJIYg9SU/XlG3mUn33bHMLZqXn62pm6U8WCf/1c7kHUWuS BZmN+yaz5ocjoDDFx3dp2WJSkkwF9UGjSUr/gVCRXTLitDaEwgGEVf5j44oNIwTdfbcPGaFvHdm fu7daGJjltIe5wPTYaFu3m4XjsC3awVjkf2s9hPDzc2M9lDIdNZOqJw== X-Gm-Gg: AYBFou09cnEz2BtSP63eOW7MPPFd/YDFLgW67MqHczT7fjrDYbz/c2TErGGRl03ut/Y m7aq3trgyV/zU0aI+gYdqEam631s2hMscY/QZMwIRKCsPsJgaUx2SszV4MUL/udZJGsLr9UV/TO bQNmQs4U8VhiZL+d3MJs3OogSCWh6a55W2fRSGb4euRvdoS7SxGfxXqCjpYRoTragZBF7ud0ieA u8/OnpnLz423/sKWR4mIRMnYJl6+EV0rYD26lhAmm8hdXzK4ImBK6WAXZXXHitHBDfkgjPkteeb 2/HSz0pmCgoxZjh0OZifhirpB8D0ya9cASmkk3XjZltCrop3DsO7ZFv74DmClrF3cD+ddytRF9i 0C7cYUTpCfalzwfOr X-Received: by 2002:a05:6000:4696:b0:47f:7129:6e2d with SMTP id ffacd0b85a97d-48587085e0bmr6749343f8f.17.1788521005851; Fri, 04 Sep 2026 04:23:25 -0700 (PDT) X-Received: by 2002:a05:6000:4696:b0:47f:7129:6e2d with SMTP id ffacd0b85a97d-48587085e0bmr6749244f8f.17.1788521005300; Fri, 04 Sep 2026 04:23:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1788521005; cv=none; d=google.com; s=arc-20260327; b=g89/89UnHBVW/SZPZAQ9uQCmWaORnK9JdEziga4lMSO0dCQpsbBn51O95EW2gRdQBM 9xyHnlyh3GnvEnY6w5i27I8kR848e1lQ+3bag8iKPYF+HMg1MINe1RP8Iy9GVItSfqdY qjWXRcfgQxS0nIonYJXGrgNBiOyU+P/s5BIIdKFUJMW4+oLjwf09OKuNz7CAeMfreIHa z4eeBo/Onootpo4+CFTU5997kuUsf4WnQxU5kbWg+e4xQfu3n2LguI2rwiQyEQWcp4Ei CNV3Xd/jr/o04M1q0W4RCYjVbBgfdUMlCXfh9zVrn9Z9ccPOqZGzIxkL8gXEvzvFcbHc 3cgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=1CNSPQpAiI7zj5093OHRYqTlab5WnukK89rGsB7KUFM=; fh=IbaWj82zqOZm03F/eoPTlWBn4zwBRsoZlMDBqCRFIUM=; b=ngNjFlDAeE8pLu6UK23imz+d3PquzLQl0yt/MqycCRwFtY5G1qDi3zzk107Ze3XQdI UyoPZETjfKN4zQ9R5QIEGP1oKcNJJFZu/WjeOZLSY5zNVYq7ic+jQvsl6diqWlIWX949 jOJ6stld70F/DB0tdNNxWsbi0zjbHD4wL7PH0bPRQCGVGl62om5wlElY89nErBpyFPGm BNOV7Fj35QcZyQN33gpgSnKNh14WuDwyAjeo9h6BO2oYHbzU2rb22rMu5GqVB41ZB4p0 2qFPWlk9aXKsXqJYoO+P8Syo+SpV47vEYKSgiwzphmxTvY+bf9AiSMw+bfQ0FbIGpNbS 9bPA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=HlmWtXKf; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-485883b5fc7si4923432f8f.139.2026.09.04.04.23.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2026 04:23:25 -0700 (PDT) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=HlmWtXKf; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=1CNSPQpAiI7zj5093OHRYqTlab5WnukK89rGsB7KUFM=; b=HlmWtXKfu4Ur oBaSKPAndR8gr4pLm/qLUBajKLmUKhjMt7hemdncsK5VtdlHBkagW+cENRUy+h34q87N2wtzL6BZJ tdm0Tk0nYh92NUAnri+OEP1YBdKYqG+gRT+nSj35iZHZV6JItEDxQ6czifUpajm6oNY48ZX5Adkcu C+bQc1PQ2Xu3HYkMSv3M+euVGwlUaV/oeI8nkRdbUpNaF/NYjTZ6PawMjV4Ln8enAL68NIzj499/z xwgQyBnwy4eL0OxtZu3jfg0Q/MmeGiJnZ0uQ8rRKvmzufPa9JlTNOA4sTNRFC58cBxqxKUmkjPaHE tfFaPD0wy9xGpszeYAIlsA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1x2RyW-002R9I-2M; Fri, 04 Sep 2026 13:23:21 +0200 MIME-Version: 1.0 From: Konstantin Khorenko To: Liu Kui In-Reply-To: <20260904015733.23940-1-kui.liu@virtuozzo.com> References: <20260904015733.23940-1-kui.liu@virtuozzo.com> Date: Fri, 04 Sep 2026 13:23:21 +0200 Message-Id: <178852100198.1383001.16567754034300661326.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=808; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=hyuotZq45RFJ+tJFGxFpJRdLbq/qzTHraLF6/FwXBts=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBqmqosb0Ls+bWMmoop/exgiBjTNUDCXX9/ipbsq ILaZ3fMfyWJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCapqqLAAKCRBRlgpH+WFc KvhcEADFdPmFa0DH91g6n7nSnkdVugbY/4JE6ZWPUAxhWb5f3Pz41hxdT1xBYIKj3HlGx2TNIwz ovgVAYNhB1AlYOiDkXUwwuKvZM684ytrvbwPq2dL+0SHoIEAkMlK5ZAJ6IImJ4D98DKZkUCaBby ZKkVhCqd0QXhJYRraEGN+LU8m5cvB/rcJSoDyTa0gGxnDmp5J66p56PzS1OfKZ6L8BFsSfMz8QJ F8R7G4lKn3ZOQKnluO+2mlN2Y7dN+AwoMzYQBkCFLVuaoC35wtar+ZzIYUgwZiEex59Vv7MrR1k oWHSca0StFiCTVlmDuio4I+VRPqZEC4kLMsnjeSYXBVwa1GLdLwFYW2KcjTusiZyJSnK+Px94lR 0KmfKmXGyY1QfcD1tgT/9077Pw+KcgKESC2lYVYZwi+QxxvJ60agPRi3gViHWkA9xkowFmAQkSd 7PUcJQlH2frLyOHr5xsQwlDy1IZ7rZbFCT4zjokdKuPX+YXTHv0A92uaIAgeDU3zYuopCx6YNVb 1De/0/sSiE4HSz5h5WefNC+c9LljfQ73WBs+NaA84pC+D81cA+xFg8EpyRlnh8lQKGLNukdhSkl ET778yeuXMzYz9hR94jUueJYeRlAyCX+7WE66Ss8qrlF91A/MZs8dFKC7GKxB+P9+tCvCjvvAoB jJcbt85o8Ayvwnw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: azaitsev@virtuozzo.com, devel@openvz.org Subject: Re: [Devel] [PATCH VZ10] fs/fuse kio: fix use of uninitialized data chunk counter on error path X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org > In kreq_make_sendmsg(), the data chunk counter nr_data_chunks is reset > only after the header chunk has been set up. If mapping the header chunk > fails, the error path calls kreq_release_data_chunks() with an uninitialized > counter value, so it walks garbage chunk entries, triggering the "Invalid > chunk type" warning and potentially freeing the wrong memory . > > Fix this by resetting the counter before the first error exit. Fixes: f9150edc32b7 ("fs/fuse kio: convert BUG_ON check to error handling") Feature: fuse: kRPC - single RPC for kernel and userspace > https://virtuozzo.atlassian.net/browse/VSTOR-143521 > > Signed-off-by: Liu Kui Reviewed-by: Konstantin Khorenko -- Konstantin Khorenko _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel