From: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
To: Konstantin Khorenko <khorenko@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH VZ10 3/3] ve_namespace: Allow entering non-running VE namespace
Date: Tue, 08 Sep 2026 11:12:05 +0200 [thread overview]
Message-ID: <178885872527.466559.1346408867911171652.b4-review@b4> (raw)
In-Reply-To: <20260907-ve-selftest-improv-v1-3-a17847abbd48@virtuozzo.com>
> This doesn't bring a lot of value and makes tests more complex.
> To enter VE namespace we need to actually start VE.
>
> In vzctl we have locking to prevent parallel creations.
> If someone decides to skip locks and start one CT
> in parallel - big mistake, but not ours.
>
> https://virtuozzo.atlassian.net/browse/VSTOR-144504
>
> Feature: ve selftests
> Signed-off-by: Vladimir Riabchun <vladimir.riabchun@virtuozzo.com>
>
> diff --git a/kernel/ve/ve_namespace.c b/kernel/ve/ve_namespace.c
> index 3dbe0dde2645d..2ddec9ef312f9 100644
> --- a/kernel/ve/ve_namespace.c
> +++ b/kernel/ve/ve_namespace.c
> @@ -227,7 +227,9 @@ static int ve_ns_install(struct nsset *nsset, struct ns_common *new)
> return -EPERM;
>
> if (!VE_IS_RUNNING(ve_ns->ve))
> - return -EINVAL;
> + pr_warn_once("Switching to a non-running ve %s.\n"
> + "This should happen in kselftests only.\n",
nit: I would rather avoid mentioning kselftests in a general warning the
customers might see.
--
Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-09-08 9:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 19:14 [Devel] [PATCH VZ10 0/3] Improvements for ve selftests Vladimir Riabchun
2026-09-07 19:14 ` [Devel] [PATCH VZ10 1/3] selftests/ve: Add namespace management helpers Vladimir Riabchun
2026-09-09 10:39 ` Vladimir Riabchun
2026-09-07 19:14 ` [Devel] [PATCH VZ10 2/3] selftests/ve: Add more helpers Vladimir Riabchun
2026-09-09 11:03 ` Vladimir Riabchun
2026-09-07 19:14 ` [Devel] [PATCH VZ10 3/3] ve_namespace: Allow entering non-running VE namespace Vladimir Riabchun
2026-09-08 9:12 ` Pavel Tikhomirov [this message]
2026-09-08 9:12 ` [Devel] [PATCH VZ10 0/3] Improvements for ve selftests Pavel Tikhomirov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178885872527.466559.1346408867911171652.b4-review@b4 \
--to=ptikhomirov@virtuozzo.com \
--cc=devel@openvz.org \
--cc=khorenko@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox