From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 359BC8015B for ; Wed, 16 Sep 2026 12:31:42 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68GCUP2W014971; Wed, 16 Sep 2026 15:30:26 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68GCUP2W014971 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="CpsfIRbJ" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68GCUM8A014967 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 16 Sep 2026 15:30:23 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68GCUM8A014967 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-4870a0fe60fso795835f8f.2 for ; Wed, 16 Sep 2026 05:30:23 -0700 (PDT) X-Gm-Message-State: AFuF++lUhPfptqXXv3dbya+B0/bvP+916DZaVXAAVm7btAhH9hr3hc6B dPtqVhBOlTXYhIyfk5dl3iyhGuJSBZQCAPAEbC2vVC7x9B394jeMivAulbFvBmcf7uL/IfNpv01 IGMY1Z90/mfVI+6YANJhNTRyY7ETElOdbbMW2IyiPidEkrZutxTvx+A== X-Gm-Gg: AYBFou0JTwspvfDxvwia95F6qypFOH5XkWzUnWx7z/RpJI4Z9BtEpFi9W0kHp4lB9bs KQRMfaBdzqcktJXIBQ5m0/YkcgalG/YeNVSAYVL/Zb1kyasWCsN7uJwVxIeLj+mfwHgcVpgmQoB dzSvb+N6+J9IWdvQtkFRMehSftnFSPxdsNKj3cCX5D/xjZ2IqKUgdr3sti0YnKR8oYuAnnnsCFz tj0fSVKgGPvp9kSugcER9SXrUgPx3rz/iY6brLkUjYpNbAjRcvIjFjh0p0etmC/3Jq0a3PT+hUg XPVSBMMuVsw2Xuf372gdMjFnzIAr6pjN8lln2zngeCH60hQquQXhc/XSNPWPHZocEW47hml2mSm z8hSfjN4mRJa8mi8ZKz0wtNseziuJ0Q== X-Received: by 2002:adf:edc9:0:b0:487:936:7ce0 with SMTP id ffacd0b85a97d-4870d26afb3mr2381798f8f.28.1789561822625; Wed, 16 Sep 2026 05:30:22 -0700 (PDT) X-Received: by 2002:adf:edc9:0:b0:487:936:7ce0 with SMTP id ffacd0b85a97d-4870d26afb3mr2381752f8f.28.1789561821905; Wed, 16 Sep 2026 05:30:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1789561821; cv=none; d=google.com; s=arc-20260327; b=L7pIS+PWNmfWZCkzobpUmVSzLZSZUnoucNVbTjGSHkxwG0zzLgqv0K2H99OxVUWRao n5go2K0UJmpiULsSZFLrwqej8gKYcVX3aOIjxoiQvNTaR/9LuddJKRYEbgi3SENitWhn qENqNYa2f8gA5JzM5oPu5O13CohWR3VafTA3UK80WU+ZHuSgwlLXrmLRsXjxh1PGl4RZ 9KNfFbDPYrRqjeiX30dVc65GOsMKLkiWKTG/+HshLH5rR1faplWYKikd8ZIITTJYJAFF TkwirkjcgtLwozfPQIk8s9gOONn9jHcKebUqPuLgRr9ISKUqr8UPHg/F73yF64OXhyVq uKaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=rGWIjNrhAFHCZSRI45SebklpbbS1riUIv5xG9LXnKec=; fh=skezItRrPUmDWFjzm5RAGnCYsXdZjhBsZcOEYn6bEzI=; b=HpBEfPJm5NtE3eF4FPSniHQ/Gjg0EUdDnGU63U00YqPuwefe9vjTdEMXgByyHnVUXw jXuxPcCvzfX4wSUHsctZB0NkuWLLT6c0H4CDr+JsH0IHzXisLbJQgZ0Oa+vBPUbjJEvc zuUa5oaeqx72NzHqwElLd9QwZdy2bT7d+0/TswS76waVrqpVd1+NuYIvAds4hD7vx3BV QAZjXhIIgc7G2NvE5jRtuCvKZ53TWzW+TRt9Klnf46r2M++n5BO9Zkmn/JkwQfqL/a56 Fl6CLUm8rNERxpo3w9TcQeYkNR0X7y7IzF5FxTNcNXCLPKvIA/JJwOQw/yL0p42YNrgU dNNA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=CpsfIRbJ; spf=pass (google.com: domain of vasileios.almpanis@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vasileios.almpanis@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-4870bf54378si4984019f8f.287.2026.09.16.05.30.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 05:30:21 -0700 (PDT) Received-SPF: pass (google.com: domain of vasileios.almpanis@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=CpsfIRbJ; spf=pass (google.com: domain of vasileios.almpanis@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vasileios.almpanis@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=rGWIjNrhAFHCZSRI45SebklpbbS1riUIv5xG9LXnKec=; b=CpsfIRbJ9hm7 PMBVt+z+bWzAP23qs9Zmu0GiKRBdcnyZ/Xw/yTV15Z9WQP0feeCLdlClTe06vdxpCp/sSI1CEikjl ErLIOebvQssbn9BvnM5D2w2/m1OLlm1+EA0jPljEp184rnQB4baNsAZlFi6E6w4U20jb4lGlVR2F+ ahCpp/KXiYVUtxj1kc+ZzO6twKiU+07pMpJxQ3yNboQBUr2756fK/3AwAzvSz3VCepP2YTpiKHS0C zMcFRUD7yVfuckaCK7feQ8EJTK5TzrRebGfx9qrLam+FJgQkdbLYO97B0bm3tNbG4UNYBIWP/Olou jwYtbfhQbONeekrTNGBaLw==; Received: from [130.117.225.5] (helo=dev010.ch-qa.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1x6ojb-003CPH-0N; Wed, 16 Sep 2026 14:30:20 +0200 MIME-Version: 1.0 From: Vasileios Almpanis To: Vladimir Riabchun In-Reply-To: References: Date: Wed, 16 Sep 2026 12:30:19 +0000 Message-Id: <178956181961.300113.10513692198174265606.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789561821; l=3557; i=vasileios.almpanis@virtuozzo.com; s=20260812; h=from:subject:message-id; bh=84ayWlJIPUZReQ/ZULE5k2/AlcP33fHuPF/FP0GuU9E=; b=YzTE4dsIFVZIlvz1jDRqKNIs3ugJ1BNHoLakgDqZnSDQXazlXfAXa0TPVVoVPMj65rzqpO+X/ bzh2aY0AO8nDivl8X8dVMa25f6nsPGb1nwUaF/dx9J1LxdiBBT2IPGY X-Developer-Key: i=vasileios.almpanis@virtuozzo.com; a=ed25519; pk=HhuHDXAcPva9A8zccWEMRsb36reu+y4IVbBjXKxNUjw= X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH VZ10 v9 0/8] Add per-VE failcount support X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org > This patchset introduces per-VE failcount support. > We have several resources, that have per-VE limits, > the users might want to know what limit hits make > operations fail. > > - Patch 1 is cosmetic, nothing special. > - Patches 2-4 change mount number and limit processing, > unifying it with other resources. VE selftest is updated > in patch 3. > - Patch 5 greatly reduces the amount of copy-pasted code > by introducing some useful macros. > - Patch 6 adds per-VE failcount file. > - Patch 7 fixes kernel log leak to containers from interrupts. > - Patch 8 introduces new VE selftest, that checks mounts > accounting, limits and failcount updates. > > NOTE: for running new selftest this change should be applied on > top of "[PATCH VZ10 v2 0/3] Improvements for ve selftests" patchset. > > https://virtuozzo.atlassian.net/browse/VSTOR-135520 > LGTM. Note for Kostya maybe apply patch 7 before patch 6 so if we bisect we won't hit a step where logs are leaked to random CTs. > Changes since v8: > - Added new patch 7 to fix logs leakage from interrupts. > We are fine if we miss some failure logs in container > dmesg - CT can check failcounts anyway, and bringing > new ratelimited printks with specified VE is too hard > for such a small thing. > - Selftest in patch 8 got major rework: > 1. Correct mmap error handling. > 2. Dropped mnt_cost value. Let's force 1, it is expected > value in fresh mount+VE namespaces. > 3. Proper solution for pending mount destructions. It used > to be just sleep(1) which may not be enoght on loaded > machines. Instead, issue rcu_barrier and wait on mnt_avail_nr. > Since we forced mnt_cost == 1, it know precisely what the > new value should be. > > Vladimir Riabchun (8): > ve/ve.{h,c}: Farewell to spaces as indents > ve/fs: Rework per-ve mount count > selftests/ve: Update ve_ns_owner_test > ve: Move from global VE mounts limit to per-VE limit > ve/ve.c: Generate VE resource accessors using macros > ve: Introduce per-VE failcount > ve/printk: Don't use ve log outside task context > selftests/ve: Add mount accounting selftest > > fs/aio.c | 1 + > fs/namespace.c | 80 ++- > include/linux/ve.h | 35 +- > kernel/bpf/syscall.c | 1 + > kernel/printk/printk.c | 7 +- > kernel/ve/ve.c | 277 ++++----- > kernel/ve/veowner.c | 19 - > net/core/dev.c | 10 +- > net/core/neighbour.c | 3 +- > net/core/net_namespace.c | 4 +- > tools/testing/selftests/ve/.gitignore | 1 + > tools/testing/selftests/ve/Makefile | 1 + > .../selftests/ve/ve_mount_accounting_test.c | 550 ++++++++++++++++++ > tools/testing/selftests/ve/ve_ns_owner_test.c | 37 +- > tools/testing/selftests/ve/ve_selftest.h | 21 + > 15 files changed, 822 insertions(+), 225 deletions(-) > create mode 100644 tools/testing/selftests/ve/ve_mount_accounting_test.c > > -- > 2.47.1 > > _______________________________________________ > Devel mailing list > Devel@openvz.org > https://lists.openvz.org/mailman/listinfo/devel Reviewed-by: Vasileios Almpanis -- Vasileios Almpanis _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel