From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH vz10] selftests: pidfd: add a settings file with a longer timeout
Date: Wed, 16 Sep 2026 18:55:49 +0200 [thread overview]
Message-ID: <178957774996.2491521.6411977564192771499.b4-review@b4> (raw)
In-Reply-To: <20260916121042.794260-1-eva.kurchatova@virtuozzo.com>
> The pidfd directory has no settings file, so every test in it gets the
> 45 second default. On a slow node with a coverage kernel pidfd_test
> runs past that and is killed while it is still passing:
>
> not ok 1 selftests: pidfd: pidfd_test # TIMEOUT 45 seconds
>
> Ask for 300 seconds, as cgroup and kmod already do. The setting is per
> directory, so the other pidfd tests get the same limit.
>
> https://virtuozzo.atlassian.net/browse/VSTOR-139651
>
> Feature: fix selftests
> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
i've changed commit message a bit, but overall - ack.
>
> diff --git a/tools/testing/selftests/pidfd/settings b/tools/testing/selftests/pidfd/settings
> new file mode 100644
> index 0000000000000..694d70710ff08
> --- /dev/null
> +++ b/tools/testing/selftests/pidfd/settings
> @@ -0,0 +1 @@
> +timeout=300
Reviewed-by: Konstantin Khorenko <khorenko@virtuozzo.com>
--
Konstantin Khorenko <khorenko@virtuozzo.com>
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-09-16 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 12:10 Eva Kurchatova
2026-09-16 16:55 ` Konstantin Khorenko [this message]
2026-09-16 16:56 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178957774996.2491521.6411977564192771499.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=devel@openvz.org \
--cc=eva.kurchatova@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox