OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH vz10 1/4] ms/selftests: mptcp: join: rm: set backup flag
Date: Wed, 16 Sep 2026 19:08:02 +0200	[thread overview]
Message-ID: <178957848262.2493923.3305461447408337346.b4-review@b4> (raw)
In-Reply-To: <20260916121740.796320-1-eva.kurchatova@virtuozzo.com>

> Some of these 'remove' tests rarely fail because a subflow has been
> reset instead of cleanly removed. This can happen when one extra subflow
> which has never carried data is being closed (FIN) on one side, while
> the other is sending data for the first time.
> 
> To avoid such subflows to be used right at the end, the backup flag has
> been added. With that, data will be only carried on the initial subflow.
> 
> Fixes: d2c4333a801c ("selftests: mptcp: add testcases for removing addrs")
> Cc: stable@vger.kernel.org
> Reviewed-by: Geliang Tang <geliang@kernel.org>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> Link: https://patch.msgid.link/20251110-net-mptcp-sft-join-unstable-v1-2-a4332c714e10@kernel.org
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> (cherry picked from commit aea73bae662a0e184393d6d7d0feb18d2577b9b9)
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-139651

This link does not lead us to the test failure at all.
Please always use those bugs which have introduced the issue fix by the patch.

https://virtuozzo.atlassian.net/browse/VSTOR-145479

Reviewed-by: Konstantin Khorenko <khorenko@virtuozzo.com>

-- 
Konstantin Khorenko <khorenko@virtuozzo.com>
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  parent reply	other threads:[~2026-09-16 17:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 12:17 Eva Kurchatova
2026-09-16 12:17 ` [Devel] [PATCH vz10 2/4] ms/selftests: mptcp: join: endpoints: longer transfer Eva Kurchatova
2026-09-16 17:08   ` Konstantin Khorenko
2026-09-16 12:17 ` [Devel] [PATCH vz10 3/4] ms/selftests: mptcp: join: userspace: " Eva Kurchatova
2026-09-16 17:08   ` Konstantin Khorenko
2026-09-16 12:17 ` [Devel] [PATCH vz10 4/4] ms/selftests: mptcp: join: properly kill background tasks Eva Kurchatova
2026-09-16 17:08   ` Konstantin Khorenko
2026-09-16 17:08 ` Konstantin Khorenko [this message]
2026-09-16 17:10 ` [Devel] [PATCH vz10 1/4] ms/selftests: mptcp: join: rm: set backup flag Konstantin Khorenko
2026-09-16 17:20 ` Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178957848262.2493923.3305461447408337346.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=eva.kurchatova@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox