From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id D90928015B for ; Wed, 23 Sep 2026 18:39:24 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68NIc4AJ004004; Wed, 23 Sep 2026 21:38:04 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68NIc4AJ004004 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="RX/9ADDT" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68NIc3b5003996 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 23 Sep 2026 21:38:03 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68NIc3b5003996 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-4843e59c32dso994545f8f.3 for ; Wed, 23 Sep 2026 11:38:03 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBzBhHVCfIX/+RskLQA/5SRgxjp6Df46edJ9a/3Q7rfzr50laKpND9LhVyAOTHovOkKCwCXN3g==@openvz.org X-Gm-Message-State: AFuF++lt/5D1lblsdyvZBra9CF1sX6sj3Gh+9/rTyLDkdxld6XIinCX+ OtjGQ8JPaq2G5/bRCr+GPQyJkk6ap9hAK3YEsFL27GLfRAJwUTPxasVtkr5t7cqjXxzFXdixM61 9NbOBrPxGv7X1tWebfvFhvG1AEhMmH29jJXXEZdvYxjpfGsAGTFUpUA== X-Gm-Gg: AYBFou31ZzWVoSmyZA0Vu7Y5ZqWhl4LItWJUFv6EnIFgxAIjnxpVRJRHW/cGpTlw4pq uk/vPE4XiVRpUwEGXq2YZG9ff/LwaPO3EvQErvISTXaKEsF6/lzjvVCdgLfdMILu1zPGgqYPFzB P5ZbbCppb4a+59D9hdghv+vFPeJfYqp+HGjxkUs2iEobX7TTLeiMOp6e+6sjtd2M4cKVFRJOWAC KTZL/g2CmW+Ktck6gsbcS6EvXuXe87NEJeIArgV93me+WdomZQATXkAAvSqcD96DEh7Kw6LffUt Xvkl069t6IQdDXMtt/UeKKGDr7sczTNKsnF5mmyfMgdRF/j/TNECaMhkh0YI8uTBDLYGmu9IZot 833AXA7Or0c0kswNgBLAqEEjbJVW7 X-Received: by 2002:a05:6000:2506:b0:487:2385:e19c with SMTP id ffacd0b85a97d-488716b3d5dmr70835f8f.0.1790188682787; Wed, 23 Sep 2026 11:38:02 -0700 (PDT) X-Received: by 2002:a05:6000:2506:b0:487:2385:e19c with SMTP id ffacd0b85a97d-488716b3d5dmr70794f8f.0.1790188682351; Wed, 23 Sep 2026 11:38:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1790188682; cv=none; d=google.com; s=arc-20260327; b=ZFVVxN2UjkqnRKXCDXEaGESzBLock6c+D12b7DXzFrJKb3bIkmExNmqZ0t6WMDjpan McNvjtA4uYtHpvUHE3qPEdvH+CNEaWSsQBu9Gpd5xOCSSKovBNhF6FVv4HV9P/xVqxiO NYyX8bW7PZ7ciyqe8CqOmnOjV3hv8tTmbReWR1BwLloFRFRamQu054v9ojY3W56VfN8H Dlh9LstHe8AxCGJalSJmwu4H+TvFKNO5nttFNamr21KjLynRWGtaqrd49+7irWC7WL+I K9R4IOTRp/AopkQWsLT8SWi+hrw4k1OiZf5iG2CTLjydWoMV9JvRgA5gD+mL6GsYQ7Ln VJMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=tJJmcagVD7s1HiIVCTQn/N1nkWSSG7gSt9PiZG/1U6U=; fh=CTF2GHyV+XdzB5TROrdG4fdLri6JSHNOBC+LNuNq5bA=; b=ScXPsMvgcp8g7SP69iQ6anDF07By4J3dvPmfIK5eAm1MALgAykxSil2f8q39EqNlhW 7XY1FlxCd4ghQyAcGhj3KJATzCXkrEhvrftdAK9VoHKz4DxHp8mmto/n3PPejqFChb2z htG1QEwaEVuEr8gTyL1FTHCA2IuIpd01u8rT6eFNqkg8faRv3woFcb9/0CkdrU8ir/8i PMfy+eWLQ8lE/7rhOoL+MQUVi3ba8PnBuO2u5NZ4VsSGLSbmthPER3Aue9HZWXtfeG3C mF3LGK9f084cwDtAFWsKZ4uGJhERh57Q3bpE3W4ww6nLqONXJhqvZTZjAFATHW8bEkTO Hq0w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="RX/9ADDT"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-488688ac4c8si6059841f8f.110.2026.09.23.11.38.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2026 11:38:02 -0700 (PDT) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="RX/9ADDT"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=tJJmcagVD7s1HiIVCTQn/N1nkWSSG7gSt9PiZG/1U6U=; b=RX/9ADDT8e/g /ftSC0c3jVTztxiO3feXcc7Dw9ZYL22/fw64efWbKcHJYWgwwm6ycGgYbQIX6sdKIc3+lW5MME8CZ v0QZZovIkyEdDvXF4bxJjN8EMfLtPF8L+34sHHb4xBpYWF7acOj1tiyCwRqDvG5vZ64L7upooPJzK Jt1NkXd3veZw+r4bxZHvIwovi8R7nz23nJe0xDgP+apkIRYatCnVWOU1vwKMQvmXgptf4y7tP9YJZ O0yFMO4s3+bBAjPXQHfb5+Wbv+tbDN8Ewak3FEbCCswls4Xo3jOXPrmnRnQCeUuD+yIAB/XnNW7CP XGI1W0GlGiToFeCZBpRrKA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1x9Ro4-00AUN4-1p; Wed, 23 Sep 2026 20:38:00 +0200 MIME-Version: 1.0 From: Konstantin Khorenko To: Eva Kurchatova In-Reply-To: <20260910031755.397386-1-eva.kurchatova@virtuozzo.com> References: <20260910031755.397386-1-eva.kurchatova@virtuozzo.com> Date: Wed, 23 Sep 2026 20:37:57 +0200 Message-Id: <179018867762.3139026.4098224502754980230.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2645; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=/+SSTpbHy2lQf0BdGX/z2Rs/SKX0cRSDxXkkkePu2uw=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBqtByIs56jKXzDhK6/CAIop4AGsliXJBzGNIRQ7 AVimjSSFSCJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCarQciAAKCRBRlgpH+WFc KmWeD/wK6KZfo6yIjqff2EGV713tYBqsv6QoPtI+JH0f5VQdsE+MZTD0zVgr7A3FWY8vA7CLbKi oR38wtwmsf2CFhyss0WHU3JHuk0VW6tm2g87sBhsCXMXFMcB+YT+4O97ueLxO8g6dSG8kCGxlia 4P5QjiMqdW4oYtci06LceWTVGP8/0RQZzebmB8Rf1zzRLwnDJmJTSXN3Py0XbsE2pNA7wF0qq81 AozTlgfoW4AsoDtYcGz7d6CN82hCZxw4J6+r7NUWdiJSHN/0D4eIFfpAskTgfm7/5PGWvSCizgD WB6YeQ7ysoZRXGhW5/ib9Ig5ERfWLSUw+STq/no0v0JpBsXcXP5NyzN0K2XIJySy9Tao5YCjyhR N4IjGJBHXS5j84g+BKvLFx9PCunCwuOYeeUUhNTyKfilDpVLdbKZ8Mxx0U1J4NDiP9IaF36pI6v 1ONCTYbeJGi5KknVHxSso0x/mmx/nVbSy3HXlReC9gOqHP5PylabLth/wyNVkmUQF5demfsp/Nh 4OzEwvBE38ARCnLQrB52GzEGqOfRjVn9/zxqVq/RDg70NyBFC6+u5UbLTzMZrtdZa06hIA52vEr GDnkf4kZuszNl8hLUx4UHPCNCluJXsEx/ij241U+YN3pBf8uOZoendeURwq2JZW03dREi0llnWF uELHxji+S6GdTbA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH vz10 v2 1/2] selftests: pstore: skip when no backend is registered X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org > An unregistered pstore backend reads back "(null)", and every latter latter -> later > check fails. This also contradicts the pstore_crash_test documentation. > > Fix by skipping an unregistered backend in common_tests > > https://virtuozzo.atlassian.net/browse/VSTOR-142447 > Feature: fix selftests > > Signed-off-by: Eva Kurchatova > > diff --git a/tools/testing/selftests/pstore/common_tests b/tools/testing/selftests/pstore/common_tests > index 4509f0cc9c918..71cd4473f45a5 100755 > --- a/tools/testing/selftests/pstore/common_tests > +++ b/tools/testing/selftests/pstore/common_tests > @@ -55,6 +55,8 @@ operate_files() { # tested value, files, operation > > # Parameters > TEST_STRING_PATTERN="Testing pstore: uuid=" > +# Kselftest framework requirement - SKIP code is 4. > +ksft_skip=4 > UUID=`cat /proc/sys/kernel/random/uuid` > TOP_DIR=`absdir $0` > LOG_DIR=$TOP_DIR/logs/`date +%Y%m%d-%H%M%S`_${UUID}/ > @@ -74,8 +76,17 @@ prlog "=== Pstore unit tests (`basename $0`) ===" > prlog "UUID="$UUID > > prlog -n "Checking pstore backend is registered ... " > -backend=`cat /sys/module/pstore/parameters/backend` > -show_result $? > +# A tristate pstore leaves no parameter file at all when it is not built > +# or not loaded, and an unregistered backend reads back as "(null)". > +backend=`cat /sys/module/pstore/parameters/backend 2>/dev/null` > +if [ -z "$backend" ] || [ "$backend" = "(null)" ]; then > + prlog "SKIP" > + prlog -e "\tbackend=${backend:-}" > + prlog -e "\tcmdline=`cat /proc/cmdline`" > + prlog "pstore backend is not registered, skipping" > + exit $ksft_skip > +fi > +show_result 0 > prlog -e "\tbackend=${backend}" > prlog -e "\tcmdline=`cat /proc/cmdline`" > if [ $rc -ne 0 ]; then After the patch and "show_result 0" $rc here cannot become 0. -show_result 0 +prlog "ok" prlog -e "\tbackend=${backend}" prlog -e "\tcmdline=`cat /proc/cmdline`" -if [ $rc -ne 0 ]; then - exit 1 -fi > diff --git a/tools/testing/selftests/pstore/pstore_post_reboot_tests b/tools/testing/selftests/pstore/pstore_post_reboot_tests > index d6da5e86efbf8..a5464407f5b21 100755 > --- a/tools/testing/selftests/pstore/pstore_post_reboot_tests > +++ b/tools/testing/selftests/pstore/pstore_post_reboot_tests > @@ -7,8 +7,6 @@ > # Written by Hiraku Toyooka > # > > -# Kselftest framework requirement - SKIP code is 4. > -ksft_skip=4 > After remove, we have 2 empty lines here, drop one. -- Konstantin Khorenko _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel