From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id D57B1802A5 for ; Thu, 24 Sep 2026 11:54:50 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68OBraUA014880; Thu, 24 Sep 2026 14:53:37 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68OBraUA014880 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="CJt2yJGW" Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68OBrQx8014860 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 24 Sep 2026 14:53:27 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68OBrQx8014860 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-490a767b782so15420645e9.2 for ; Thu, 24 Sep 2026 04:53:27 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvByJwoyAYtdcm5CqhZsotrU5IxyjVuG0QnJDDE9Ude+0mr27+2Xbcq/xWAlplP/9rWZXo8FXug==@openvz.org X-Gm-Message-State: AFuF++mGfCatnVP9bDq3TVS8h7qKynVRDhXjIZQkmd091ER1AKMQgzEL zYlmjNe3JNN5jgFCWQeC1YCyqnuJAVOzsFr6UwI0qfbE9GlLMnkSnhAoCqfVjWM/Nkze95DsUbo G2MqOTxNAT6MFXR8lQrd4/tPFduA1PjbUQgJJMq2duE2M/j5x7DtlQQ== X-Gm-Gg: AYBFou0BLyv6oSB+eXrzNg4Gz/QPpMeyQtWTdFbw1rcPM9eFcG/tUUNn92VT6F6BQ4H wM3CZrOg4zaZi4rVpPWz+AcOq+7fs3MmAJIJ+3bNPyoGMgo1xUX0nONDoqF06LtH8tPveG/i99t eLVjWF/8Vq3hJnn3O0NBWRb/svZ9rjHuATE47FezCIgy7kI14guEmupIRvC7Up4AQ4AyXob6r+8 kCDG5qyi5nQC/l91OyxvoNz5JT4qFuEStRZkUVsOpoDoIym313z/yO1auPqUEHyqsBO8eifSyWp VL08x2yHwU+Tps6BpBSjVyAm1zGWHNz7MNbHVY03PnrOXAmNFfzVUqxgKupW5X5wzwupv147ber 2UjEoXxoHVL+niABS X-Received: by 2002:a05:600c:1546:b0:49e:7a00:b9a5 with SMTP id 5b1f17b1804b1-49fe66bdee6mr39096565e9.4.1790250806612; Thu, 24 Sep 2026 04:53:26 -0700 (PDT) X-Received: by 2002:a05:600c:1546:b0:49e:7a00:b9a5 with SMTP id 5b1f17b1804b1-49fe66bdee6mr39096015e9.4.1790250805923; Thu, 24 Sep 2026 04:53:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1790250805; cv=none; d=google.com; s=arc-20260327; b=Spwx2RCObALqeNfGVn4yXVWgCQPNW7hQUfd0+/ppC15ZiGFK5zf5/eEVk3taVaago1 2MZRzf0eiA3KK777hMmjKaOUNyekzzQvYAA8JPOCwZjP3xrpb8LkiZ7bbPeJNgeVh8DH RSnZBK1y0tkp2uJH4IaQmYB5tkBlJ7VISF5X53PKQTh0eLPEXppWfKjQ26IcvO/P+9Yl O23uj5fZfr4QEKj1F/olKSqJglnndO5M0mkZCpVb+Hn4wQO2+CfCbzDZbJCr8RzJVMXE J2g7hu0nKdRrXpctizguXIv7CMKAUnfA1TooGZvsBhVqdyHZtkO1x73CqDBoM5PjyiA/ 68RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=5WbB0GtVYbLxO1ttQYhuAIpb04lOyixqVUZCkfTpkWM=; fh=CTF2GHyV+XdzB5TROrdG4fdLri6JSHNOBC+LNuNq5bA=; b=jkAVx0AiKe5a2PY8Kng4I6uIKgvU7IEKIS1VujG+1gdr5VirG36luRmIoRbVA9n4z5 0R1UHe/T/KGgXWjnL6k+CJJ4bxaZjRjJ0ZvKOxNd9CONazG/o4id+M1x+EKHxTXGd8zw HMIRJyBXO8krQIZYgzo04eXbhP148Oc+1dJtzgNBOgaWnigW22d1UzGEni1L4bsolV1s 38QsbpVXNnvU6ina4+ydC3nzGVHcQ9/iWcRLox78dsMdTn5N8gn6JXvpNZH3V13vokVG h8HrRFdZ/li/faQ6PJu6iVbeNF2odLtKqJFBt+WhpYLUH60WmTBg5v/jSj5zHFPTuEit WnFQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=CJt2yJGW; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-488688e5d99si9060064f8f.423.2026.09.24.04.53.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 04:53:25 -0700 (PDT) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=CJt2yJGW; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=5WbB0GtVYbLxO1ttQYhuAIpb04lOyixqVUZCkfTpkWM=; b=CJt2yJGW7uYj Q940utpwExDBQJNjCZm+CGZ3BUlahsgJYFj75NGlUSMf1NjY4VzFZkv0JpPGhxBzjZPTWGkpeciQr 4thGkKLmwlNT2utvfma71J/o3y/vfiL1MjFxrjbOmeonMkK1FwLiopNmZVOyeSuigZo1VWRPLt1eF dT0Qs+lLb66+V2+Q0TL7BYY+Okt4CBRMeJ9IDfpOZ/F7n1/LciRlPRh730OXSpHlLaf2mQRBYwv5F uG+d7gFVPMJ0Z8bclMWCrNa3dYLO68TFsX8SxG3TToKggsjyu3/UcFcVjdk5oMEhFuwT7YuNFkO91 INPRXG93IiA167CDAKywIg==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1x9hy3-00DWwF-08; Thu, 24 Sep 2026 13:53:23 +0200 MIME-Version: 1.0 From: Konstantin Khorenko To: Eva Kurchatova In-Reply-To: <20260831234411.1649762-3-eva.kurchatova@virtuozzo.com> References: <20260831234411.1649762-1-eva.kurchatova@virtuozzo.com> <20260831234411.1649762-3-eva.kurchatova@virtuozzo.com> Date: Thu, 24 Sep 2026 13:53:20 +0200 Message-Id: <179025080051.3192281.14851162512684346903.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2295; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=cNYeXGGjq+bsglFm244olDBZCmRGTv/xHui44/xucjY=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBqtQ80ECYYfAOkR8AOVQ0cjf9E9H/u4TscjJlQV 3PHtjH9gZ+JAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCarUPNAAKCRBRlgpH+WFc Kg1LEAC0oynEMeJyLJUL2YNYt8R4BMWEMGWNnSJjdEg8PopGQEKileHgNTfCt6BZjwuiAFhQTIC cD4b2EvUifqymnauUxP8SjTUM4vNF+JgFMWh54/BP0doQ5lKZh8iLDNtJUGepCYg0vQlFaDdBQd wSeah5yRF1Xlef9hZ1/I2zs02t8TOD5lsyJL+VseccE6BYGy+0Dx6bydw7AMHrSvLD2QCuvAfpa u37KIE3RaBv3gGEXjPOlgzBnNRIWxBXtC5k5jxCBHTB3j1X1x+mWPL6UT+cWsqdX3ii+GT6wtE9 p9ykkCEYhJwK4+t1w5tcGc9nYLBAHOSHrzoH98njAEBH3ZbvEh2GFgRwLCFOdRuli+qjcp/RAva rQ8H1J8t1UGgfvT0vAbz3fvfXQ8xuHGJjhuj/eHRg3qAlnQxI1OH7XmCSAVJhmZnH3UDb9jZVqt tESwLneSggxVOmVWXBgOfRsKiVLj77Ss6lRVfB/qMCCl6s05rKZxh8vSPhe5VLVCI3iml87AkGL JrVJFnVNJgumQ0HHBBgalj0AFVA9vauYyBRucn0+54dFGokW+ncKrg5R2HOO4v6xhxgSWwrHwsk RwVLLfC6LFIrqdaosLAJDWQMtSip6WKtXnrcbM1Q4aLzko3cflwc8mVuDptbIg7NrvSNL0r7yrI H6hXzZpHZ7yfyzw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH vz10 3/3] selftests: drv-net: read the channel count over netlink X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org > napi_threaded needs the number of combined channels of the device and > asks ethtool to print it as JSON. Not every ethtool prints that one: > ethtool 6.11 does it for -k, -a, -c, -g and -x, but not for -l, and > the test ends in the first case: > > CmdExitFailure: Command failed: ethtool --json -l eth4 > STDERR: b'ethtool: bad command line argument(s) > JSON output not available for this subcommand > > not ok 1 napi_threaded.napi_init > > Ask the kernel for the count over netlink, which is where ethtool reads > it too, so the test no longer depends on the ethtool version installed. > Changing the count stays with ethtool -L, which needs no JSON. No other > test in the group asks ethtool for something it cannot print, so this is > the only one that needs it. > > https://virtuozzo.atlassian.net/browse/VSTOR-139651 > Feature: fix selftests > Signed-off-by: Eva Kurchatova > > diff --git a/tools/testing/selftests/drivers/net/napi_threaded.py b/tools/testing/selftests/drivers/net/napi_threaded.py > index ed66efa481b0f..73c81a319b49f 100755 > --- a/tools/testing/selftests/drivers/net/napi_threaded.py > +++ b/tools/testing/selftests/drivers/net/napi_threaded.py > @@ -7,7 +7,7 @@ Test napi threaded states. > > from lib.py import ksft_run, ksft_exit > from lib.py import ksft_eq, ksft_ne, ksft_ge > -from lib.py import NetDrvEnv, NetdevFamily > +from lib.py import EthtoolFamily, NetDrvEnv, NetdevFamily > from lib.py import cmd, defer, ethtool > > > @@ -28,7 +28,13 @@ from lib.py import cmd, defer, ethtool > > > def _setup_deferred_cleanup(cfg) -> None: > - combined = ethtool(f"-l {cfg.ifname}", json=True)[0].get("combined", 0) > + # Not every ethtool prints the channel counts as JSON, the one on > + # the test machine here does not: > + # ethtool: bad command line argument(s) > + # JSON output not available for this subcommand > + # Ask the kernel for them instead, it is the same number. The long description with error messages examples should be in the commit message, not in the code comment. A short comment like "not every ethtool prints -l as JSON, ask the kernel" should be enough. -- Konstantin Khorenko _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel