From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH vz10 1/3] selftests: drv-net: let NetDrvEnv take nsim_test
Date: Thu, 24 Sep 2026 13:53:20 +0200 [thread overview]
Message-ID: <179025080051.3192281.8333419255063294884.b4-review@b4> (raw)
In-Reply-To: <20260831234411.1649762-1-eva.kurchatova@virtuozzo.com>
> rss_api.py opens its environment with
>
> with NetDrvEnv(__file__, nsim_test=False) as cfg:
>
> NetDrvEnv hands every keyword it does not name to NetdevSimDev(), which
> takes port_count, queue_count and ns only, so the test ends in
>
> TypeError: NetdevSimDev.__init__() got an unexpected
> keyword argument 'nsim_test'
>
> The test came in with the RHEL10 import, commit 9f055df11343 ("rh10:
> import RHEL10 kernel-6.12.0-211.16.1.el10"); the parameter it asks for
> did not. Take the env.py hunk of commit 185646a8a0a8 ("selftests:
> drv-net: add tests for napi IRQ affinity notifiers"), which added that
> parameter upstream. The test that commit adds is left out, it needs a
> real device.
>
> https://virtuozzo.atlassian.net/browse/VSTOR-139651
> Feature: fix vz selftests
Feature: fix selftests
--
Konstantin Khorenko <khorenko@virtuozzo.com>
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
prev parent reply other threads:[~2026-09-24 11:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 23:43 Eva Kurchatova
2026-08-31 23:43 ` [Devel] [PATCH vz10 2/3] selftests: drv-net: run ping in its own netns Eva Kurchatova
2026-09-24 11:53 ` Konstantin Khorenko
2026-08-31 23:43 ` [Devel] [PATCH vz10 3/3] selftests: drv-net: read the channel count over netlink Eva Kurchatova
2026-09-24 11:53 ` Konstantin Khorenko
2026-09-24 11:53 ` Konstantin Khorenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179025080051.3192281.8333419255063294884.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=devel@openvz.org \
--cc=eva.kurchatova@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox