From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 9B2EC802A7 for ; Wed, 30 Sep 2026 13:53:15 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68UDpnO1020927; Wed, 30 Sep 2026 16:51:50 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68UDpnO1020927 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="xXIk0Hig" Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68UDpmLw020923 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 30 Sep 2026 16:51:48 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68UDpmLw020923 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-49e7631c43aso51718705e9.3 for ; Wed, 30 Sep 2026 06:51:48 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvByJeAElnArRmZmN+jsN2Qy1HA2E5Fu86T22pYUS9cvtu2G+553NsIfsVd4TXp+ZqTInfGn82g==@openvz.org X-Gm-Message-State: AFuF++mvRwrnq9puz9+1cIFVsVQ6CBKnKZgBABtkhe9Uag2/vA/SAGvJ pFd4qMpOls77XPXaz3hB2APDZDckI2bPDy+xgG1yH540IgZQjJUUUCQl4TDvY+yUhkmFdn/jLPz 77D7MZIV6CXMCLn19vd4tgaINlffGsTDGWqOPpsmP/XI/4yVO/9FxHw== X-Gm-Gg: AYBFou0JN9b0cVrb0djJvVvQZ0sBHB5QkL6+p0HnARoYWWWLNYyN30YzNMC/YTxGSR0 QBLdKrw7g2b8Fy2b5+nJw2gY/Us73TotbWtf7L1vc3U5odc/zopn4TTj4qfM1zXqrKd8gWm229h 7D76Q0IzFed16uGIBe1ae7cRp7fgTM4bgBUr/iQl3nNG9G6yPaKBlDaqfSkxGSoUxEbQeMkOGcu YbG7NcIgU1SJB3YGqnaFuzBWhbGGXC/neNQAo3gj20Bq102uJ3rP0Fb9ZX11JLGIujHOIBNsYJR vms+cemX8gSqYATzJTMJ7/o8y1swf+OPKReA6GoZPUy/gGjQtXUtNVfoxyU/L+yzxzH0kBR0Mqr IbsVsPYPRUIGoDf2R X-Received: by 2002:a05:600c:3486:b0:49f:bd3c:bc16 with SMTP id 5b1f17b1804b1-4a01b003c50mr20025185e9.17.1790776308137; Wed, 30 Sep 2026 06:51:48 -0700 (PDT) X-Received: by 2002:a05:600c:3486:b0:49f:bd3c:bc16 with SMTP id 5b1f17b1804b1-4a01b003c50mr20024965e9.17.1790776307579; Wed, 30 Sep 2026 06:51:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1790776307; cv=none; d=google.com; s=arc-20260327; b=EtrovTo499ZiJLEJJhBBZVgHme/FDThNXZfwBLA3q5Ikrub59tHPp87oqN+/hemlYm 2PGz7QF46mwjvCV5XJQxXAnfbZRONhtJMh6+PZ9JdHdmDOcNz83ksoNz0PU8VnziZU+0 RWhNxsD4GwIaeSAXoaEQ2ba+U46SFoaDQxdNV1PZbkDYhlcNy2Yn9TLauNDv5DUZExE2 QwRVXTPqnVKiiXu2Uo8QOxuYnR4OIi8JlmCbwV4gWlqgkT7jsrs3l/WXRo9BqNXiDyJ7 CCmAR2VnJ9zBODtoTMb9J09fDw1wRwWs/QdlH7cqdEXJsMbLErPyaey08/S7Ec9XVuHr 0sMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=bYOyLpF3/asNhzaNP1zFypz98ir7n7e4IOM2ARnZncg=; fh=CTF2GHyV+XdzB5TROrdG4fdLri6JSHNOBC+LNuNq5bA=; b=oM2jpAj7+zqmWnTlMaqdV5BvRBtncX61cq5Ku+ehh0GIzbzCO+3IvuHr+PC+F2crJd zWAtKZ27CBYWRzXNaUUMtaFXutKtz2+4GfPK1o6VBJ/7kS8ZOFWJUi5Xch1NmSog0lm1 GzJ4UwjGwcRK+GYNONkJpb3xD9Tl28W+azBwdCutkrNWSwiozJGZCKGwa5KMMRb02VMg E+Zyz6IEJQ8g02NAMQmriV9lXg8rT6/pAMb1aDYUFN+545lIamlY4yOLq2K58XK5eQKn tW8i7dhKA2erUsWJ8vWgh/u9bmnTKDqllfGbajkqPznrWJPfI7xIRaay8ZgTsqpWE47I +hAg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=xXIk0Hig; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id 5b1f17b1804b1-4a01e3c7b98si2011915e9.1.2026.09.30.06.51.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2026 06:51:47 -0700 (PDT) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=xXIk0Hig; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=bYOyLpF3/asNhzaNP1zFypz98ir7n7e4IOM2ARnZncg=; b=xXIk0HiggkGK iTQkicxo0jCRO4emZYY/z858L7Q4fXcwqdf07YGOGuY7bDA0bXvaQqDaPx1PnB1G2N+4wkHwMWevs IyRAdOREZ2UsPwMAeX/vUJzwAT1cEDn1VxWTU8sQQ4YIS3xpKD1ivd0u5a9jJDlnIB4v+zABja/q3 b+2sqPUdkNuUBdvZgvuAGDHtOC42B/NpQuiUyd36rpAqGYMTrmnxuVt/eJ0qsRHUHeE7wfp7F4TZC hbkXM4J9KT2M5U30x9622WwcoCFn64q6Nv/E1AZvh9CFUNACPiWbT7M94KJG/U6T/THLmRZ2SmkMq lQeyUmWIg6ZzLjbXEE4ypg==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xBufj-005c01-1D; Wed, 30 Sep 2026 15:51:46 +0200 MIME-Version: 1.0 From: Konstantin Khorenko To: Eva Kurchatova In-Reply-To: <20260928193506.549055-2-eva.kurchatova@virtuozzo.com> References: <20260928193506.549055-1-eva.kurchatova@virtuozzo.com> <20260928193506.549055-2-eva.kurchatova@virtuozzo.com> Date: Wed, 30 Sep 2026 15:51:44 +0200 Message-Id: <179077630438.3598112.6223753507691542141.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2585; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=xLfIjLSr9BGL6FTBxQq8/8mO6NUd/7M/r/mAuXKzVEM=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBqvRPyFX9K3UsRjdcW8ev/9anJf4+NduUukrsrW fyNtt9UEQGJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCar0T8gAKCRBRlgpH+WFc KlT4EAC4AifuyaCAuBytROdJlFJcIWE0a3dspirxdT2rLc5biMCVUsUlCohG3psprgrnhQJb4yV hxEwTkqKzZKxbNuww6+FbBUblMGRvkjWBF9hdSNJZ2kPHZhnCw+7y94L0/0344jRRY7YaJ9BqBX BO+2PS8brYURIh2UrvnEcybuHaidl8fhEE/tA8z1G/RsRODdIG29bLaHJXaPP/IyFo3UozFdAk/ NwzpYZe2JNybzz/A5CF3A1NhZ7rmn1i7Z5eMnF72uBTT8WBi8U0H2X7TCTCXifey8L5r4T2/J6L 4uv3kIa0UpzTF0IcPekpyY+jVQMQPtQ7H0qVKYYhUan0GaKR6bVDrlf1G3ZsvStuCTQd6XBbgPE HsNk0lA5g+pqKZmL6vZ83Vse76vK3Cwr/IT8cUaeAagF7KD9ZEvSawLaKU0tm1/ZR+Q6BgYu84k 1YUz6bcm1JPJOOYDs1urUbW8aHwLAfcvh9wf6cUdvN/XqlkQuZ9XVWQccdouKOjGpzh59861V7t R4cyzhEwyjp2azoaw/Zjw+ffXSwv9alydYOXWnex1GJhB/qBEZzYAfK9MQT7z1UtNUEvHe+88P3 983X4OXYgEDpZ5DuuJoHvWO76oXQZQSA4BgU/ZA/D6rcheT0jYS6pfvxRqvnzm3cQ/FROZU++5O Xp+auwkftTkYcNg== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v3 1/1] selftests: net: skip the veth GRO checks where they cannot run X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org > The three rx-udp-gro-forwarding checks in veth.sh count 10 packets > where they expect 1 on a host that has a vxlan or another UDP tunnel, > in any namespace, and pass on a host that has none. > > Any UDP encapsulation socket on the machine moves UDP GRO to the socket > lookup path, see commit f2e9de210d50 ("udp: gro behind static key"), > and rx-udp-gro-forwarding is then not consulted at all, see commit > 36707061d6ba ("udp: allow forwarding of plain (non-fraglisted) UDP GRO > packets"). The switch is global, so the test namespaces do not help, > and nothing the test can set brings the device flag back. > > Skip those three checks when UDP encapsulation is in use: a vxlan, > geneve or bareudp device, a fou port or an l2tp tunnel in any > namespace, or a socket on the vxlan or geneve port. > > https://virtuozzo.atlassian.net/browse/VSTOR-139651 > Feature: fix selftests > Signed-off-by: Eva Kurchatova > > diff --git a/tools/testing/selftests/net/veth.sh b/tools/testing/selftests/net/veth.sh > index 6bb7dfaa30b6a..3fcd63f93be72 100755 > --- a/tools/testing/selftests/net/veth.sh > +++ b/tools/testing/selftests/net/veth.sh > @@ -97,6 +97,42 @@ chk_channels() { > fi > } > > +udp_encap_in_use() { > + local ns cmd t > + > + for ns in "" `ip netns list 2>/dev/null | awk '{print $1}'`; do > + if [ -n "$ns" ]; then > + cmd="ip netns exec $ns" > + else > + cmd="" > + fi > + > + for t in vxlan geneve bareudp; do > + $cmd ip -o link show type $t 2>/dev/null | \ > + grep -q . && return 0 > + done > + $cmd ip fou show 2>/dev/null | grep -q . && return 0 > + $cmd ip l2tp show tunnel 2>/dev/null | grep -q . && return 0 > + $cmd ss -uapn 2>/dev/null | \ > + grep -qE ':(4789|6081)([^0-9]|$)' && return 0 > + done > + return 1 > +} > + > +# Only meaningful where nothing else has turned udp_encap_needed_key on > +chk_gro_fwd() { > + local msg="$1" > + local expected=$2 > + > + if [ $UDP_ENCAP -ne 0 ]; then Bug: chk_gro_fwd skips the checks on a clean host and runs them on a host with a tunnel. udp_encap_in_use returns 0 when encapsulation is found, so UDP_ENCAP=$? yields 0 = "in use". The top level gets this right: [ $UDP_ENCAP -eq 0 ] && \ echo "UDP encapsulation in use, forwarding tests will be skipped" but the helper has it backwards: if [ $UDP_ENCAP -ne 0 ]; then ... echo " skip - UDP encapsulation in use" -ne 0 is true when there is no encapsulation. -- Konstantin Khorenko _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel