From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: devel@openvz.org, Konstantin Khorenko <khorenko@virtuozzo.com>
Subject: Re: [Devel] [PATCH hci-8.1 0/2] selftests: cgroup: fix the flaky and vacuous test_memcg_sock
Date: Mon, 19 Oct 2026 21:59:51 +0200 [thread overview]
Message-ID: <179243999166.3624994.911602262116124183.b4-ty@b4> (raw)
In-Reply-To: <20261019-b4-prep-khorenko-vstor-149854-selftests-test_memcg_sock-v1-0-efbfa45dc967@virtuozzo.com>
On Mon, 19 Oct 2026 21:47:32 +0200, Konstantin Khorenko wrote:
> selftests: cgroup: fix the flaky and vacuous test_memcg_sock
>
> test_memcg_sock compares memory.current of its cgroup with the "sock "
> entry of memory.stat. memory.current moves at charge time, "sock " only
> when the memcg stats are flushed, and nothing in the test makes a flush
> happen. So the test either compares 0 with 0 and passes without having
> checked anything, or fails at random.
>
> [...]
Applied to branch-rh10-6.12.0-211.52.1.22.x.vz10-ovz, will be released in rh10-6.12.0-211.52.1.22.9.vz10, thanks!
[1/2] ms/selftests: cgroup: skip test_memcg_sock under cgroup.memory=nosocket
https://bitbucket.org/virtuozzocore/vzkernel.vzs/commits/f7931ffaaea2
[2/2] ms/selftests: cgroup: make test_memcg_sock check flushed sock stats
https://bitbucket.org/virtuozzocore/vzkernel.vzs/commits/8d450687314f
--
Konstantin Khorenko <khorenko@virtuozzo.com>
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
prev parent reply other threads:[~2026-10-19 20:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 19:47 Konstantin Khorenko
2026-10-19 19:47 ` [Devel] [PATCH hci-8.1 1/2] ms/selftests: cgroup: skip test_memcg_sock under cgroup.memory=nosocket Konstantin Khorenko
2026-10-19 19:50 ` no-reply
2026-10-19 19:47 ` [Devel] [PATCH hci-8.1 2/2] ms/selftests: cgroup: make test_memcg_sock check flushed sock stats Konstantin Khorenko
2026-10-19 19:50 ` no-reply
2026-10-19 19:59 ` Konstantin Khorenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179243999166.3624994.911602262116124183.b4-ty@b4 \
--to=khorenko@virtuozzo.com \
--cc=devel@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox