From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 16E9D8017D for ; Thu, 22 Oct 2026 17:25:03 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69MHNfVn014546; Thu, 22 Oct 2026 20:23:42 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69MHNfVn014546 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="GV5TWRQ6" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69MHNfBl014542 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 22 Oct 2026 20:23:41 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69MHNfBl014542 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4a2000d5ebeso466225e9.2 for ; Thu, 22 Oct 2026 10:23:41 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvByeZpBwPEPGCHid45hwV4/y1M9J+eHXqhO7H6GArQ6pTG8ddDEK2azUgPOJze0ZF0qJv83Ncw==@openvz.org X-Gm-Message-State: AFq9FYKvm90Qft1vQPjI03pmRv7yNFkzQll607UAXcz/uCJ+/wKUTOH8 JaEgQbUiKuOvAywunJwKvi/ig97wHwWYNeAd3uFFlq4GxrpLIRp29q+6UN0y1F5kFRLC3Ogi91j Q2ipLIznyHZR8cCGstk3O4yAA3e+ofZixJKk4qDl5uPINaqGm1ORrnA== X-Gm-Gg: AYBFou2ffN9WxtU3VWZEaCOhV2NwjtzLQQbs2kjBpYlpMelKgwz+h4U7Kek2Mj3eKtz 66CAjGnqKea/ix3B/7HdyiD5K2Eoz7oaAsme+UD1MhFJyQb2eWQG11BsuIi2DOfaUspqXSfyFCF 4dxzVMp56gBC/lZddjXCa/FBPlAtf/fsnyKn88dyRxSF7qxKrDSvkt/av0LtFaT3VMYiAjfEywQ OBq7Q5QrIOMqTDJGpWqEud2KGSaIEUalEyQSSS+RJ4+wpjepdmwcdR+5q11/0/4Dq5hyF9AAxs2 ETmPOqiyBNG0FikPaaWPilJ66YumkVr/8P5umzoGPIqEDwl6cLEWaSSkmoiTbh9ABGpwT6OjTGa A4WDyYt3C7y0SEJuZ1Q== X-Received: by 2002:a05:600c:3e15:b0:4a1:e11f:b2d5 with SMTP id 5b1f17b1804b1-4a1fd8a85bfmr108385435e9.2.1792689820726; Thu, 22 Oct 2026 10:23:40 -0700 (PDT) X-Received: by 2002:a05:600c:3e15:b0:4a1:e11f:b2d5 with SMTP id 5b1f17b1804b1-4a1fd8a85bfmr108384875e9.2.1792689819418; Thu, 22 Oct 2026 10:23:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1792689819; cv=none; d=google.com; s=arc-20260327; b=BqFB2JzJ67A5prLmcZE8OZ8tnA3ds+D5HDcVOapxodjpLoO6xRIxCCRfyJBtveUrru Lrqiv6tQ/E20BKTgLJAV8rjJOhmBhMafX4GHd9M/NKzfo3+EKW4vEX2KPd/JVSPpYg2t ay00KkPlzwHZhIh7Xif3pbnkaCjxN9EHzL0WJkJgDKm9bOgHThq1qlsYcUfc0qk4dQ/8 ULKDOEg4b8mZnHu2CDejcixOxJ5NpvxMM9dTjGgIcIQPQABVnPOuXju3CY7L6XIV26da zzvO79hF/MqBdrX4pAfla7xqiL8K9udtj2tKtL+1KopKdoAKLf1ydCyXGx9MiVrEuKl1 4mtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=yUAQHPU0RWhzvwmlrAL1L5usbHGCf2VNKQOhqCE0G4c=; fh=CTF2GHyV+XdzB5TROrdG4fdLri6JSHNOBC+LNuNq5bA=; b=emxYVnGFtcDYM+ykaHztBx4WdcnYSyUPA9RpPddLy9SpvLzWN9z7swWYdjukLt3Pci W8NEHQYstbgSiMFypo6RCQMjSOcxlMdqjGMaCi+octnxEXu4kzS9aVCk1oUyp7WxZmTs RC6uNa7fc44PRcOT4lwkBShTWINEspJtMvPCnQ4vdZZGA12cof+k+2acLuBbT6j674rF EUwLmSiefLkSyraT/58CcgwS+zLt8+uKuvHpa0GtaV48m8qvshQdCJ/MFH3rPzGVD3yJ +Y6NlT0HDe5q/uCx0IJR2W4VPKckhfMsuRF+4/ADSsJ0AxHz8LrbJyuaJasguBPQoM70 Aj4w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=GV5TWRQ6; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e258793b3si12895160f8f.331.2026.10.22.10.23.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2026 10:23:39 -0700 (PDT) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=GV5TWRQ6; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=yUAQHPU0RWhzvwmlrAL1L5usbHGCf2VNKQOhqCE0G4c=; b=GV5TWRQ64ONL PUCYwcs62XdWxQdLV6LB+YXor58ZTR9ypDZSXwHLnhIzh84401fsRSq6trtV+PdIN+GHWMbEIaXQS 1tZLNGUzc42m1JxIx5VzIs0Enq40wXK7AVi1adgEK108Bq0h1tFTjOxKU26VM9nec4C5voWtO8xaU lYdMDbGF2vdX60cTmvqEmb7Im4MaOZdWPrL3cd71Shs2FR5y7wCDja7/XF/h3dnIosH6LQKKg9kfj 9sarPSwVg6d3BYSz+VtvRYEXSTFZxjxs31SH+6q3I2WeApmz+/y58WEOsgtKgSgj7ggRXNiyZnBuL E6G42EaKAzn25g3rdeaIlQ==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xJwSH-001vC8-1o; Thu, 22 Oct 2026 19:23:36 +0200 MIME-Version: 1.0 From: Konstantin Khorenko To: Eva Kurchatova In-Reply-To: <20261007145044.2647274-2-eva.kurchatova@virtuozzo.com> References: <20261007145044.2647274-1-eva.kurchatova@virtuozzo.com> <20261007145044.2647274-2-eva.kurchatova@virtuozzo.com> Date: Thu, 22 Oct 2026 19:23:36 +0200 Message-Id: <179268981633.4087303.18375278409515971169.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2149; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=dUSXhUXxVTZ6YcZd+WxQVBT5Q6BcuyvcRd7KvQa6cU0=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq2kaaA50M6RhBzj3I5zGzuCHA2GwQbrAacT2JV rukbPlimrqJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCatpGmgAKCRBRlgpH+WFc KuLaD/9bnDaVf0NjqNYa0udeMuGg3QfQYzAGGx3prQzHZ4XHag5iA7NDHquQRFcB8/ciSgnLvtt V0ydJS3k2LhsgOr+vuP+d76Xz15Ci2ScJKofHNUqpSNBXyANl/6zrOXJWh97DGDlZaIk4wD5Per qgVg/NTfqd35CEVK0H4dm7Z/i2yqtpzZkZpBFpPErFTrnOZ/x7WMeQHSJu6jq3W23C0ZqdRNvPM mlcQXsWRb8Zg94HlTKHgnB7EWIb0P0H/sxYRGlreoVwkDDHmOMClarIe2bVJHFA70sbj/TLKhpK guDXYelpcPQ8DtDlYdebv4n7Y+1RzyK7wByPa9vubJQJKm0eOvC2R1U4Xn72GuoIb5aYCmUHkMt AQjEH/0s3Q5+GEfj+AM2e61G/PgHnPmDdr7IWFKAkvh1Pi7PEBAqu5I5+foQGB5kYe5pFd5yawG CQZ+L/51pHqmimm3ezsL9sH/0d7IrRIRRr4YbB9GPBd3N4xxIQ2hb6gojbBOtXPg350AuHb5bXe +BW1DPv8m8DdIsDGuOOoHAp86h1XOsx5QuxOH8zQUMN01vRDGED8hxYsfCgqYJjNLDi3VUze9Sq wRMb/Pr/3kMVBNzSNqiXn8ymg5ekaTjac76LcZbJW8q38mMeVAZBOfQS6xzELk+lUqbhEzHly54 e8B5Q8Zeutw/juQ== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v4 1/1] selftests: drv-net-hw: skip the tests that need a real interface X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org > +# lib.sh reads NETIF_FIND_DRIVER before forwarding.config: the environment only > +find_driver=${NETIF_FIND_DRIVER-} True for lib.sh alone, not with this helper ahead of it: the helper sources forwarding.config into the same shell, so lib.sh then sees a NETIF_FIND_DRIVER set there and picks the ports by driver. The helper ignores it, takes veth0 and skips a test lib.sh would run on hardware. The reverse is off too. lib.sh sources forwarding.config after netif_find_driver(), and NETIFS=(...) there replaces what the driver found. The early return below trusts the driver and hands lib.sh a config full of veths. lib.sh's order is command line, config NETIFS, driver, veth defaults. Follow it: diff --git a/tools/testing/selftests/drivers/net/hw/skip_on_veth.sh b/tools/testing/selftests/drivers/net/hw/skip_on_veth.sh --- a/tools/testing/selftests/drivers/net/hw/skip_on_veth.sh +++ b/tools/testing/selftests/drivers/net/hw/skip_on_veth.sh @@ -5,9 +5,6 @@ forwarding_dir="$lib_dir"/../../../net/forwarding -# lib.sh reads NETIF_FIND_DRIVER before forwarding.config: the environment only -find_driver=${NETIF_FIND_DRIVER-} - # forwarding.config assigns by name into the array lib.sh declares declare -A NETIFS @@ -23,14 +20,13 @@ fi # found the way lib.sh finds it: keep in step with lib.sh. skip_on_veth() { - # lib.sh takes the interfaces from the command line ahead of anything - local p1=${1:-} + # lib.sh takes the command line, then forwarding.config, then the driver + local p1=${1:-${NETIFS[p1]-}} local kind - # Otherwise with NETIF_FIND_DRIVER it takes those of that driver, and - # skips by itself when it finds none - [[ -z $p1 && -n $find_driver ]] && return - p1=${p1:-${NETIFS[p1]-veth0}} + # lib.sh skips by itself when the driver has no interfaces + [[ -z $p1 && -n $NETIF_FIND_DRIVER ]] && return + p1=${p1:-veth0} if ip link show dev "$p1" &> /dev/null; then kind=$(ip -j -d link show dev "$p1" | jq -r '.[].linkinfo.info_kind') elif [[ $NETIF_CREATE == yes && $NETIF_TYPE == veth ]]; then -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel