From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 5B30280E7E for ; Tue, 3 Nov 2026 16:32:24 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3GV4h4008922; Tue, 3 Nov 2026 19:31:05 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3GV4h4008922 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="HL29d9wP" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3GV2qI008907 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 19:31:02 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3GV2qI008907 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-48df730c035so3070508f8f.0 for ; Tue, 03 Nov 2026 08:31:02 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBzFgfpM3QTXo5NFsoWAY5cDdT/Qamh1T88SjLC8FBi/Md1o4fSkHQQk/qMf0etsBr5N4xTvEw==@openvz.org X-Gm-Message-State: APuU4Z+mSe89DQysbld/QF2WUTa3nLMm5oJapP/TewPdvtHl7I+I1dnw /PqhfSXPTlYkvEL8EkMTN62vULz3WzfBo4PQD/WzZtAhIXFiyBLMua6oDDAeIpkoD3fEKMjPT9B 9a/XOnUkTtk8A7FeRalFAwx/rx27wI+qL784AJJDCwoIzdt+8Dt9fxQ== X-Gm-Gg: AYBFou0vjkqQRlXvZvwiCiiOxiSNb5mk9jF2bsuQYZCvZpBUYUKf6VxAh9HRdPf0f8d oBl0qm18o77v23nnJ3r+luA/ZpTZYXsAoYGck48mv1LsIXywgLneOavIVngDSo9vMK0ZUrm9sZV e3Qz8rQSdF4XkLhpLCHa3dyz6ej/dE1U+Ek/qOrN2Z62xNeZFsESyaSYnP6NN+wspOdvr5OCBzA gtsmMgBRJ9rk7FbM+699HQffsWuJqfhxP0syUDFEzU5ZZSgaUSz5Oujpgb+EyUr6okDTo2YAJCP X3rj32DOadZinl13akrwefxIt9EzZ2Bc9OFSoosY8e5AERNaaosWM9WaUrQG8humPvWXBJDm8GP HgpNXbE5tZY5JJBkq X-Received: by 2002:a05:6000:238a:b0:48e:44d:5a9d with SMTP id ffacd0b85a97d-48e6e4fc4efmr32184568f8f.45.1793723462236; Tue, 03 Nov 2026 08:31:02 -0800 (PST) X-Received: by 2002:a05:6000:238a:b0:48e:44d:5a9d with SMTP id ffacd0b85a97d-48e6e4fc4efmr32184485f8f.45.1793723461681; Tue, 03 Nov 2026 08:31:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793723461; cv=none; d=google.com; s=arc-20260327; b=XhYO5BAeWuig0eFHsSdG/OxObJKw9DbGYqkUHJkoeQE2RkfyXHJC31Jh1D9vAMJ1Cp gyCdwN57KKu/Nrztwbn3d4Ra9bnuYTrIUklpC+4xfn44ibyd3i8MdpSKpUhv3k4B7pQc XYyIVQZWyLDDYA7kJUwp2ROgbyELc2sKtDNm3VgzNTKeXE+7bY6xEf4VFBj6/vCBR2u4 OLPFR9+HtFMw67Viw6H6nFq6PBB2NzKLQPDwPeIA/tGJgq1swP3NriCHHiz4H+Unrv19 2qHCrimBCeH2WLiW0A9VbIcYSm5QvPUuImO7XV9VkMk5c7M/W5gtcOz63rJyCtutAuHb rMwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=vW/jCeXVfMe5WL8L8hpkn7Xt1ck4QF3sgiBS0niFx5c=; fh=AXaEMap9UVXDT/x707nN5u9hAuW2OOlHA2h2MmC//Kg=; b=XD0PYfeDPtBpvmjrFJZCTfcNo8ciwscmCOffMMFpwFGMvANU/XIir5iPRSrGz28VhH n9eiwyF57KxsayD295lo0hej0DOfvEbnFywu0BKzH6M5nWSnTY8hQHFMA93a3Ed6jRwM /sd6x5h8qskKlBDlV1Bjqm0AlqxNju7gOarVhdM5mKtzpyeFutokC06QY6yyPkdLE98e MfKGeM4+l0F9HCUpf/gUxzAIavHllc5G5YdtIrPcs1zDzOp5tXi8cC9YnZ0zmPl10zX/ g3el4vSO4ncp8Wp2Yr9QDp2ktP+GgDxJBFKYPzePvkUk6AenCzV5v2hZGQ2bZaYw0BSi +54g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=HL29d9wP; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71bbad8esi25283879f8f.252.2026.11.03.08.31.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 08:31:01 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=HL29d9wP; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=vW/jCeXVfMe5WL8L8hpkn7Xt1ck4QF3sgiBS0niFx5c=; b=HL29d9wPW+y6 EGpnYdqQHLADUtNIswigkx4Rp7aEEUMc4umR0S49eieW1lSz5p8KcoDEQaXCscTsS3GPZMh8LEwWM Ns5TTCz7/+6+9cxA9t+NCBLql43k02UrZ35CPpG2UP9VfxWtvqmfgZXJgLCC7Z6mH2hjNlyt96KP5 k0SnD9hgo/E4O2h1AUO+nfCk9xmABfrgJcew+973rcmf1uclXS1mBAb8Gfd5U+IQXpDPV9j7Eilvl BIXiGBRO4YUa9UG2ppKZRpKr8biMR4Xpdy6y2GmWz4mZBeYEEdD8O+A2SXUI87mEwXzFCx/vAnCtu 0hM+JKmyTNpxIDJBR6wMAQ==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOHLd-0031DH-2I; Tue, 03 Nov 2026 17:30:51 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Alexander Ivanov In-Reply-To: <20261029144358.3384569-1-alexander.ivanov@virtuozzo.com> References: <20261029144358.3384569-1-alexander.ivanov@virtuozzo.com> Date: Tue, 03 Nov 2026 17:30:57 +0100 Message-Id: <179372345774.2497269.7291842798289238080.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1287; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=sZ8DmSUMhH/DZ0C2aRkPuNPUoqVzy8f+37bU5i1emn4=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq6gxDTJxDt3/0xnMZENM6I6JFKvJp/efrBJWj1 3AicQBykhqJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCauoMQwAKCRBRlgpH+WFc KivkD/9JOm/ewnTuqtENqcagBsCFY4aUJZDjBt+g7zeG/PJWQPK1/7NYyb0TaQOu2Uh7HoMFRWL diKmhbMw+mLtzl7UNyM0SO+fXxrhYsqh9oN1ZAShMaPbqRvDETB0fTKPxWhx6eK/G0+t4f7azx/ EZXid+W5rNwMRxmpLr9IHqxW35Oz3iETKAS5F9VxCsdARecM7gGn00nGRKDDjMzuHTtedc06gp/ nifsvb2QDp/t3+7VVxOrI4IFYfjBbV/M9C80h4DpSHl1tP72LNNfCFMAyc9RQ2Df019sA0CnlbA ZAGez5yhuhrEKn38isRVCiDA3qfOFAbPPloWC2ajkXiETqm/M9XwoTsCOaHvtI9fCv/Df0vmEw4 to6PSJkbYx53mIyMuvxNW409Wny+T4WllylmCFB/9oBtgt1xwkh8jFWxamhCB7CU/yButKF461E j4i5HJfox2MlxMlSADGSds9A4LtyQT9BTrUc+g/rexjhujL7dpnFL9zq9E+CSB//Mcjb1/DdK+l 0ayZkdhdD00tINryVxJttGoBNp/kDzB8GDnEH4UKV25yOiYz+UII+uHaR+ppDse7Gli8wYXkMqz uOaOhu/JTU363b1eOi8Z6rc5zh4vK5Pxrk8XY7YDAvgx/OAh2YAOoCr3E93HeIjpeieJPScjD7A vCK78NuwKfoMkQA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 0/3] dm-qcow2: keep images of a read-only table unmodified X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Applying the series with these fixes on my side: - Reviewed-by: Andrey Zhadchenko on all three patches, from the v1 thread. - patch 3: "requires to treat" -> "requires treating". On 10/29/26 15:43, Alexander Ivanov wrote: > A read-only dm-qcow2 table does not protect its images. Writes to the > device pass through bio_check_ro() with a warning and allocate clusters > in the top image, the unaligned tail of an O_RDWR top image is padded > on .ctr and .preresume, and merge_backward modifies the lower image. - Please create one more task, like VSTOR-152393..152395, and fix it separately: a data read of a read-only image with an unaligned tail never completes. md_page_read_complete() zero-fills a short read near EOF, so metadata pages are fine. data_rw_complete() is not: it advances past the short read and resubmits, the next read starts at EOF and returns 0, WARN_ON_ONCE() fires and the qio is resubmitted without progress. This is old for O_RDONLY images and now also covers an O_RDWR image on a read-only table, which patch 1 stops padding. qemu never leaves such a tail, so it takes an externally truncated image. The fix is a zero fill in data_rw_complete() like the metadata one. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel