From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id E14418120F for ; Tue, 3 Nov 2026 17:52:12 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3HouBK009734; Tue, 3 Nov 2026 20:50:57 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3HouBK009734 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="qQMVA470" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3HotMg009708 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 20:50:56 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3HotMg009708 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-48c430f0f01so4029338f8f.1 for ; Tue, 03 Nov 2026 09:50:55 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBzNAU8msp0/28CQdZospyWw7KD4nVrrdJo/K9y1WcusN8Dwob22zDIQKHarVZi/FSCC8XzA8A==@openvz.org X-Gm-Message-State: APuU4Z8dOuKJ/mNHOO6kQQRmGNCmmBCh+br4lBj7aVUMpk1j9Aldj1Pe 81qymwYW/q57nLpc5N7DBsL048EM0t9tE2opqWU67oHyRb/8vNSYjqp1ftU6MPQ1boq7F9fV8NX DxM/3RHl6TkYbwecdC6OrwdFQkoYGAGm2mTEi3lwKXPEqf9WdZwI55A== X-Gm-Gg: AYBFou1GOG/uHW5I2spcykbYo5pwkWt8YofJqsH6riI7HZP0Ziy0valjiJGqn7evhYK FWjdI7Iij34CxQjyqSXge1kt11WptcVHgkVexTw5NTa7YNEDCdj8YrGFkY8MA4/+zNBOoq6/rFQ qCXzqjlgmpVFyvPOLTYjojiHQ/mHm6SI4kFEcJ/Fr9K7zLZhR9jmcfbPPYhL/vZVZDdJQGT7pyi o0a5PPSQ92BMlKJ88WQU5T10/LcK+d07Px/3Mz+Z64AnWiQa8iU6kAqqgCM1gsd6rZo5WlGvOfx goMMv9hx1utmyjpBJUOEZx3mOQO8bx+K8Kgzjv4qm0hm2/AH6k4xlSPrcoQWB7wk1BzclWwJI6+ bAcgb9mtS9ktJeDTqHA== X-Received: by 2002:a5d:6107:0:b0:48d:fbe1:bb17 with SMTP id ffacd0b85a97d-48e6e5058d0mr22764729f8f.41.1793728255609; Tue, 03 Nov 2026 09:50:55 -0800 (PST) X-Received: by 2002:a5d:6107:0:b0:48d:fbe1:bb17 with SMTP id ffacd0b85a97d-48e6e5058d0mr22764683f8f.41.1793728255011; Tue, 03 Nov 2026 09:50:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793728255; cv=none; d=google.com; s=arc-20260327; b=Q8JcFm/eFVh0w6/F7U4kcUdwy1tiNMxo6QcSYqXsbYHsPyCx8upCg2YDmdUhiYLB1Y aSxob6IkfHGP1GhX01c2ehv/nihmpiWxkf2yUBD8XjDIWastOhXhroJ5ry0XrjDV7tPg yiMk7Dyy1czVtAF19fKsv5Oxr4kTt17MXf3ySs7ARvKB0Knh1y0jdMBM5pMD9MAaKy3O Z0UqjEcYtzykFanAMbgEj10dazwqD7fLeYR3LIlxrYDHGnVVA3i43TOd5xtAmQmM4zpp 0+LlU2aWUD7grq4wuRCe5UrOLv7cUnOclJiEiT8CctI4wR1rYfi9RPe7dGsDhNyaYBd0 hG5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=0BTbRsJUmn0AVvLjDOJ1kX+WjBWZ2sc2ugeyCyWt5h8=; fh=AXaEMap9UVXDT/x707nN5u9hAuW2OOlHA2h2MmC//Kg=; b=GUtWvpjEFcaj7EsTQ07oQjYROpBT2WK7tUSZrS5Q3WgaZCXJOyzngyk2Hpf911/ra5 TYM/2nebFScF1zSPzeFt+9h1B+S3YYCXDvWi4nKHa166TctafsCd00UguVtOM5S3y8Fr Qj1Kn304m5Tdu2IwfO3IacO27aoCPgi8hSCf9ryQosq4lhy6X/CovX25VprQboezNBPN sMGZHLsOMh+sEUTB8ZERraJVgmVs5D5PtyOofXqczwABKBB/tY3IZXWwXW7qPT92NMPK AROflGxs3mWlC7BjMTM6WnZMo8X1hLY9p2/vLg2yVM+/FXdGZ47PH/iG5esj5/kHDH3B JL8Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=qQMVA470; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71bc627fsi24940355f8f.339.2026.11.03.09.50.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 09:50:54 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=qQMVA470; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=0BTbRsJUmn0AVvLjDOJ1kX+WjBWZ2sc2ugeyCyWt5h8=; b=qQMVA470moRT kwvYFU+NMVLQmepjkS9GKvjeaMlPM62rMEwzYO00jnxvugD0iHh/cCjt07/ZXYuQkgBgdJAoKh539 B+4ApUExREjbWWbfUaEexZwMJtIqHdeB2TP/4Fs2wogoOfxWuL4z1krusV1ayRI11uGi3kBp7l6m0 YSoOfQQ50iPXV+wfXOJr1F/nAB61mR2bFg+GaI0PzucvQVdKVmr8TR9c6j+6goIwDpY3lXC5ODrCk DXYG276MyygG99OAFgm05NUG04+SHvxg27IWu9J8BhRGr/yCv14kEGmrA23Sut7YsTXSDJTee99ps C3q7HHQZ4NHL1/l/IND9hA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOIax-004r4V-0S; Tue, 03 Nov 2026 18:50:44 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Alexander Ivanov In-Reply-To: <20261028150645.3222391-2-alexander.ivanov@virtuozzo.com> References: <20261028150645.3222391-1-alexander.ivanov@virtuozzo.com> <20261028150645.3222391-2-alexander.ivanov@virtuozzo.com> Date: Tue, 03 Nov 2026 18:50:49 +0100 Message-Id: <179372824968.2555502.3026463026297957571.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=977; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=KVRE8GQLhcrprh/L13MmGuJWTSKcnhmPPr4IbeGfQ0E=; b=kA0DAAoBUZYKR/lhXCoByyZiAGrqHvujVj1JS/MHKd59UMNcnCBx4CQq/jo8UAUdLKGbzgL7B YkCMwQAAQoAHRYhBFYPbcg9xdPQY70ILFGWCkf5YVwqBQJq6h77AAoJEFGWCkf5YVwq28gP/2CR VMGcau7S4sZ1MDUXZiSq2b1crtLhQsERGZjE/pHqPRJbZkVipPUcKFe1GVZjzes60sRAd/j9PFa XMuW+5RK8pIqv1oL05hz0APb+iwTgrI4rKbg9rQfWCz12q7TKavm8SWRJr+hHqTNDW4w9e1DjEq +hnqAMgThXW7tSqmAl7F6+/+/aPjL7Ksl4piSVWzWqafP02BO9lVrjOUCxzDquDbjYoxkEegBSL bHaEdA9GaHDgyr/+TdWUKfHcNgldmUorpZPebncKj9wJcu4heUYYy0chYuIevvIUAWyESfjW7Of M+7m7lL7r2M1OSxLYJzoQbAyeDGmtRshc/sHpmJUkDS0+ZKKh4qm3qGV9Z2YzS7DZwJhEbVd9Pc 1A9GyPqmU0GpTk0rKm2Sw/1OkpZH4cXN2+8PjZ6N/DQl7G9R0NH5hFxzTzVlgdQJCK5VpnVMsGt PwNst8EopM7xjlmqmIO/COC9RiVMr4tO6Fq/SI55zYhkS8iqQSv7QFo9n7FHTAMr0JHLqmkHNWC qTjfNLPS0cqUEpbVLm8NapaOHPrzhAym7FPLt+hLB3Th97Jyqp5O2FDOrExNWXCuzjlferhwmDd bLkGgcHfyNzObwDZYQEV9Bm10AIBH7wCuPnrlfMtqcPwWk+2FmYPw0x0e/m2b6pkB6/aYUa96CM WD2Hc X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v9 01/10] dm-qcow2: add qcow2_md_page_read_sync() helper X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v10 with the changes below. On 10/28/26 16:06, Alexander Ivanov wrote: > + * The caller must ensure no read of this page is in flight > + * (e.g., the device is suspended): if the page is cached but > + * not MD_UPTODATE yet, qcow2_md_page_find_or_postpone() returns > + * NULL and the following insert fails. - Require "no concurrent lookup of this page" in the comment. - Set *md = NULL on both error paths. These are my v5 remarks, v9 has neither. A qio that looks the page up before MD_UPTODATE is set waits on md->wait_list. This helper never wakes it, and on a read error it frees the page with the qio still queued. So a read in flight is not the only thing the caller must exclude. On a read error, and on -EEXIST from qcow2_alloc_and_insert_md_page(), *md points to freed memory. No caller uses it today, but the next one will not expect that. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel