From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 7AE138125F for ; Tue, 3 Nov 2026 17:52:29 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3HpHWa009792; Tue, 3 Nov 2026 20:51:18 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3HpHWa009792 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="Ld2hWgyR" Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3Hov06009738 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 20:50:57 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3Hov06009738 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4a77c1cbd15so45006935e9.0 for ; Tue, 03 Nov 2026 09:50:57 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBwRXVyjVbvQQchOCGfnOo8rHbrCs4CX98kMyoz34OJxNbeMB53LYP34Wz2aZWIqRAFZ2cw8Rg==@openvz.org X-Gm-Message-State: APuU4Z9PX7qF5RjTQCAo8MeWRt1oK13nMoHzvxIRy6E9DCzblk5aAgh2 ayuB5s+D5HLpiagyFUGqCTsiwG1PwN4xI8ktWEBJhRk8cXafZ00T4jpaIiQuVBLHY+5Dx/DtYy+ r74jUhKy+mNcv8PU+XNJcDah5pm7eQoXwhaw7PQQWqpsID30uJbcL6g== X-Gm-Gg: AYBFou0rUDg2fYhD3mbRKtkRWQr/ByHIX8hI7Tzsg7vFUVKnukU9LJRYnjcp3OYQZVt bAKtkY9FrhtMn9hYcKGCUzPQFsXBfuyDEyaGxNZl8SVepf4sAlbZ3h5ngyNZCQ+p0uHN4/RYyLR h7xUXVmYiFlFUxqOuP6dPsTtgHqacTqTlYTZDwi3ai0ShpsPmjUcJ3aqKsbY1KY0lJEWy0N64M7 Aql5/5A585MdPvhWFiIxXKpCmaVaAjEhsIdp6cHFuyqTwlY6ZcM2b4Sb73j+LP/8KJ2RSm1UITq ErWXYzXXen4BtWLrSQLc83+FXZ8NMtJhTgwBV1ine8VEVC0n5vS8pe+QotikAh/Pprw2iWvbOhP u274UusMi3hbN7ytGvQ== X-Received: by 2002:a05:600c:8b5c:b0:4a1:fe55:88ef with SMTP id 5b1f17b1804b1-4ac1889c4b9mr334482755e9.20.1793728256390; Tue, 03 Nov 2026 09:50:56 -0800 (PST) X-Received: by 2002:a05:600c:8b5c:b0:4a1:fe55:88ef with SMTP id 5b1f17b1804b1-4ac1889c4b9mr334481245e9.20.1793728255012; Tue, 03 Nov 2026 09:50:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793728255; cv=none; d=google.com; s=arc-20260327; b=ZkYCIMFAmMll6rBAL9p6Oz8A9QIzxEY2hxNLQfgHy+jPpko6ZLJCeZcxf2d10RAgYK /Cs4tT1ta6olNHLqPyaUx6opjjMif9fAVygYmToQ+qbGWgHz4uvARYDK1ItE4WpOIHj9 idYG38yoGF2Q2fJ10JlMFPMakDs/y5zxLiW1d+TeGdQUrFdayhQ9Cz1FJlZhL5QNsRH4 2c5eCdP6X0n4u5tWzIZsFK4Ss6arO9Udlb13wzid1NaRh43Q+2RiFTGaQLeZQgzvZxdR xk8pjjwCyr77j1ttjDs40PQAK239yPr0yGMXb2V42W7Xg2s4c1yR+7o1rNpLlyy9NePp hM/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=JGuLN0oHqK8nYiJReRRb/HMRQBIjFzFs7AiTYFWDZVs=; fh=AXaEMap9UVXDT/x707nN5u9hAuW2OOlHA2h2MmC//Kg=; b=AR+ezbVY+BGMufuRsF9bC5r23GHT4gblXqxESbvD+1o9gKrpVngPC12zohKJLwxrf0 RMlfmIdctUi6ebKjzEYEEW0rRwB1+NTX/IEfsmVxZJ0L1UQsbya37NMCh29C03W2e87K /DIH9UizHLqBqmoQmDtg/jv9Fyaq7KULTAm/QLJghXSQe49uVmSrmIWTXsWf9vyXfE6o Jz5IurF4CXRYISH+CvrZG/Mht3dmMJKxk6hj4mX8DdVqdAnnTKtaWvIQKuvHEFf2gmXV 7VHgPOJwOwiD9auzNy4PFhggviZ/Yqxd2+YBzB/o9jY7eC1UCYCDoaE4SMWfBTCToN6o WBwQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=Ld2hWgyR; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71bc0135si35326554f8f.305.2026.11.03.09.50.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 09:50:54 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=Ld2hWgyR; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=JGuLN0oHqK8nYiJReRRb/HMRQBIjFzFs7AiTYFWDZVs=; b=Ld2hWgyRfgXc homr5/rbL8hYNpSKc1K91OLL/xM29gdi63lLo5oGt05EJTJCRRk0hSyPDvMOnBYr/rdm+QrRHC3oo x7F8essVJsS7Ljx/ufQrvYL/Ht34QfQz96gF2am7jMzSAOaOiO7aY1u9u7wOlsoeCZ/KsiUtV0YyE 91WzKaPjcb80KGYPpYYX13za6vxN+PCogZfo03jD4J45dHjRWIJc2Gqy7lVReKPCIr6oUsQj+6gDb fy6CyqTi8bNKtwjyymLbZFpqDdjXiEu80nVdycESsDSncUk0so2goJNSEw3QzUySzV72clmVENe9N mFSHrqniXYUw2sH8nBfqNQ==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOIaw-004r4V-37; Tue, 03 Nov 2026 18:50:44 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Alexander Ivanov In-Reply-To: <20261028150645.3222391-1-alexander.ivanov@virtuozzo.com> References: <20261028150645.3222391-1-alexander.ivanov@virtuozzo.com> Date: Tue, 03 Nov 2026 18:50:49 +0100 Message-Id: <179372824968.2555502.4234502894195553479.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1505; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=ARcF7ydtQCfxCDtYBbisqv2fAsCoyv9gU0jrSKWe6Xg=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq6h77bHVE6TI2KVNy2uWaoswiTjWfOyp0BjgNg lMoo3qWBgKJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCauoe+wAKCRBRlgpH+WFc KnuqD/9sffQrzN78cNprtYSyYqorf5tISERszSoRed3rkvhz4mF98XZd0hUT6U0sD3vb2XF4Qre gIiOsh26wW3nz7gw6By0dLnSgtx8HE360N8Fm8RFFwvcNU/AGdEUJoMaz38z64hcX6stThzkI97 tvsMRLl4yzcsf5W6Og3g+yLqpO3i+k2bOSgafUoaWg1LaH7MhcHlP8bKkgaIO7/jYNqQJAJu5B9 NTGVcOnYTq3zAJ2snLy/MWjcOzOtJT9M2Q3qXQeaYChIhcCZuztqW8KUgXlACB4bp1yWsGbrWT0 feuFqsRIeDpX0L3jwt05Qdh+7+tFWoLHcxRtkfOiiyhIhIG6poHjGyuU+JtAwJGWIeHG3En1YZM YJ5MLxsooGBirDza9JgY9kT9Kpqx13q6mw0B2eWJGvFZd4ZeaHgGxaltk5Y7yaEaIskfd18Z5O9 X0wiyaOB8y0JV8xhbVGobMBs0EbPKag5JZNIonaLWgW+kCSN92c5m4fu9vKC3fE7AdBp8uoSJcq EkevJmPte4a2ogymW89j4t8O4oL3BOibsXeVi5eIpV6dUgDPYRaUiGGqjhJCQARKi9Q5G0MVg5K F7W4vz27lCvkgOhCS+s4jVC8zRJ3+8Xle6SOCvxvFWOA5PAJ0bCWtmiX9WHJkCyyv8df2qLWyRi pvYh06HBjNj1voQ== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v9 00/10] dm-qcow2: truncate unused tail of image on suspend X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v10 with the changes below. On 10/28/26 16:06, Alexander Ivanov wrote: > Patch 1 adds qcow2_md_page_read_sync() helper, which is needed by the > scan. Patch 2 is a small cleanup of duplicate prefixes in QC_ERR/QC_INFO > messages. Patches 3-9 fix existing cases where the refcounts or the > dirty bit on disk don't reflect real cluster usage, or where such an > image is not flagged for check, which the scan relies on. Patch 10 does > the actual truncation. - Add a Fixes tag for 222b6f1291c1c ("dm-qcow2: Introduce driver to create block devices over QCOW2 files") to patches 3, 4, 5, 7, 8 and 9. - Put a blank line before Signed-off-by in patches 4, 5 and 6. - Describe patch 7 on its own here. - Say whether the ENOSPC retry of md writeback is planned. Patches 3-9 fix bugs that came with the driver itself. Other dm-qcow2 fixes in the tree carry the tag, these should too. Patch 7 is not about refcounts or the dirty bit. It fixes a relocation that keeps failing after one error, and pages freed while they are still on the writeback list. My v5 cover reply asked for three fixes. Patch 3 does place_r2(), and patch 9 handles the failed L1/L2 write (see my reply there). The ENOSPC retry of md writeback is not done: a refblock write that fails on ENOSPC still blocks resume until a reload, and the "FIXME: call md_make_dirty() and try once again?" is still there. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel