From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 5C891811BB for ; Tue, 3 Nov 2026 17:52:24 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3HpC3C009778; Tue, 3 Nov 2026 20:51:13 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3HpC3C009778 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="on3y3TWT" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3Hou1t009726 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 20:50:56 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3Hou1t009726 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-48e0ef019a4so3791525f8f.3 for ; Tue, 03 Nov 2026 09:50:56 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBzol9CV3rg2CG6WH0EuiqlMA/khQWrj9kYLAZnJZy47TCG8Vuv9CQ8E8jqvtt5+uWWjsVd/+Q==@openvz.org X-Gm-Message-State: APuU4Z99XuVSt1FEIKHbi7cHi3CkePMUqSspYcLVzONenMphXkV5CvBX 683Agk5pn5Dj4DEQS+nwX/mm5NgzAZuWg+0Dm5rRPXwo8BSKGRLGzimi1s2IssoPrf+fcXSTcv7 5jbV2G86F+vfM00KoI5Jrkq3MjJtwWcvz+lUa6D4iuT5cqw9HVwG1JA== X-Gm-Gg: AYBFou2C2fCegr7E8kHVYf0LFlWuKv5xPmyBH+V1VWdoghK5L2sy5GsBu4eYj/qFfES 7b/lI/0i9FnLyhaE0a0A+gOMJK4redKplOw1ISIwxjJ/pFjgwCx09np6VM9YsAWej21RKthWSnA z20vLsT8TgkOmP3JPfq6lrPmezcdhd/cf3FQUWX9hxyMbU5Oa7mrG4C33j8Qo0LCGcwVg5g4sHs n6C/csKeKRTzu6iKtYdf7+deFsor5kKefqhBQQrMDbliquUgrg0yLnlDE945hf6VkEZPlTZ8qd6 L/zQ9ozep3ykZsdtHpa+BI1O3NrLvBevYZSH3efgMPHcvD+ljkCLiP68FI0VAiahZu2krJyj0kL pgCXD1nVVNdkOxbaIwQ== X-Received: by 2002:a5d:588e:0:b0:48e:6652:fdc9 with SMTP id ffacd0b85a97d-48e6e4f54f1mr29426980f8f.17.1793728256289; Tue, 03 Nov 2026 09:50:56 -0800 (PST) X-Received: by 2002:a5d:588e:0:b0:48e:6652:fdc9 with SMTP id ffacd0b85a97d-48e6e4f54f1mr29426930f8f.17.1793728255838; Tue, 03 Nov 2026 09:50:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793728255; cv=none; d=google.com; s=arc-20260327; b=oYrRDeNLMYjYSgZ64bnIEzwl9JcSYYEAWg4WS6Ftmo8gAsHS+92I3RZCJUZBLW+Iyx zGFF35H4h307Taez9i6g7pyZhgRj/zEsUHJKXu4Gv3GSn842PbynoUCPzxbCO5BZmNWC AKBFH7xOAEnR912bzw26D6DnbGPU+QDzW6jjHo9jybglZJ8z2AoNUw4DD/DZQsLADw2k HzBKVElnBNkT+yYVLnQ/BWG+ex3OTCv9ZiL8YuH6Gy96ByFwL5Jby4YY3humacV0/L2u kR6zOsLnsqaN26JKvaGpbGFle3CV4KVDtSlMdef7Gq7dzXApqFdppeSWIKHhjJQYoN9p SOSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=hlD5sZiyc30/KK1mFOK07dHRe1DEkwFQB7f/p6BmADM=; fh=AXaEMap9UVXDT/x707nN5u9hAuW2OOlHA2h2MmC//Kg=; b=VDGB80QvN6s0G5UScYgqANhpkkEv/jcswgNiF4haPwqkq4SSkuF+GifunQhMBl1Rqc 3sUX2wo4ZAZGIkQeJaCpzc/jRot/7Ywi9KvXbRn1lg8/hygEv3i8eOJolBkNraMZH3db J7DMMNaFJzlG98EMEc2LqFk1zf81Fd/+pxzLK6JpJIMZ0lvcUhjOBSKmAy+sx/4nWrA6 wiGQMHC+EiszhmNBpubuSydvEmtlSvkec9+9wOlQvylLJlYKuCpFxejpoAFiDPl9Gxes AxVgkXw09ZILWmnMeXeXdz8KGJiAfad8ptFhetlwJqq8EmfBW8qZkO50kY7wK5SXRakw Mg3g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=on3y3TWT; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71bd1a37si24528925f8f.420.2026.11.03.09.50.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 09:50:55 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=on3y3TWT; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=hlD5sZiyc30/KK1mFOK07dHRe1DEkwFQB7f/p6BmADM=; b=on3y3TWTszZV cw30xiv1F5/E6HD9dlvcnLl+UgDDFPklB+7pRVWYw1xg5Qc79x/b9CSqKOtKij2PTV4cCtG3sGJrL 5/qs4RCnySIoLOXPyPdJC/+2F4iD5nC30cBwkC9AFq8X8Eqa2rqScreH1V5nDsjrWID2MXWv4LGSy 4F3Ff5PvSPoIdYExZ8CIp21MnsGeJkiVQC2bSqaP7JxRsCYonqw0uUh+g0eRKzJzsBPktbCpF7WAf X+n7YePm0h/psM+hvEYbsRO6/+A3ymPSCbt5vm8g3xzPkL2D2ICk0s0ROlctpnV/XhGLxCuYYz8B+ LQ8Umc8jxm/o82BUZKFPSA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOIay-004r4V-04; Tue, 03 Nov 2026 18:50:45 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Alexander Ivanov In-Reply-To: <20261028150645.3222391-10-alexander.ivanov@virtuozzo.com> References: <20261028150645.3222391-1-alexander.ivanov@virtuozzo.com> <20261028150645.3222391-10-alexander.ivanov@virtuozzo.com> Date: Tue, 03 Nov 2026 18:50:49 +0100 Message-Id: <179372824969.2555502.9529900374425809477.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1379; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=h3m8hWdDmBd9NDmto4XtBk0FSOOffy6iP6GUXEyI1+Q=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq6h793U03z2VzTe9vKUmQ2EmoWpB+2VAeN/gb8 mrKqajNOcyJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCauoe/QAKCRBRlgpH+WFc KkvPD/sEWT29p/Z4K26OnRpy3ln+irmf+GvP3PzLErHKBBHo3ANlx7jXuQmRv7u8mAJutAMZkO4 AHjeuePb/886jKux9yoSmsHAnWPb4AG6t5olf5+PHlFhq358J/vfG4mLHFt3WciLoj8oYdot/G8 XpAfbh6JwY8JphGXrN0+r6y1ZTSayuZoEtsAWOv80a1DOtM27yPtPVJn/5BL6A6W9JUBq+YA6gO 5eoDNxQh7YPqHr+UIyTfH3DCN8v/GDOMZCvrYVspEaNNmZwIkHpvznU9O/DOd1AaUDiQqf2EOls yVzVsdBOyY5YJ883RUH2bAtZJbGk4ArOY0/O/qzfutrF1Oo6ksytv0FGr6fxfzzyLEf5SOi2Uv2 5ijIhpl+34DSCKrtyJe3RMCMpkBTndGjlt97qKSvVyGF2A4+Fud3s+zex719uaKPMIxCjLgLlT4 7KXMCEYjOFKDPUbNSTKU2RoAIV/tRFSihXwb9TE/OrxobgRhqcGBz/DtaNinXw1CjwFQ85L9+Hg DtveJrs7PDPkhSurjwfZEQikn9MNBuXt6HBaiwNAV22R5efCJ4zH6g40kXIySR2jkHPkDCUsYdP qvknGGkHjYZp5zXPjcsdn2GTXTJdzSeFiZA04bKjSjbO4YAD3Y5nvAxjd49pVAMEP9bV0oOgyPh ggWoNvtdPVXM1WA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v9 09/10] dm-qcow2: flag the image for check after a reverted L1/L2 writeback X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v10 with the changes below. On 10/28/26 16:06, Alexander Ivanov wrote: > if (cleared) > continue; /* no cluster was allocated */ > > + wbd->md->status |= MD_LX_REVERTED; - Leak the clusters on a failed L1/L2 writeback instead of freeing them. - If you keep freeing them, set MD_LX_REVERTED in the pe_page branch above as well. The pe_page branch restores the old entry and continues before this line. It is taken for a COW over a compressed, snapshot-shared or preallocated cluster. The new cluster is still freed: the qio waiting on the page ends with the error, and handle_cleanup_mask() frees it through FREE_ALLOCATED_CLU. So L2 on disk may point to a free cluster, lx_writeback_error stays clear, resume is allowed, and patch 10 can cut that cluster off. Freeing also lets the allocator give the cluster to another offset before suspend, while L2 on disk still maps the old offset to it. Two guest offsets then share one cluster, and the check that wants_check asks for cannot undo that. A leaked cluster has none of this: the check just frees it. Leaking also needs no resume refusal. ploop does not look at wants_check, so with this patch a transient L2 write error leaves a live check or a snapshot with the device suspended. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel