From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id BFA788017D for ; Tue, 3 Nov 2026 18:03:30 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3I2Kdh009848; Tue, 3 Nov 2026 21:02:21 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3I2Kdh009848 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="RO1iQe0D" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3I2Fxe009832 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 21:02:15 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3I2Fxe009832 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-48c430f0f01so4038261f8f.1 for ; Tue, 03 Nov 2026 10:02:15 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBzzAcFD6w2OcqliwvRr3zmn2JUSTSP70ivbokqsZD9up2YwS6yAvvNVw4yr2+yBsdNKBP7uaQ==@openvz.org X-Gm-Message-State: APuU4Z83jw9MI3y2NkNDZHq2goyUv5DKqqKLB4hfGfQTAaSwmkz0Um1E tgNsv3uGIQv2QBrgINn6n5uyUYXsGOlTfnVzXBxiONmz7y4qy4+R5kggTD1LMDIccsE9gG0r/8+ DeKCcJ1p4Sis+k6XoyY6O4oCKlvnp7AfaGw0u/LesClB96IlI9iES4g== X-Gm-Gg: AYBFou1kiWy9IrLOF6LdECDYf1zw8vMBYjk81mHLKRZ9phSOXSAXqz65q4zTTTnaoCm BlYUiyZZcQ/kAyIv1wFN0qO8Fe+YpUqJ1zL7uSU7KUth2JHv7XJ8c0zGFlaKsbOmwxIdJtfqypY gnbiESaNjZVhLAKlHNTVSuTdYvVYeasBPGoZV8/4j5AlowS3/MYuKx9sd+5Phn5xsXo3klR5Rg3 M4P2dpas3R52P4dVycsW38LMtNBczbUR++6VOU3Lu3sy2QrtABnJb3yBBGmG/LMs+IKUa2yqszW Lm/vcnJlqmryp4RIY7OeAoaxE2qx9VUdNpjzOVqRXxSJ4qpxjhJDxL8e5tmlcR82z01z1atb9In ctLTBKGrhPc29+V+Mow== X-Received: by 2002:a05:6000:40ca:b0:48f:bb92:c5a7 with SMTP id ffacd0b85a97d-48fbb92c9a6mr4167151f8f.9.1793728934829; Tue, 03 Nov 2026 10:02:14 -0800 (PST) X-Received: by 2002:a05:6000:40ca:b0:48f:bb92:c5a7 with SMTP id ffacd0b85a97d-48fbb92c9a6mr4167070f8f.9.1793728934273; Tue, 03 Nov 2026 10:02:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793728934; cv=none; d=google.com; s=arc-20260327; b=Y8RgKmQdXdgOOVlaRS/JKA4LuHdjPWGhdrwTEsX10GJUg9uXVba1XpWq6KD9vml16M gv+1aFbRKpTHi9YOW8ah9USsh2SCxxbybmanYieoVt0AzthZMURg8xfvpd2+/din5emJ y8XzL7Xlkkoh0UqAAcEvp5ILeJdr7gBkaRcgjQ2NhiNtKBmzg9lzIhQi/tMzvfEpx1F8 4tqfCYadDqF7OBtt7mEF8Vy2UJdX6JzMqlluFJ3sjXEuao3I+IIDnDTmN4qFi/ZCwF5n 8CzSvMfUPP+4g6gWyq6p2dxboe2Ogp8X3qJZL5xfsKA7Jy8nPwA2fZl5aoy+ycL+vRV0 us0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=gK8xnbc2iqqEizRu0AW3czUTLlPoB29PUibiXvYiTZs=; fh=D+fpfNE3eS/JDEf1ElWXHuM/4IOsf9Zyu3iteEH/Ms0=; b=K7opuvLV4lHbdXaUPvTmu6UmmP9iE4lCnBIKEJoy+CdYD5lgLyuDfreBDHK3xcwf52 NxfIOfuGVM+HqCNkAiIUG2z1di72SH0dmBF/GEZCLfktITRu2Qj2HdskoT6YJUMuSRaF n98ABabjIYs0lVSzq8IRkM3e0Y9ROVofMYPWXXZ/txmsnA903KvLpm8a82NHQ0+vbDAR T4Ht0V9KTIBQQq4x0GOOEP9hjogR93daozfhTVPJ+63HcqIEaPI+Z577bPWrjMum71il 4aWUdjQT3tbVCAttAPdIW/EsCwxIBx6/QzJlw1ux42Qk4FeS++t75sKjq2sn63fAVR9v J3vQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=RO1iQe0D; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71baf5f1si25137362f8f.151.2026.11.03.10.02.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 10:02:14 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=RO1iQe0D; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=gK8xnbc2iqqEizRu0AW3czUTLlPoB29PUibiXvYiTZs=; b=RO1iQe0Ddv42 Ri1toai73Cbmyax8fnwrNXVJyaiv6ahfu52uUf1gEKGT9Dd1oINCskf79PsV06Su0egvEPrz9RYlT j4OAYamUa/+3mF1O0/YjvtHFxcGWf2QJCBJSqqKYxLvvM3oXZiKGVMVSt5fOcUhkDV6rNVIAZBtYt 4REOYi5Bk+GDl3YzhHBsPmb8wFbggiGGwXkyrIy4whQC9kGdjaGDMteRFaBQZZqROE61ANi96k316 k0tI4JpQYS91V+v6g8hzhniTRXG6B7/3fQR9tNFVRW7wjmD+I8yOkhEN57i3JprGoP6ehkBB92/vn Xzm2qxiiTwqYeTTDcBqXCw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOIlu-0056b7-1H; Tue, 03 Nov 2026 19:02:03 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Pavel Tikhomirov In-Reply-To: <20261028-ptikhomirov-vstor-149268-cbt-account-at-rq-start-v7-8-5c48672191c2@virtuozzo.com> References: <20261028-ptikhomirov-vstor-149268-cbt-account-at-rq-start-v7-0-5c48672191c2@virtuozzo.com> <20261028-ptikhomirov-vstor-149268-cbt-account-at-rq-start-v7-8-5c48672191c2@virtuozzo.com> Date: Tue, 03 Nov 2026 19:02:10 +0100 Message-Id: <179372893089.2555502.3597486668202765258.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1303; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=JjlfaEeaifxt9zIl5MK0tfjh+7ee9qw11RGgMdBtdBY=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq6iGl4q9cgRfihi7DQO8JiZR0+/kIpZxUIAs5+ lFkaexY5lmJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCauohpQAKCRBRlgpH+WFc Kk7yD/0SpifoAoGPjpxzFHyA1DZ0U/NBcPYeYREKnVk9oFlmyB6G0LbkvJF54MT9UM+O7yDdcdo 1CG1cNkCY8dwRL0n4/66uUE8+jFwlZCPKM1kdAkirws3IrC/9cnS6iTSbK/ryL6WJjO4+BPHHh7 8xxBtXlWsY5kB2By4jaUpsgon7nEpXP9ZL7t7P3v75O5iJIF6TD+8VBkb6BijyQPVgi3IYUvUW7 mgaU2JipMrs8J6Qa36Js+ZL8JK/MrZPsFBZhiOsHKNYo1uw1oSdoeCcT9yNBaY2PF2E3iA1jmzP b6eHGjvARc061YJN2kHRnk0pL5MLGtzZRc8LHouqHx6gT2ObeWTQijyoLq7NVa+jvNRAS2KbEuf MJruPV5OT4T0vFYV8hLbCY5sSDxF7D6vI+5HKejgA9cITKOedCweFFgXiEJiZk4WR9uNPrxqWCv SB2mIA2mDMzPuNtG8uDJNvg6z0tz2dt1m4MizkiXU6VwBwFV13XXwkU8YiOO9pX1PnGFJ6NDTO1 fZJgPzh5BMSBWqj6TK3dTOS2GhClRn7sZsqPLEjU8q0cSgOXf5asNxRuUbd/VkJYVO1FC8JKQV2 zbkVRyCJb7+80ejaRZ6uKUUuaHZl2JjITntxen/8DnrGRnrZ/Jf2tTwwur/0x2d1dNcHHimCoG6 cFxgbTibIpNtRDw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v7 8/8] block/blk-cbt: account a write request also when dm starts it X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Not applying v7 yet: please pick one of the two options for REQ_NOWAIT below. On 10/28/26 11:11, Pavel Tikhomirov wrote: > @@ -275,6 +359,8 @@ static bool blk_cbt_add(struct cbt_info *cbt, blkcnt_t start, blkcnt_t len, > __blk_cbt_set(cbt, start, len, 1, NULL, NULL); > return false; > } > + /* Queue the allocation early, so blk_cbt_rq_start() finds the pages */ > + cbt_queue_alloc_pages(cbt, start, len); - A REQ_NOWAIT write that finds a bitmap page missing never queues its allocation. Either: 1. send v8 with cbt_queue_alloc_pages() moved above the nowait branch, or 2. I apply v7 with the Fixes: tags added on my side, and you send the nowait fix as a separate series. The nowait branch of blk_cbt_add() returns before this call, so the bio fails with BLK_STS_AGAIN and nothing allocates the page. A submitter that retries only with RWF_NOWAIT gets EAGAIN until some blocking write to the same range allocates it. io_uring is not affected, it retries from io-wq without REQ_NOWAIT, and ploop devices never get here: dm-ploop and dm-qcow2 lack DM_TARGET_NOWAIT, so submit_bio_noacct() rejects such bios before CBT. cbt_queue_alloc_pages() doesn't sleep, so option 1 is a one-line move. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel