From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id EA8448045D for ; Tue, 3 Nov 2026 18:03:29 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3I2GJa009840; Tue, 3 Nov 2026 21:02:17 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3I2GJa009840 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="va2lSE49" Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3I2Fca009833 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 21:02:15 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3I2Fca009833 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4a17741243eso33637855e9.0 for ; Tue, 03 Nov 2026 10:02:15 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBzklVMHCSaFilc1QJBOQqXn4oTy8WSn8C0JIwnCwFEtIKoZPv7HKvCbyLM96wxE5HZzWUQCNA==@openvz.org X-Gm-Message-State: APuU4Z9XlOT0jo/w/TUrtbskvPJR85uMufO8l72wi4B9cIYOXjvAxmdf GRtp6nIyXJoOqok7OHOl6k/5IQv5D2FiXY1NGIZfqPlADY5c+MGwuVRRhqMXi9BYXIAe4EzavdC I4qumwUoNS5KP7lUfXiJF1ZpT5WPGKhE10XFcR9l0t9hmZirTlVDd1Q== X-Gm-Gg: AYBFou1AYADxE9pjCk3KOMTq58nJhh1Ay0MMZR35t1Q8qQ9RAVDyJ3wV44VqU/F7ppf vQFDgxPAaybMNMm7AeK5r3ynHMzyXOnrHipvSLKow+rmP5s8uN+j/Xra/+/RUZuiVuu3v7PKF36 cEkJ5YuEUDzpK9pWnkLIP0ySUvdXgTkPOxuYaHsLKZ3DCFZmzDQKAMPCWnTzvPSEdS+nB6GRdcF aL8KY6aAaD6yxgDXZuei2nbKBOcudtiQTL8rsGhqM8iL58wn89vdNj38zo3DZhPpPeqzwkcoXEO x/jkvgl44dwqDG6RA2JZh7nZxh5Ugi++PdKfiVRVvhG4FHbZe9M23Dr2yAoZEQ6uPKJqCNl6mJZ gpN23aUwn4ihyywOo X-Received: by 2002:a05:600c:1381:b0:4a4:fc8c:cfd9 with SMTP id 5b1f17b1804b1-4ac180f27cfmr336447255e9.25.1793728934766; Tue, 03 Nov 2026 10:02:14 -0800 (PST) X-Received: by 2002:a05:600c:1381:b0:4a4:fc8c:cfd9 with SMTP id 5b1f17b1804b1-4ac180f27cfmr336446715e9.25.1793728934234; Tue, 03 Nov 2026 10:02:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793728934; cv=none; d=google.com; s=arc-20260327; b=qsyUT1gSjTicqE/ziJPZ5lTgBfrpQJ0HrqdmLdsDLLV3T0CNDWt36IbFm2g1YRmXiz bYe8ZdakcQmJ4LoPRhXHORibYbq7NHC3PYObParZBN6lT8z+nwyeHDBIUU1u9ZtgdIar YzMwcXQCDgRaBTtBJebrpTveCl5GIt3PYSt35FHB218EGHCNVcduX96LoqVgTKt/2HD5 w7EGmhvg6rLd44JDcDzX2bGhx9dg2d9MqI0ZYnzv+FcCWTj+UBcgE/zkw0lW5z6Ylkx4 zny80o0niCBTCJHjYXYiYhEkt90OREkw/LV1C60xKZDfQTxtGn3vZ1ph0HCiVBpOiwRK bSjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=rXckf8RpBEXhV6YRnYQBubVTzsjLMyqPtm9lKms1dZg=; fh=D+fpfNE3eS/JDEf1ElWXHuM/4IOsf9Zyu3iteEH/Ms0=; b=sA7wCzDXCM5zYmZUNvmGOOnypfNkMNpXRfgLCKm2P+/ryppe7CFgv/uhVHk6+SfEVR Yu/dkX729kXqaUv5q/9XHq79c4rusbIp4s6VFnceFUDV+VJ93NHpw6hISeV7Pgo6yYKs dV5czk6KCdhCRESHpWy/S7ZgBEpaTlyEZg+WItfPxzUBrKk44DcxrpZXidAIVSv9mlSF chLAMe6OtaPgwRDRngGWCNBcHOMQfb3NpebuTK8UC9JRkZAVUynIBUEZl/2AXcxAjXwA yFOU9pDqekBKNhtyMXE/r5LkLOm3ZgJk7y1pUdarCO4PndhFfCI2BnQWFbPmYufZl34A 7ZOw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=va2lSE49; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id 5b1f17b1804b1-4b2a53733fbsi67976635e9.0.2026.11.03.10.02.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 10:02:14 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=va2lSE49; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=rXckf8RpBEXhV6YRnYQBubVTzsjLMyqPtm9lKms1dZg=; b=va2lSE49Ktq9 VF18rBKNNdric/Gp0l4Tn5cEjB0kkoQqiKNDfxjw88X2M7lCrt7KM9q+933e3vWiqdX6i6JWVpULC b847kw+IwdEC4ekecu37v5aP7is7OJ1OGXoXoq9CSCOAqUQYcU0sX9LqxyaDdjQ/onN4HRMyggq8S ACuJJvXUd0aIqRYhBzLKfublmpqSnJ2thSHVOL+m3qMIvqZTVwGD1TBrH4O01k6KTMb/NwkeZ1CPL GsqA95jTTdAEu6RykoemIWkrD4kOTesfLptP4LywTB03N+REwNK5gKJBzpnuZtoA5W+LZ6BmneYSI MaZGjLHdvpwteXZGEOt8pA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOIlu-0056b7-0k; Tue, 03 Nov 2026 19:02:03 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Pavel Tikhomirov In-Reply-To: <20261028-ptikhomirov-vstor-149268-cbt-account-at-rq-start-v7-0-5c48672191c2@virtuozzo.com> References: <20261028-ptikhomirov-vstor-149268-cbt-account-at-rq-start-v7-0-5c48672191c2@virtuozzo.com> Date: Tue, 03 Nov 2026 19:02:10 +0100 Message-Id: <179372893089.2555502.5444767755724753451.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1430; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=R+tJz6rZuIPnDDkSlV/LQqFlMTpvNDJippDFFGQON7k=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq6iGkpO/+JNGqsPYYcDooepS1Vw5Z3XJqkjiK8 rU3hhcU1ySJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCauohpAAKCRBRlgpH+WFc KvcjD/4p6AHprR3zMMjYhX8fKWXyzILxJ8a0m7FnVCO5XbK+ya13xczTlJL4Qrije8OL7Gv/le2 0Gas2daf93W+6dkHSMHmWEbRqYCa3jJTarumPbjtVJirRsw8+tIctrXhdH2LnfK4MhVBPM/410v yvk4c3ctTOqiWNRs9snH7L1Kt9P17esAGe44nZVWCZlQDFg4d1hf96aHw2+NyVADvMgRCGJTz7+ 4pjkzVp5aI5/NY67ZadViEk9cpWaT+BwhxS7SYk34zNPWESpwnA3OAoqxodhE7DRLHqlMrMe9Ii VbkSbsEUdfVQXBGZguY12gT+TQfbOD0kMIt4U6Gi+QxAPvCMoisZnT6bRUiQYAFNUhNad5Pg+6O t//VcBRrJyyx/NBOXb9uGRxgoS33ZYxGlg9g5+XBS/mLo8FswjfapV1UPwpP2kvwVtPRrX0r4Ba MdsnKm/Ktl80bvoZEvS7gRSCJa4n5+UvMX+Mguf318ohen5R5qp3TC3MMfMlcXTZJZT3CVINvNU aahbfAAH4UfD8+sMpbMvZo94Bw4HxKGWhvlwqps+jNyLSACqsTpB2hVOibj4yutP4wHxXyoKLg7 Q+B8+NCFsyV2Q2EM9c2HXEqTiGEl73CSwPovLJKZtMH2kX4avEicTipT93Tz+mz6Q66+ZqNnEQ7 YdI4oibYQoBP86Q== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v7 0/8] block/blk-cbt: don't lose writes held across a dm suspend X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Not applying v7 yet: the REQ_NOWAIT question in the 8/8 reply decides between applying v7 and a v8. On 10/28/26 11:11, Pavel Tikhomirov wrote: > Fix CBT missing writes that request-based dm holds across a suspend, > which made incremental backups taken with ploop-backup silently lose > data. - VSTOR-149268, which all eight commits name, is already resolved. Please reopen it or file a separate bug for this series and put that into the commits. - Fixes: tags, in v8 or added on my side if v7 goes in: - 1/8, 6/8: 458bca130a8e ("block/blk-cbt: allow multiple cbts in a single queue") - 2/8, 3/8, 4/8, 5/8, 7/8, 8/8: e713742e2ee6 ("cbt: introduce changed block tracking") The review also found four old CBT bugs, not introduced by this series and not blocking it. I created tasks for them and assigned them to you, the details are in the descriptions: - https://virtuozzo.atlassian.net/browse/VSTOR-153220 NULL dereference in cbt_page_alloc() on BLKCBTSTOP during a write - https://virtuozzo.atlassian.net/browse/VSTOR-153221 crash in CBT_SNAP_CREATE after a failed bitmap page allocation - https://virtuozzo.atlassian.net/browse/VSTOR-153222 an extent evicted from the per-cpu cache misses the snapshot - https://virtuozzo.atlassian.net/browse/VSTOR-153223 a write allocating a bitmap page during a resize is lost -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel