From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 6D4FE80E7E for ; Wed, 4 Nov 2026 17:01:38 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4H0BkW025163; Wed, 4 Nov 2026 20:00:14 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4H0BkW025163 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="eI/qRtMn" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4Gxsf0025134 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 4 Nov 2026 19:59:54 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4Gxsf0025134 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-490ab0a20ebso421339f8f.1 for ; Wed, 04 Nov 2026 08:59:54 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBzV6qQDaUwiFORxeQjUpE9ooXTPOI9BIicS4af97UkS9VmAiW1dXwu3FRbcxYPFtv77f8XRRg==@openvz.org X-Gm-Message-State: APuU4Z/WBbbw0Ucdvmgy7Gcjs3v5GCFlmiJd3R59x9cEdkiFmcxUxagW x00hNlWqdIWc0bFOwnAsNLMsgV5TikSX1+SgNcMCwKbdW2Pjibae484M5id4QnStBeRs1LfJDNI khC8xe3rV7zliFdFDKq+al9VT+wZkqVRaqHVJv8s5KI4wiNDyfFKBug== X-Gm-Gg: AYBFou38BsLJTD4FRnKSVPUOJVXYASzCocOaR6sBted4DH7LNshIbtknrlq/Hs1b1AY 2fDxDZ8R56/ic75uPTjay9ZQNBcuyomaXk2B1Bg9teJyVoa+xdy0udaK7Ed3vpsC4LpxxXqE8wh zPAz2gcURJ6t/HQHzRBsELXGuYi3BNsM/ogUo2LoE0dmLQ6atXBpPeseY1X5K+mAyLZsCzps1wg DnwRFP3+9LXz6S4LM50wrN4db0DG7tQqynUie3qbu02si67Lz12skliU3RI1dO8QeFoubSJXANa 5D7o4XNAtYpGQLkgVqAMIEX008R4aoJeGq1+yxf+TCH64Y+60HMYlDbvhqvR5huX3Vq7M20U3qc wjC6jWlvjivaHKzi5dA== X-Received: by 2002:a05:6000:15ce:b0:487:1662:cf4c with SMTP id ffacd0b85a97d-48e6e2c155cmr27029961f8f.7.1793811593859; Wed, 04 Nov 2026 08:59:53 -0800 (PST) X-Received: by 2002:a05:6000:15ce:b0:487:1662:cf4c with SMTP id ffacd0b85a97d-48e6e2c155cmr27029923f8f.7.1793811593286; Wed, 04 Nov 2026 08:59:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793811593; cv=none; d=google.com; s=arc-20260327; b=a1JTe9gM5KjgClmWQnemZurhwdLe35tSTLIvAq2GFJR7JvvOvYVPZOmSsInC66lyM0 oxy5mHv2zbmC1LYDas4hKNE5jWyi7juLFwqVc7zH+qdkbXbsGxoZrxNeFCQa6Sj3g73V UBZjGgvlhBjHTCgTV0sHvCpyRPcqeTXCBLrjVlmumK3yaqmf2MgDblNvA4FpLAi+nG1v a+10cdKEPYzsOX9MmPmtAj4fvqte4YGAKXhYIAyIPnQ2DY4+gC70hBY1bDgU6U42pe5k ksuin9/T/XX4OVoyFCLuoZ6KcthVpyRORtkPYJQk0MNj96bz6klron6L+jQK/QPKCJ2b V+9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=LYmw2VhJ5XOh/2Pj9rmql47F4dc4hFd+Io4T8uwyeDM=; fh=wjIBJwS4A72E5Ce5VjfhniUGUVdfOyxDI2ywJwwowhw=; b=lKFulKJu92brzrExq8CU9csOzJsshgxVz73/gd3bBmKgJ5WNbU7VsHqqo5lWWbLBU8 MnruO+dDuRbV6S1v78J5U1xPKUla+cOUYhCNLESYfs4SDQjnY7xmb0aay1EVwJRdSGCp RnxB4oUSBIA6jilYcexp29SS1hNh8xXb5JX/Ab9sgLCKiBL8yqbWeRUbSZV5gT5zHOFy UbaeUcr0QYZ+KhoAfKo1pnVyruRrN0Kj+VnuiSWX4wxOPE+bpXEweoeVSIpkngNcmGPv 6XtK/lZq7eA2vhQVx1Jx4kYdX7t5nKsnHwWcM2f4MI1x9aKTC+6Ph9DOSemKjIVXiilN Dscg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="eI/qRtMn"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48fed271654si5137194f8f.84.2026.11.04.08.59.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2026 08:59:53 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="eI/qRtMn"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=LYmw2VhJ5XOh/2Pj9rmql47F4dc4hFd+Io4T8uwyeDM=; b=eI/qRtMnu57K z8WCUmZgMkyoaWZCtGt8Di1AWwL/2v+Io8OSJlJzTcTDpVDQMzdpB7rzWIsuO99dqXzl/u6OPZJPX clsCxxp3zn0i4zPx2r2BtT8L4xfIMBcVCCLE/8vo74pgbw8fI94xDelLVabGdTHHq5x57cGgs3fcL LwC9rvyBzFPOUHmEDtzTPs5M7nO+Xrro1xqarPpi6NwhyzduNAQp/PhSCGt43tbDWBM87LRgPmY8C Ve3bRkPpoZbAuHJqdN8Mh0xB0vK/OT0/pNQaLqLP/EjPJ9JzbPHabcpS2Mmxj7r+lMPs4Ex6l3sxw 4PLMQkSRX1DSWrEBK9WNHw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOeH5-00EvRl-2o; Wed, 04 Nov 2026 17:59:51 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: "Denis V. Lunev" In-Reply-To: <20261103090813.166986-3-den@openvz.org> References: <20261103090813.166986-1-den@openvz.org> <20261103090813.166986-3-den@openvz.org> Date: Wed, 04 Nov 2026 17:59:49 +0100 Message-Id: <179381158915.2686233.3256524369858117621.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1040; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=kINCxAXrlwtbwd/oZhLHKORh/JoikPxPueb6VHNu37w=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq62SHMHDYVQ7KtMdo8vyALtJgd3nLiKr2FxgTZ SS3hVGQFf6JAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCautkhwAKCRBRlgpH+WFc Kv3xEAC/T4lDucOek5C7beYBLWV+q821oYh+fPwhZB6lvfu9gfPVL8mUfYEwerNQuBDWr05RWPZ c3LMRS2enDb5vGnPTqaSZiDkCVQgB7q0ZPfbFirGGUAMFUw8EvXJ83Si2KHjy7Gh+MRAF86dWr5 fdrmCu+9lr/pwEmcOqFOb+cl6ZS9rodYu8rwalq1JJuZkNH4JnHNSHggcAPx5wYSffeq8b3qsa4 cn9g1eSq6qfvumU9B2AQCE91/hqHsoesRKbYDDn/+vXM+Fpe4q/ztVtrS3GdEchviRBntd9vr2K YY5ui5SdhG2aYRMqd5lyYU0WlzdOHwM06a9oXPz6cBd8OrcIwSBGQancne4fqFb1SmyiJNmE1B4 tvDrkFdVdDZplvtaPjh3rrAc2DyuwKTEKvXvGicoGCcLXnT0fbS9ooTeK8atlyyGJVEnAcFhlS7 r7Q3LnCdYMtqotPDJAV5rzmnGCXxPjTOesxBifArV4wSWiO7aR74AF5oX1LS11vBcDK49i66Zx2 rLQmweuHFIk8d2Kj9iyJqQle/gRsEIMO/OkEEy8Ul+8tAxmYtBIy6mEupQ3XZQzf9pJ3RehP3CL sAlaMNzanMo6aWSWag6y65s2iUuIbNtVBqy5EiDBUHP1UEph9sz4esECRukzLNWS9rShqEFIEO7 WqrJmOqVSxksTIg== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 2/3] dm-qcow2: fix backward merge of an inner image racing its reads X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2 with the changes below. On 11/3/26 10:08, Denis V. Lunev wrote: > Pause submission and switch the inflight refs for every image. The > pause flag is only tested on the top image, where all qios enter, so > pause that one; clearing the flag of an inner image paused the inner > image itself, which held nothing back. Item 3 of the cover letter reply: say here that guest I/O to the top image is now paused for the inflight ref switch when a merge of an inner image starts or stops. That is fine, a merge of the top image always cost the same, but the message should say it. > + * A lower image has no writes, but it is read by > + * qios of the top one, so stop the top image even then. Item 2 of the cover letter reply: write "no guest writes". A writable inner image is still written by qcow2_break_l1cow() and by the merge itself. With that fixed: Reviewed-by: Konstantin Khorenko -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel