From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 0BF6B8125F for ; Wed, 4 Nov 2026 17:01:19 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4Gxu4b025147; Wed, 4 Nov 2026 19:59:57 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4Gxu4b025147 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="QTc6esow" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4GxsmT025132 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 4 Nov 2026 19:59:54 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4GxsmT025132 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-490a0e72578so463942f8f.0 for ; Wed, 04 Nov 2026 08:59:54 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBwtuD1m/W7vyFLUT3rqFBEUkumQsgBAt3XfjA7xqDdOI/mMFA/6LyQPeDBRm6phxDZYPUAhdw==@openvz.org X-Gm-Message-State: APuU4Z+1pzaFgUijQR0Us+2WkCWSThMTcO941l72Ny/puLFpfXc7a6zi UeLkBcnRaFJvsZgy3B9PphsSQbTGRIY3HSxRhAiwptUrFyzD0mcAcvHYv4d0bP6Po7tVVTvlodH j4Wab8gPRUvpnc5PfF32ZoA/YJJUCGz5nlLVPwdWAq1cP7KHlzqJN3w== X-Gm-Gg: AYBFou0fWsPjXc/WmfojVI5I5LlTrv7LsyQbxRX3xGBmHHgMoK1lrdhyBkNtf9mtdVV AYAhgEBVjlNWvilUa7pVcPlBUJVCxFAl+eDQ74JLzIDlB91EqPBGI0Pr81Q2dJtccugZAyXH6qP Pa8QYpOBqEyb6FFJsUKvL7Lb/7D+UURESlhGx2mYFVujmlZb6Rqwj1rzz/hOpLbWHTp+OhVFKH/ HaifwJRFABAScqYGNxg/BDbFOBEaF3dMrbuXDCawa/ucgzeRPcZwKrSnjXuPu9hN4JlHgUC9U6W UeeKkqSW3fW/dITW7ZQ8ku39112D24eAmOZK7w8NVnV0xvHnmNeiaHBj6z5EhGCZnGDrPnWDyyT zzsRXoES6PPitnA4TVw== X-Received: by 2002:adf:e003:0:10b0:48d:ffa3:714 with SMTP id ffacd0b85a97d-48e6e2f2964mr29776767f8f.19.1793811593877; Wed, 04 Nov 2026 08:59:53 -0800 (PST) X-Received: by 2002:adf:e003:0:10b0:48d:ffa3:714 with SMTP id ffacd0b85a97d-48e6e2f2964mr29776743f8f.19.1793811593460; Wed, 04 Nov 2026 08:59:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793811593; cv=none; d=google.com; s=arc-20260327; b=H+B2ugSbSeKkTrMprInaa5wCy8huCgn7yHSh6sA1buAPTCX2GDAwLG5+7UQuduTGag cBHBQWqGQJRmDQxUKcK4K5PK9bsZ5QC+UhukhO9JTIfklxP1goIl1zSYFqSuBpcNipI5 ynSLqdgGV8SpUmUZnKHb/PF94mFn0u6g5NHOUGAarwzlbQAsp8bdKQJDeh8Ck3Ytz9ZN 1yvbMNE6aIMFAoMpgvkobBOoI5Re9qNRQhlKwa311UeqTEYDTW6njq2C7VYFZ1a3ysw7 8B0XsOpDuxTPfVwxPMTwjkloXJHS1RTuuO1LzyiUXE3ktJp6lP41wnNv+Xbj+znCUWDL 8j6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=gqY/fF6c7Ju/FlW0tSolTwv70GB0ktGDtpsxhgFsYww=; fh=wjIBJwS4A72E5Ce5VjfhniUGUVdfOyxDI2ywJwwowhw=; b=EEGP9Nu8o8yz9vmvwrisz8XATJ+sl0pBEPYJljbQ3r+gv84cdCxpq1nkoip8Glsu7H 0ECMyvKzGrImWcCCJ/KYYaWYoNaJLYf4E6uKeMXcspsYxXXz3nHADMFiDWfBlm/kateu /kdT/MYZKt4phEht5gkpdQOw+o4MpoUYgDpsrAibUleKZQcHCnvfU/wAezJDohdzXhaO mR2tAiUriVu5o2kOSNjJYV6p0s7y/QJspqfLOyJb4IpNUaTZ29DMfLjw6UzPHiWAcSZr E7ui/+3k4C65YMfUpycu3ZgPHCKX0dAHDJj4yqP4Nu51nyukU9RcbF12JFBfB0myY7AM Z79g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=QTc6esow; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48feda1fb2csi5151117f8f.208.2026.11.04.08.59.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2026 08:59:53 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=QTc6esow; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=gqY/fF6c7Ju/FlW0tSolTwv70GB0ktGDtpsxhgFsYww=; b=QTc6esowA9us cEKzGRrZZ5wfXYL2cPgShXlcoqh4N2tXAwmaQRrfQMluPXG8aU1fEWyJl3Jb6hyJbRkw4zjMn821w y467wenG8eoehrQUrmdxJRPKHpRqgjiboixB7zmMh1RehCsmEaBS84Vzv64jbNk0NZxDiv4u4d2T+ 3b810bGPxdsEhXQzUv2+K2+g3MNF267OuLiw4Od4jMqbIyJJ0EjEECq2nG/yKW2XOaRaHv1Ub/bqv f0sftR45QZqflIG/4BpPE52XRJ5NooQysjJdvY0bxVWaQCQ5MILefupvlvzIvHlvmAWqfVRxewBUg ji1oNrfaISNYMGuUacvQgw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOeH6-00EvRl-08; Wed, 04 Nov 2026 17:59:52 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: "Denis V. Lunev" In-Reply-To: <20261103090813.166986-4-den@openvz.org> References: <20261103090813.166986-1-den@openvz.org> <20261103090813.166986-4-den@openvz.org> Date: Wed, 04 Nov 2026 17:59:49 +0100 Message-Id: <179381158915.2686233.9184442455379971759.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1132; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=f0grBoWlwTDc5uNFzdYHVQoY0M7rIqWm3sKIfCvG334=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq62SHed0lvk9ynT+7IXjSe80v1R252vXbqzBPv Fv2cax1lfKJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCautkhwAKCRBRlgpH+WFc KtnqD/4uGmmh+e3ZV+LUFKdwmPYGcqeVGt0UBwyfSOfV48RzTF681sTVzF1U9KfFe5s6Ioh/vUK BG7CpJshMtrfZZrKPFPX9kMCOGDXZWkymtibcPkjEKN2VUej2yGIDV3Zng8CbkNODspixSz5zuY 6A7YTVmLD9wMBcZ2NoXNSpNufhaj2QCMpjJkSRqcsWtUK9+D4XNxWnNQe1aITZnzp1GqRUlDP+7 TBSWDjprJbsndTlHGXq7sWgnuJhzGbCGV+wvU+0mc2ux0JCTbQ5BuU3YUr9SalIuGSDwCCEAApH i4ZnqlprEGjTZxkNlk6RtgbDkIomUAS6ui3obVpF4/DRffYnkSAy6B6tFLPDSLQOgebC01u8dOg pZa/rSzxx0pmBRdammeDF8dAshzOJrqPrVDY3Sf/Sp21WTWoZqZ36llq/Ol2j6Q+LAkfRORvkBb GW2wleS7E4L4YG2k0vwgvwoMW/IteNDwmegVG5VlQRPHvks+skMcZy3qpHGgCTgbn3/uBkVYOJL D6skGC3j3DTvAVdCcJi5rWYaxbTeZMKPKOomT057tLwev+DJrOkdl2uG1qDL6dcudj/+wFaHpdM SFN+VppxH2K7iMeIM2GkDAIfNoJ2Dj8KG26yNalE2eRdm14nGOXLt4jkga3LTqyXIgfwbjvGH8b 9rlXAWe3qemcgeA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 3/3] dm-qcow2: fix SEEK_HOLE/SEEK_DATA using an image freed by a merge X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2 with the changes below. On 11/3/26 10:08, Denis V. Lunev wrote: > + down_write(&tgt->seek_rwsem); > qcow2 = *tgt->backward_merge.pqcow2; > *tgt->backward_merge.pqcow2 = qcow2->lower; Item 4 of the cover letter reply: say in the message that merge_backward complete now waits for a running seek while it holds ctl_mutex. Guest I/O is no longer held, but every target message and presuspend queue behind ctl_mutex for as long as the scan runs. That is a fair price, the message just has to say it. > + down_read(&tgt->seek_rwsem); > + qcow2 = tgt->top; Item 7 of the cover letter reply, a separate patch: when an md page read of a seek fails, the waiting seek qio is ended, but nothing completes SEEK_QIO_DATA(qio)->compl, so the seek sleeps forever. That is older than this patch, but now the seek sleeps holding seek_rwsem, so the next merge_backward complete and every message after it hang under ctl_mutex too. With the message fixed: Reviewed-by: Konstantin Khorenko -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel