From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 92F428125B for ; Wed, 4 Nov 2026 17:01:49 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4H0QNW025171; Wed, 4 Nov 2026 20:00:32 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4H0QNW025171 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="lhFxGNmm" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4GxsfJ025137 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 4 Nov 2026 19:59:54 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4GxsfJ025137 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-48e00f3929bso1297227f8f.0 for ; Wed, 04 Nov 2026 08:59:54 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBz+puUeaXoTOQIKziy/Z0ga1KvGG1OmdHFlQENQ96TA/knSet9FJj9F6M+t7QRqi4Id9pGXVw==@openvz.org X-Gm-Message-State: APuU4Z+/bwugL8yxjpYLNTvRtV7I/nFXY1LYR4LTpUqG93Tk2W8v1J0I bOpM5ECy7Kk/wQ9IuT0uA4lQUUFAS6le1CqPKUrQMgAcJXms5Lmjxmt3JQE6XKVgktr5fy6OE8v TI6mU5nepH6SnkWHvCwGNaCI6gqPFyCTVsnZlz+NU3os2wdjXTOzqVA== X-Gm-Gg: AYBFou0ySrwnXlPmqB4uAl7XwbQyNBIavXlbjocyHlu+Q44O7+P6niz2Dp2AxdKT0b7 jmufp1iP2MPn31A255V0j+TticVE55g/yPBJm+PQrlSWgjX93zdSQhq8JgEKTZL3eOkmWp9v0XG cKaeRy8Yp1uggDwk0xeqMfd6IJDcesO0qzCw/GcmP1G9z2a+oYdGgbAAA+cAmWPd0FywTZNfUY7 RF9SialoRGVMwNE9Bw3hIepLJTm3Zul91l/oJLYGXWpJSfscuDjnlvqsLQtgX7IpHhV7UCuTv0O jsPBoM8nX7rKLcrcpiHSdkBWTQKUUF4hdPXsHHVxXAPjCeCf5jsZmBPoZ4Tm6WlrlGdbUJhUyf3 qlPbCH5RpbKm7HTCm X-Received: by 2002:a05:6000:460c:b0:490:9fe2:6a2f with SMTP id ffacd0b85a97d-49119a0702dmr71186f8f.14.1793811593998; Wed, 04 Nov 2026 08:59:53 -0800 (PST) X-Received: by 2002:a05:6000:460c:b0:490:9fe2:6a2f with SMTP id ffacd0b85a97d-49119a0702dmr71112f8f.14.1793811593257; Wed, 04 Nov 2026 08:59:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793811593; cv=none; d=google.com; s=arc-20260327; b=a8sKaOc6Wk2vE5rYDE3uy24ij7Sej/6A5PIZceVfLAFKxyGS+9A0vSpO+vfo9MqsnO IYsY9U82xoqjp2sv0afADdC6TNExkqGeAmifR5z8iPGm1feakl2bxhHNHFyrr6MvKaJi 9VQux8SkOD9Vg56GhFJ8jnJX2qNskzlM+1fxsxKFJR9Ti+7mngO8b3h6SIbqb010IQnB BkK0MjAVe9JrHQENSclewb5zP/VYpCadkU50RG9TSxPS5ECf1CJt2GWT/s0hReVR+ZY2 UU6MRaCyBRFca3ERUs7LKSyKWj0wrgdq/q5ILoHxP8nZ9lxKsk4f0JY6kvce+yusKCLS YtVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=o8/5i/5/LZispV6oBhPdzUSDRYKd7VZaisNpOzAauIo=; fh=wjIBJwS4A72E5Ce5VjfhniUGUVdfOyxDI2ywJwwowhw=; b=hOPqVP76djqGUdThm9otBwxYR8mGidzaGPcA8HhXTLN0ECso1vjN3AxgfRtGBaSglh 4ARKPSNDSdmmpfL74oPjULWQSsCFSXHkpLhGVBzNLfNS88llUyoSyyXLi6iX6lF22smj n6j/24bJEE3inI4xebhr8A/H1RizDFGwtTrUAIsj2/K9QvCSPxPwsu+ZJjBEmT5Rtm0e OV3n5kOWZL87pRUWFNdq47ArWQb1wvcmRf7LJqFh2v3UntatwnyLXarI/FHZkaup390A wQcrgj6VV3bxu9Qs8zdMYoaPHmC/K9kA6j1HD8tiybrKUgFnphMMZ8RBTMy1iGZd8eyI cIZw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=lhFxGNmm; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48feee32a22si6339617f8f.285.2026.11.04.08.59.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2026 08:59:53 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=lhFxGNmm; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=o8/5i/5/LZispV6oBhPdzUSDRYKd7VZaisNpOzAauIo=; b=lhFxGNmme2se j3Oh8Jbj5i1I4U0d4PMQXW+TkKS5/HLL+fzMJFTQkaWmERv8saZccwtnumnU4O4WiPS8D2PIv9/Sy /yzVZQ/MrBBFXbrWtOvlKtN/aujIfh/mAG+KjHEQ/8XY2KUivEfxJiFiYCYZR/GeKGcPFlTEYmTvl 60a8SktpWwnAlmPHIAvLc1GxcG62iJnWdoW2vFDIo68SJHZz0ydaOkCJ/rdw/gGjhYmIwhFs4zuhb 3wEIz0XRWA5rVq9MU8UBSUEliUKzGFYGZozOnHNlYuW4ySh6I2I5qBJ/Mwt8oAU9YqZBO8P7sS6Lg nBfImyLBJoFDNLf3wxcsxg==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOeH5-00EvRl-1j; Wed, 04 Nov 2026 17:59:51 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: "Denis V. Lunev" In-Reply-To: <20261103090813.166986-1-den@openvz.org> References: <20261103090813.166986-1-den@openvz.org> Date: Wed, 04 Nov 2026 17:59:49 +0100 Message-Id: <179381158915.2686233.9485645811464314374.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1735; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=qX3tBrybBN9Fc3DASrlFuWMUAl/iYgA588Ep83eUXL8=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq62SGaF1AtFOP1sytvJNDzCGaxZJbNSJmwBfSQ aBfptikREeJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCautkhgAKCRBRlgpH+WFc KoXZEACjEtBMCHtjXQJrMN3aKvjmFgblfhjXvmOMA4tyfrcYVI8X8fji4sdSBD6Pci6hyU0DGua aywCFU/C/4Jdrl4EB8NaXIG3BMhsBpX1vNs5owIIRTF0c/UCJIxSXnqpmXbr3k3iqXgW13E6dGT T4Jf4Oh9lMGJj8PzeCYcyLTELwUS+6FLtT77Pa8W+7MnkBIyZk4tWc1hDLDhvJe1JtHmf5z4cBj 4dvluUp/2zV5BqEs32QF++p0EZ+tlOm0Poqufr69dTj6jZhiOpzf2TBE1/Wmq0lulJlaDjIwoVA DoMhfCCrJAqFS8yjRT4etH/dPiXEDNAL/rCDuc1TFdU7dC4YXZOQ244BZlqW4W4/kG8i2JH9KIp 4IJPbIeot1G8UsW8+mb9BnE4hm1yqDvfnPdCulF+HI0TGEQTgrFhdQnIRKKezdoAKkpoNhZMOVk 0oeT5UaBnPkpjcVYQYeQgD6J5Yr8YLSjx+hUy7oG3kdRli/IKsNx5F1je5qbnHwevkb0EI4uTuU EU67y2xM0njJROM4tGzmN92jVaz6/aT1gwIdtkcD558y95Q982yaE7zSCk+dXt21sA7uZ+DPSm5 ml8sLDk691+drwo8NWNZn9xk4yB3ngonpRX8RydJivS7AfowJZr/QlOmTnudtmIpp4z3QrbYMgO +lqPZUN8RPBBiOQ== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 0/3] dm-qcow2: fix merges not stopping the users of the images they change X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2 with the changes below. On 11/3/26 10:08, Denis V. Lunev wrote: > Denis V. Lunev (3): > dm-qcow2: fix a failed refcount table relocation leaking md pages > dm-qcow2: fix backward merge of an inner image racing its reads > dm-qcow2: fix SEEK_HOLE/SEEK_DATA using an image freed by a merge What to change for v2: 1. Patch 1, code: after a successful header write, the error gotos must not free the new md pages. Send them to a label after the free loop that only returns -EIO, and update the "Note for a future reader" to match. 2. Patch 2, code comment: write "no guest writes" instead of "no writes". 3. Patch 2, commit message: say that guest I/O to the top image is now paused for the inflight ref switch when a merge of an inner image starts or stops. 4. Patch 3, commit message: say that merge_backward complete now waits for a running seek while it holds ctl_mutex. 5. Cover letter: fix the bullet on patch 2 quoted below. Separate patches, not needed for v2: 6. relocate_refcount_table(): the refcount group of the new reftable gets no refblock when the table fills that whole group. 7. qcow2_llseek_hole(): a seek waits forever when one of its md page reads fails. The details are in the replies to each patch. > - a backward merge of an inner image pauses that image, while reads > enter through the top one. A read reaching the inner image as the > merge starts oopses on a NULL qio->ext (patch 2); Item 5: before the series the start of an inner merge paused nothing, only the stop paused the inner image. Say that the start paused nothing. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel