From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id C5DFF8017D for ; Wed, 4 Nov 2026 21:36:41 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4LZTwq027048; Thu, 5 Nov 2026 00:35:29 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4LZTwq027048 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="OrUtaovO" Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4LZFnM027005 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 5 Nov 2026 00:35:15 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4LZFnM027005 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4a1fa972b4fso6930035e9.2 for ; Wed, 04 Nov 2026 13:35:15 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBwB5v3mTveBxJGlGwJSnA8jr1G8lcPKgRcoplJhzi9v3oj3LcuXJKHGTTp2XjQWwZD36gJnHA==@openvz.org X-Gm-Message-State: APuU4Z/RptLtwwozSHPp+j/i1E+ksOihnoPCpMwfyaQVoV+LS68nl3Ri N0LhEofoekGgQ49MNlBbZUQTeVSJnMtwYs+Et2LQgHb0DJK0hOehTkWa+NXHdnaNd1bN/tR+E+x POYOa+YaSa7ZoMOzkve+q4VyD9rOme2T8btlj4z/tfig5c9uEtgCunA== X-Gm-Gg: AYBFou0XRSontoS2ZSRDHZGyFQtyiFLIMuP4tjP4Qc7enchPpWSzFR+2XmyxykWrUQ8 z2lLebpS9GSfUlBtHokK/diraapu2TUFgvHH3z6+rfGaCBjFhhlqFHOWsIDAGAF2+Fd8noN2ejt JA8gIlWQyuw0V2W40Mre6TZl3q2i4dWZfU0bXIC6tRu7NTJedm2JUez2fVCMrGe+39EaytoE6Iw 5jKkPGsHsiN/GaD9rGwBHkIaucc9u+FV8/j29Bs+BMW1nep5T9YlNxTgkGPU+Qcq2Rrg6A/Z/VZ N1yRkXIchqNmiylyBQlP31FUJvojvleSh0VvJo72vJffdcVsCOo4QbRKHEiuP7huJDWM3L/G3HS /LsQcHLlM4CDr3OwRwQ== X-Received: by 2002:a05:600c:6212:b0:4b0:a7aa:843 with SMTP id 5b1f17b1804b1-4b0a7aa0a54mr220861385e9.25.1793828114931; Wed, 04 Nov 2026 13:35:14 -0800 (PST) X-Received: by 2002:a05:600c:6212:b0:4b0:a7aa:843 with SMTP id 5b1f17b1804b1-4b0a7aa0a54mr220861195e9.25.1793828114488; Wed, 04 Nov 2026 13:35:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793828114; cv=none; d=google.com; s=arc-20260327; b=qnUvCUWx2a1Lp9NX9rqhCdqnf49HMOlpbSV/TRFIqs3qL3GQlvtFPxhvvTZwUNqxPy 7L/QeEUagyzqMpDwbvmy7Gf8kmPNSIslQboP/9gnJY0gYVOCZiBurw5mcHBT+NO+/fzo ic1QDcAay4U/fnI7vc1TEO+E+3A7jZWfa8uYisXQyPiL07H+qpp69NAy8/ltCQPoHd7A eMK883a7GINlJrxLWiJ9Ry3gGxFfCSdqncENyNQHDBFdVP3Y7oU3Q8WAkJam8BBRkPJz h+roXmK7RR07nSCCLTSkNSiCM1j9sYVbPHzf2vG8orQMOEZ6BGxJrzCober9HoX4EqZx clVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=FTj5Qof37MKKEGaBw3TCiKVgi0C+EDn4ilx0qg7VNyI=; fh=wM93IzJ1q6YTmltzeth+TON77Ag69AF1TepZ24u7du4=; b=lkwKIyakXL9K0O9vlUJygqw4gvmhSfWx62TJrwwCoMxQsaIBbCdlY6KPLAwr/NFCFn Gfwr6d2Z954PC67wB75qEuK6cEMdZHByOefb1Alwi5ov7mcsA1XtXhvgkcqtVJDy2URd EruDVDJxzNb0/SlkC9ixl6NTRKSLcSjhvk1Ka89sfCMVJ1PRWSylvbDmSFbyuxyxSLet NmxPe57C6hf2BG407BsTz8y/i0KFYlHoZM5yF7wowLI5aoFVcIcW/cjHaEn6O1gixqe5 i3fj5H5/4oofv+/RCHuFAA21DqY8M/VlvgD2qk1i0rgE197yB1zS84jNfQLI64qR58Y6 YeQg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=OrUtaovO; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48fef4e8f61si6344344f8f.329.2026.11.04.13.35.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2026 13:35:14 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=OrUtaovO; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=FTj5Qof37MKKEGaBw3TCiKVgi0C+EDn4ilx0qg7VNyI=; b=OrUtaovOXl0e tOT+TV4NpR1t1nsD8LA79FbPQSTb66gEhX2YF8FXMy9LCaglboCqx33uEXLTJrB6D9xiR336OjWYq B+ZjGVPUiLZLwDQhiIB93cvsQkwFNXvePOWg3I1JfA48F1jwjTV7kDZ2huQddLfQ9kKDG8kXHubWX 8NJaFNXpX2qTDbzW8y2QwFh0H55K2ZtGgXBXJx5Kfkwbp1rboZmFjemnk4Z1+XDcHwiRaaIkLr+Xv b859SFHzSPTd3UD5cQN74krFpklbqstu4HaHpkTngBWrt5jhZRqwlqzYRNLzIIbIL8xOvy+cb2y2p m83hwhsx2MRanUhd0b8umg==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOiZY-00248s-31; Wed, 04 Nov 2026 22:35:13 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Andrey Zhadchenko In-Reply-To: <20261029140346.465768-4-andrey.zhadchenko@virtuozzo.com> References: <20261029140346.465768-1-andrey.zhadchenko@virtuozzo.com> <20261029140346.465768-4-andrey.zhadchenko@virtuozzo.com> Date: Wed, 04 Nov 2026 22:35:09 +0100 Message-Id: <179382810903.2794215.14896211260574355704.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1199; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=uCcFjG/CzHzUkj4OXMYKeUIBq43rPhP3UlLL4NzT/04=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq66UPj/2q46dihuEF3zZYxKDAui8bmsplqIa89 B2NgzqCjdKJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCauulDwAKCRBRlgpH+WFc Kt1WEACo0xofh0MRj0/2xRNBT7Giq+zM8N+P6aG2APRtcfFpx8sCb+3oMSAQJd2tYr2JpMqXttK F1MSXVnUP+awJgF/+vt9zABQICIY/tvFm1a5Y6735M4grpNa5dpRmJETHgrfzbdInxqCYqtGF2t mdYhNMsl+/UQOsict3Nm6yJWyTWiUjSRIH+tO8PbtJsPRAbyiuiDAKW9PogQiHQfejHsCoyDECU h4kihWFlrrKrzpylcGkaDGQzvtDdDReFnrbcUHALSEP9D1CdyNej9ZvRlif0uhhvceZvpQXYvZX cr52kWMdQUbMi1qScnqeQ97/1kTr/p0M7JdKZ5CadO4UL7DNAI6+tpAqw8S0rsHWqEu4WjqR879 t3KIyiuZ8setz+5Cf0N+Nu8FcRa5zXoBhmtGJsW/s89vLMbnuB3EYqVwZMhVNLpGqd4skQOe15W PpcsOL6y5X5OjWyzDlfwzHcWTSWVKAN5mNk8ylAf5+hFhFttLihK6BeZiEhyaSoxm2FCqp95JQ6 Bl+XjD/WarRGKtmuvJOqtjB4zDZc9GZ68aQIxPIIpxnJsSUK0e/0zL4RkFqb+JPoRJTNSqqO5Gy sH+/EXSb1SKMxiabJZcGe67BeBD3guAMHf0w7hZHDEh+9QHaEymD8E+wT2DnAXiTHbuwUv6x2tI KwXZ4RMKR3xORAw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 3/7] drivers/md/dm-qcow2: prepare process_one_qio() for fastpath X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2 with the changes below. On Thu, 29 Oct 2026 17:03:42 +0300, Andrey Zhadchenko wrote: > static int handle_metadata(struct qcow2 *qcow2, struct qio **qio, > - struct qcow2_map *map) > + struct qcow2_map *map, bool avoid_metadata_changes) > { > bool write = op_is_write((*qio)->bi_op); > int ret; Item 2 of the cover letter reply: pass the flag into parse_metadata() and return to the slow path before qcow2_handle_r1r2_maps(). Why: for COW writes and cluster unmapping discards parse_metadata() looks up the R1 and R2 pages before this function decides to go slow, so the fast path reads them for nothing. The comment above __handle_r1r2_maps() says R1 is unstable outside the main kwork. If the R1 page is not cached, submit_read_md_page() drops the lock and inserts it under the old page id; when relocate_refcount_table() has renumbered the cached R1 pages meanwhile, a stale copy of the old R1 cluster stays in the cache under an id whose cluster relocate then frees. Alexander's remarks on the typo and on the literal 2 still need an answer (item 7). -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel