From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v2 0/3] dm-ploop: fix flip_upper_deltas panicking the host in its pre-flip check
Date: Thu, 05 Nov 2026 19:19:02 +0100 [thread overview]
Message-ID: <179390274229.2948524.9874460964554163584.b4-review@b4> (raw)
In-Reply-To: <20261105145749.2643035-1-den@openvz.org>
Applying with these fixes on my side:
- patch 2: paragraphs 1-3 of the commit message reworded, see the reply
to patch 2.
On Thu, 05 Nov 2026 15:57:46 +0100, Denis V. Lunev wrote:
> - patch 2: a flip after a grow of the device, with the lower delta left
> at its old size, oopses in the walk, which runs past the BAT of the
> lower delta. Refuse it: a flip that got past the walk would damage
> the new top delta on the first BAT writeback after resume;
The code of all three patches is fine. The damage and the oops in patch
2 happen only in some cases, and most of that wording came from my v1
reply, so I fixed the message myself.
--
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-05 18:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 14:57 Denis V. Lunev
2026-11-05 14:57 ` [Devel] [PATCH hci-8.1 v2 1/3] dm-ploop: fix flip_upper_deltas returning with two md_locks held Denis V. Lunev
2026-11-05 15:01 ` no-reply
2026-11-05 14:57 ` [Devel] [PATCH hci-8.1 v2 2/3] dm-ploop: refuse flip_upper_deltas onto a lower delta smaller than the device Denis V. Lunev
2026-11-05 15:02 ` no-reply
2026-11-05 18:19 ` Konstantin Khorenko
2026-11-05 14:57 ` [Devel] [PATCH hci-8.1 v2 3/3] dm-ploop: fix the flip_upper_deltas check skipping the last BAT entry Denis V. Lunev
2026-11-05 15:02 ` no-reply
2026-11-05 18:19 ` Konstantin Khorenko
2026-11-05 18:19 ` Konstantin Khorenko [this message]
2026-11-05 18:19 ` [Devel] [PATCH hci-8.1 v2 0/3] dm-ploop: fix flip_upper_deltas panicking the host in its pre-flip check Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179390274229.2948524.9874460964554163584.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=den@openvz.org \
--cc=devel@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox