From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 9896080E7E for ; Mon, 9 Nov 2026 15:44:10 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9Fgt6x000968; Mon, 9 Nov 2026 18:42:56 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9Fgt6x000968 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="c7DBJJuo" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9Fgi7B000935 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 9 Nov 2026 18:42:44 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9Fgi7B000935 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-4925ef75fc4so907942f8f.1 for ; Mon, 09 Nov 2026 07:42:44 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErEc3WKFnreAM2lDdxhgGeIy1ppCf4bIlJR0iaQa2uPC7i/cKQWHCeqo21v3hQpXHPJOiX3MhQ==@openvz.org X-Gm-Message-State: APuU4Z9oQtTYqjtfTWvMd1HzAH7fmslrVlOMEb4a/fRdWFwjl/nS1v7/ HbB04GMh33iyj2W4GaDJW9+cUvRvhV6U9FaLTXKtwU7IYulztxf9i0lzN9nuLeCoKm7YvrFixwH qhVpBGwEST/HiY9jDsfcUcPWk4U91siPNfpUQJSvk0p15eoxht37X6A== X-Gm-Gg: AYBFou07gNSdjMWYrOA2NkfAQV2CRUD7lU8aC1wu46dsfNJ1Tkev+BD8dKqB4MB+Dyo 5X2q+n8+NFNJ044ln7Y5rE98MQmKulW6U1505zGYLcnBcRqKGcJeXKWFiusbJcWwOgU0rG/tVYI TmikWWUKIHnPn8cQU7h4QIFoJEeOIMeH8pIVLJoIGAIT/79qCt5/uBLtkiJ45yPJQZICoqd+vQL ZRnCy3FFePojCa7BriW09A4RDSoDdTL1RDvaeNz0afJg38kFjefR2ztyHqdGT1yEfI51tSpkvtH mJrexN0+Rz8LQ7WS1dK3zU13amaP6R24MnuxPaArzUKQWXZPiK+GbECvQx/hngF2hx47wt0wuQu Tnfs3napbldmnfsDP X-Received: by 2002:a05:6000:25e1:b0:48d:b650:69aa with SMTP id ffacd0b85a97d-4958a6d1e2fmr7262099f8f.50.1794238964521; Mon, 09 Nov 2026 07:42:44 -0800 (PST) X-Received: by 2002:a05:6000:25e1:b0:48d:b650:69aa with SMTP id ffacd0b85a97d-4958a6d1e2fmr7262071f8f.50.1794238964052; Mon, 09 Nov 2026 07:42:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794238964; cv=none; d=google.com; s=arc-20260327; b=ZmY111i0Y8+aYIr/W0BB0p05VmQUwC/6fwSFjPtX/wuW12Mac+H0Q6FnWJfefyso5m FDZsQSYut/bnvBSUNvuLpCw3rZG98U6kwQaWtSpYLO3rhwuw4fSlO2nOHImO4OSRtBGc /ouDHrj7GZeESzkZkBadvsl5cLja6towDMEWsWK1xqABrFLvgxk6wyHWhqi+9wzj8NsT yiJp0bXLrpUH5b0MniLfKuHqnV2B5XnA0nesHxaSG+I9y0eokNXcHFkGunCuaXjhRjhI gJvlW3sGMyVz4IKpQnTVY4syxU9wB+FtLVvHCMnxfXaZJ9uCdSc9vkrXAXj5yAm9Z6mm xbhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=1nv0AKxMYVB2plTOcjKYRFjZvIQgzC1Spq+kXDbFhk4=; fh=AXaEMap9UVXDT/x707nN5u9hAuW2OOlHA2h2MmC//Kg=; b=FBbMCwqHrDB7KQqYiQ60VzANw1liP+GK7+awRP3IcnCtGmr/cpUqzETM+KqKezzP2a eStwkn31OGMQtIFtghzJTfJ/OVe8dXsM1+gn0g6iL5qKo1CVuQF+n9vbkePFuxVpyzYo IZ28W6sGrhJ/OJ0MLwJ0lz/JI38OB6BmLPmKv32Z+TCtwbXpXX14oo0F+m0yu/Gn1yF5 f/S/fuyniFXz5skJ7sNRm7Ka4KTw+xJNyCQ57fgc4H9ohsQrjs/Mg1fNKFFsrzVFHJny uxOI6wDfY/0Sbc2G7es2XOx0+XXAYY6HPU+k2tJaLvEIqGQlcEawZygu0VNlbzHWZBnO XS8A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=c7DBJJuo; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49597d0a0e4si9121106f8f.268.2026.11.09.07.42.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2026 07:42:44 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=c7DBJJuo; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=1nv0AKxMYVB2plTOcjKYRFjZvIQgzC1Spq+kXDbFhk4=; b=c7DBJJuom0aI CGQES1qxbRuQiVj92DJVE+fioeV/KpK8fKpca4Nwr2fwHvll85EQPACbOqT0EnCXUILnyfJ9SO33M fnpuCpTxr8D5FO4nYIVyaBtwiu2rW3jcgBclByg+0q+rQwZaR4P12S+Rge29OGE5hi5uOA2LeFhmu N0D+K5ce/XqQttYQeZ5EY6mz8ZmZIU2Yqm7EitXjB0Vd1htG6SGg8GFojtz73tNLoU1XM0lVBxQ5G FwKEHLo2EJDHGzJcpqJ1paF3WMWS6alUZWpMKIy9DW4o5Sb9K/eN01emmz/OXd8TtW6AUHN7FyfXK yfna/LOQptlw29m9SUUxyw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xQRS3-007qJT-0u; Mon, 09 Nov 2026 16:42:35 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Alexander Ivanov In-Reply-To: <20261109140143.1408038-10-alexander.ivanov@virtuozzo.com> References: <20261109140143.1408038-1-alexander.ivanov@virtuozzo.com> <20261109140143.1408038-10-alexander.ivanov@virtuozzo.com> Date: Mon, 09 Nov 2026 16:42:38 +0100 Message-Id: <179423895898.3398823.13849183598040694300.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1360; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=t23WVFuzvom/2N+aYiUXECjX0SEe2ZpsjXrSk6Q+Q4c=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq8eny/HDRA5Oq3qwan8oWHnGrYT3iNwbfzqEE0 k0Kg6oiss+JAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavHp8gAKCRBRlgpH+WFc KvRhEAChajKa1N5ptz6O1/ul6myE1h97RZ1JgVl0uD6CmLRErbMLsAP7pmPCTebq/3MfZ+595y4 CrikrlphzOIvbW4WJAFIXTfJ91QBEp8TajhLJVhs3DEkyA7rfHAZzLcyQAQVEjciwosBQnJl6dI TUAjf1hHVgnIGe0qR/qVQsTuxE0xas1PR+5p/MLl0NoQOLLK0yHumGrQgfdbIyl+MYJiAN/LCkB ALBSKG/AXCDYiK5HVmxFELiJnaNk9wS8Ws2NYZiajhyYigbpa/l4DtkS+Km4S4ImTVSCsYjQuVM g7Q5ZDmMwfjGnROLgUnEvBVSEN4bNEt2nipJ1juYKOgDTDrDHyy1t3vYr8J8Wq/iXHneTwTXc+0 vGkayZRitHfjYht1ZLTkk+HBa9wAmKwmNkAKoEshATTzPxrTcXjUfcE7Mki7Ci3UQuFIBJjLoLE fEm5MqY0MIlnlXzZYbLchx4/6bGLTHl+Dtrxda1L/jULxoGqPRXNyqPXZgUrYRMEN+00JpOEQcz qiz/khGJ/0l3i/PEIY7Zcwd9dvMa6yoI3+4WNSc02y+1w89/YKyYyLAQH03U4KFUAjdiw/DDGw1 8iNiup4tlgPnFvGiftunODv9fH6Kih1fKAbr7vl4/yl6Eb/NRp0BbR9AV9AgikRO5O3Wv+T7OBj hykQQsTM8Pfg9Ww== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v11 09/10] dm-qcow2: retry R1/R2 writeback that failed with ENOSPC X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v12 with the changes below. On 11/9/26 15:01, Alexander Ivanov wrote: > A failed R1/R2 writeback sets MD_WRITEBACK_ERROR and drops MD_DIRTY. > which gives the page one more try. A page that still fails then is not > redirtied, so no timer is left armed after the flush, before the image > is freed, and md_writeback_error is set as before. > + /* Retry R1/R2 writeback failed with ENOSPC once, then give up */ Item 3 of the cover letter reply: say "up to two attempts", and that MD_DIRTY is dropped at submit. Why: a page that failed with ENOSPC before the flush is redirtied. Pass 0 fires the timer and writes it, and since md_wb_no_retry is still false there, a second failure redirties it again. Pass 1 writes it once more. MD_DIRTY is cleared in submit_metadata_writeback(), before the write, not by its failure. Item 4 of the cover letter reply: mention the leak per resubmission. Why: with this patch a request whose L2 write fails with ENOSPC ends with BLK_STS_NOSPC and is resubmitted after ENOSPC_TIMEOUT_JI. The L2 entry was reverted to 0, so the resubmitted request allocates a new data cluster, and patch 8 keeps the old one. One sentence in the message is enough; it lasts only as long as the host is out of space. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel