From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 24A00803F6 for ; Tue, 10 Nov 2026 11:44:22 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AABgsxZ014403; Tue, 10 Nov 2026 14:42:55 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AABgsxZ014403 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="gHE1th+d" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AABgr45014399 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 14:42:53 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AABgr45014399 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4a318cd95e8so17172065e9.0 for ; Tue, 10 Nov 2026 03:42:53 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErG30hbMuzw9ootFSO1ep25HKGsgNcNqVHx+IJW5rg/bUgFJHEv04P0NGkvYkc4Gx544U+HLxA==@openvz.org X-Gm-Message-State: APuU4Z9Pxb7cYPLhvcLXpf57YEb60Rpu1Mg8mPfBwPj5Jj0llpJgf1pX eDIqRoLKbeuvQ9xFvLWvi26Fxu8E1XH09l0zYuurN5mMS8unwgV+4w6AZ8fflSi/SrY9Zggz2+y 4j6ra2BDjYXC40PAhxwCd5xnAM05WWnOq8pTqEataNGeNU2XgGFPUdA== X-Gm-Gg: AYBFou1zlDKNiR9LJKWiSdQEBWPj0Ca2Ufo0okWkX8R7RkDe/Ec/VYDuRSZEDha3Rqp FU3V5SczsJKwSHRHRjXJRadLsfeDSrqaiISrMIeyU+Dce5Gn0InVqHEFEHvuCWj07ODhEcsYWpO CfJmBaDf8zbXHSmx4Wnuuf8oQJRx8OONIOnI1B/yEByoFyFkAeCsnodc0ZgPIhqs6XCaow1eFIK Epdt6r8clkXVjPLH7yKeE4otlgWYgWv+/1zixq9oUfrb6IaxevCm/M1XL+i6WDK+7zcDf5Rl2aO obI/RWyC87ptMfcmqhDI/VKtq6JoYCiQDtSGeQW/SQUvdbeEPun/AOJwX2qij+BVo+BaiyOR7/4 TP4tAt6QxoALJbVx17Q== X-Received: by 2002:a7b:c850:0:b0:49e:795e:ba89 with SMTP id 5b1f17b1804b1-4ba01dabb49mr35158135e9.6.1794310972684; Tue, 10 Nov 2026 03:42:52 -0800 (PST) X-Received: by 2002:a7b:c850:0:b0:49e:795e:ba89 with SMTP id 5b1f17b1804b1-4ba01dabb49mr35157745e9.6.1794310972175; Tue, 10 Nov 2026 03:42:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794310972; cv=none; d=google.com; s=arc-20260327; b=q6+wu313ntbHs5OTLsSy6ULgYYs+Drp48Tj6jivFfgoTtrmtBQIsIEzaBhPW49s8+R u8AnlbOc6pwtr+mwLfuqrOmIbBtkXORF7hxEdZBol0eAwDk19WryJzBVf0zBsJKlHupA fes9PkIhV30hoDZuWFogOw0cKdJLgeR7sMt33OOUSUJLxgQoAp5uqnWsGvn+za3fEU32 U6HXNeQpCJJ+WlSDGBKbjfowL3lj2346Lh0Ap4dIZudX3AL+cz2XcsqVbe/KVtIhxmpf pwbuVkTFuWyKyRk1XpgpPGmHko1fSSu4lTYK1XxJHxtZ2esL7Lb9k7XcKV1stxT8CAxZ GK+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=kNt0CPrY9W/25HQVN9VHevg0ySG7bmwZNJ2zW6jZbL4=; fh=AXaEMap9UVXDT/x707nN5u9hAuW2OOlHA2h2MmC//Kg=; b=BEMQaDkmMp5kX7UXDviqoB0uUfxOgtt+1yjoHeSa0NR5/WgnzNVDAKU6jZcMv+LqOu eRjd82uOcbF1yzXsL/lFzQXmmlEzxgzta4zd9hKpbUZkCEESC8HXdPUy6kYjFQoDzSzL 4Rwhe45P4+Ip3tqTiuOnYAQEue5rihikMIJsOvfvsqZ/miehwpZ45XUyn8OQX2ixyLCw uEsrOybgmjYt6MBQwP+QpmVoHAnQFdPbJGuOejiua77Z6wxXh/nT452szDZLiDMHm4xt PSFN9RZ29/oQ3jkET+eJ3B8UK1e63Sgzwv1by/BjGmJ0dMUOW9ZctIbpnf4o7NvcBKGq diSg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=gHE1th+d; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-4983780248bsi4546421f8f.382.2026.11.10.03.42.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 03:42:52 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=gHE1th+d; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=kNt0CPrY9W/25HQVN9VHevg0ySG7bmwZNJ2zW6jZbL4=; b=gHE1th+dynld FFpq1odX5t7a/+RsdX1xvw0h/gc4vsaVSwfjvMLK9TJbX97/isb4BTKbwoXNsLCgaqmOJw3sSGvTz 8lWaPjYDOqla9bWAJVTHGXHsAaTeLAoapR4MylFGRxZtNfUWkwtokLRjXm8IRkgXRJ4wGzy1Z4TSH gPQV2KBJc2P6AWTbUyAIFSx2A9qelmYpLD+d6+knnzg+T1K6bQiXgf2oCNMR7HsZzzWbpSCXpsOqb d3ea+fXgISGxWdyjyV7Mwbng5cTcKs+8vPbVR0/WonhcriEEkM2aECbz63fslS78XegvQezYF6vdr ofcDT2kpNc+Jkvq0LuRz4w==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xQkBR-00D2Eu-2s; Tue, 10 Nov 2026 12:42:42 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Alexander Ivanov In-Reply-To: <20261110075140.1475607-1-alexander.ivanov@virtuozzo.com> References: <20261110075140.1475607-1-alexander.ivanov@virtuozzo.com> Date: Tue, 10 Nov 2026 12:42:47 +0100 Message-Id: <179431096753.3475721.10858383055609540748.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1836; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=uv3tE6Bl61VY0nzTHBelorafj8nthpD+QlIoHFBUbZI=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq8wM707TEX0ToBHuZP1Qa9FANSxZ2UBs2NHPCP GZwlsg7pW2JAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavMDOwAKCRBRlgpH+WFc KqdPEAC5Ndxw1HfX8sneUUBewbkRjz/rqYxJEbvyFW9chwXteku1CDfXcV31mZ6nH3VaGGDGUHC D3ci62fsMCnzyQjlb0MvYji8hkXtVVbZPYAJxXq7/4SgmrxyOsbSds/Neb/inQTsvK6W1ZF2PKb 0lIfEjyDI8nEMHMCAvvprMiAdQteScSHlM7y2SlMtwNqT2gMTMOKdsSbUkRyOenQnzraja9VCVJ 6sK+EugsGT+BjdGMjXDn5leQBulnvTfDXr0aKBvYBzqsuq66gD25c25F8QkMdXW8DSJxZ0VLdLn Kbfp1WXWtLXnsG5RK76s3NM8/AsZHzNxXNAm2TB4C3twLDl7Jukdm9l7PjmCeOIMktGnrzYE0W7 Z3rtQ9Up9txb93Evxblr7oFaoYF1fgivzKjP4Lg8FdJxaFk/2tu3QoKDN3f/5X+8qkqOFRQtQ8f O8I4Zh8ANHGstEF96c2pnMqkG/xsedC+6UvB1jQWUiSO+UYjGMQs1nX2H3W03Be2AoIZcHvJSnr EC2WESuy/6hE7htLfhdVDfVi7YDC0P50Z1or3LEtej2dB9nfXrtklfRgIwi0GchGmKY1eWl1i0V aRm2Eii0dKUnBWkabokfPq2bIiEtrty5IvrHLX3+MqIIWSG8kJ/wz0depZf1OKA7JUB2M+p/zD3 q0IW1dWvWPvh2iw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v12 00/12] dm-qcow2: truncate unused tail of image on suspend X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Applying as is. On 11/10/26 08:51, Alexander Ivanov wrote: > Alexander Ivanov (12): > dm-qcow2: add qcow2_md_page_read_sync() helper > dm-qcow2: drop duplicate prefix from QC_ERR/QC_INFO messages > dm-qcow2: extend the file for a new refblock in allocate_cluster() > dm-qcow2: complete wbd before ending the data qio > dm-qcow2: flush lower md before clearing dirty bit on merge failure > dm-qcow2: keep the dirty bit of an image that needs check > dm-qcow2: flag the image for check if reftable relocation fails late > dm-qcow2: fail the L2 table allocation request on L1 writeback error > dm-qcow2: leak clusters allocated for a failed L1/L2 writeback > dm-qcow2: retry R1/R2 writeback that failed with ENOSPC > dm-qcow2: truncate unused tail of image on suspend > dm-qcow2: fix WARN in qrq_endio() on flush failing with ENOSPC While reviewing v12 we found two older bugs in the L2 writeback revert path. Both are there since the driver was added, and this series does not touch them. Please fix them as separate patches: 1. https://virtuozzo.atlassian.net/browse/VSTOR-154310 On an ext_l2 image a second update of the subcluster bitmap in the same wbd overwrites the saved original in pe_page. If the L2 writeback then fails, the revert leaves entry 0 with allocated bits, and the next write to those subclusters goes into the image header cluster. 2. https://virtuozzo.atlassian.net/browse/VSTOR-154311 On an image without ext_l2, a write to an all-zeroes entry with no host cluster takes no pe_page. If the L2 writeback then fails, the revert clears L2_READS_ALL_ZEROES, and discarded data comes back from the backing image. The scenarios and the proposed fixes are in the tickets. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel