OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1] net/ip6_gre: fix a host panic deleting ip6gre moved into a CT without ipgre
Date: Tue, 10 Nov 2026 16:08:24 +0100	[thread overview]
Message-ID: <179432330471.3516729.1132081928775965334.b4-review@b4> (raw)
In-Reply-To: <20261105141726.2594661-1-den@openvz.org>

Applying with these fixes on my side:
- "ip6gretap and ip6erspan have no ->dellink and are not affected" ->
  "ip6gretap and ip6erspan use the default ->dellink,
  unregister_netdevice_queue(), which does not touch ip6gre_net"
- the Jira URL moved next to the Fixes tag, a blank line before Feature,
  as in the vz commit template

The same dellink bug sits in three more IPv6 tunnel drivers. I filed
them and assigned them to you:
- https://virtuozzo.atlassian.net/browse/VSTOR-154346
  ip6_tunnel: ip6_tnl_dellink()
- https://virtuozzo.atlassian.net/browse/VSTOR-154347
  sit: ipip6_dellink()
- https://virtuozzo.atlassian.net/browse/VSTOR-154348
  ip6_vti: vti6_dellink(), vti6_changelink(), vti6_siocdevprivate();
  ip6_vti0 is not netns_immutable either, mainline d289d5307762 fixes
  that

On 11/5/26 15:17, Denis V. Lunev wrote:
> fb_tunnel_dev comparison keeps its meaning. ip6gretap and ip6erspan have
> no ->dellink and are not affected.

They do have one: __rtnl_link_register() fills an unset ->dellink with
unregister_netdevice_queue(). The conclusion holds, since that default
does not look at ip6gre_net.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  parent reply	other threads:[~2026-11-10 15:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 14:17 Denis V. Lunev
2026-11-05 14:43 ` no-reply
2026-11-10 15:08 ` Konstantin Khorenko [this message]
2026-11-10 15:08 ` Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179432330471.3516729.1132081928775965334.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=devel@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox