OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH vz10] ovl: release the upperdir/workdir in-use locks before the umount sync
Date: Tue, 10 Nov 2026 17:47:40 +0100	[thread overview]
Message-ID: <179432926055.3539827.7961530870143805679.b4-review@b4> (raw)
In-Reply-To: <20261106151641.3980601-1-den@openvz.org>

Applying with these fixes on my side:
- ovl_inuse_unlock_all() moved to the start of ovl_free_fs(), as in the
  version Amir queued
- the commit is now a cherry-pick of that version: "ms/" subject
  prefix, the upstream trailers, and a "cherry picked from" line that
  names overlayfs/vfs.git ovl-fixes, since it is not in Linus' tree yet

On 11/6/26 16:16, Denis V. Lunev wrote:
> --- a/fs/overlayfs/params.c
> +++ b/fs/overlayfs/params.c
> @@ -735,12 +735,9 @@ void ovl_free_fs(struct ovl_fs *ofs)
>  	iput(ofs->workdir_trap);
>  	dput(ofs->whiteout);
>  	dput(ofs->workdir);
> -	if (ofs->workdir_locked)
> -		ovl_inuse_unlock(ofs->workbasedir);
> +	ovl_inuse_unlock_all(ofs);

Moved to the top of the function, so the code matches cb6c084182d4
("ovl: release the upperdir/workdir in-use locks before the umount
sync") in overlayfs/vfs.git ovl-fixes and the next rebase drops our copy
cleanly.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  parent reply	other threads:[~2026-11-10 16:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 15:16 Denis V. Lunev
2026-11-06 15:20 ` no-reply
2026-11-06 18:12 ` Pavel Tikhomirov
2026-11-07 19:32 ` Denis V. Lunev
2026-11-10 16:47 ` Konstantin Khorenko [this message]
2026-11-10 16:47 ` Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179432926055.3539827.7961530870143805679.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=devel@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox