From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 1F2978017D for ; Tue, 10 Nov 2026 17:12:49 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAHBW1X016655; Tue, 10 Nov 2026 20:11:33 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAHBW1X016655 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="P8EdDQvA" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAHBJlT016623 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 20:11:19 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAHBJlT016623 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-490c69dc02bso1904754f8f.1 for ; Tue, 10 Nov 2026 09:11:19 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErGTMLv63PoH7tLVzVHXhE41os/AFesG4jRTijEY9VcsJPVhSKTjI/72APWDkEsDuhAJeqlM+g==@openvz.org X-Gm-Message-State: APuU4Z+CylwRFZsC2SYDsA4ENTkMFNADh5b3IQns4ctTGTia1eBb/m9W qAJjG0a4aYGxK7Y7HPGM2rtzKPyftGzvT/sLAS275Zxwm/Jah0NsQqtVXNeJhKdmkaXBboMvnuI +0+K8J1TrLle4OsUnmUpB2+QZXIGredTYli1VtjJGoRuILKeCN1+8/w== X-Gm-Gg: AYBFou1SKCOZGSxk/NFCSALsDYJRs7WyXMIF3Lf3rJprRNZifFM7yxKXMLXpVAjPHsg 6YP+MY5RgBfFJuamclN3OD7vIm4pgyduUju20mU3plP/YmX1UsguKrzDtI8YurfPjOQf3nhoiYo BaJvNDsCxdioqnYXgmbc5Wx8exRGSABwR2y0ePT3RCOkPlXBKCLPIVuSi7Aqk/M5yKeKQaJ2eVI u3wREYpzaGsP+ovR8c1jPK49CL2kDr4YcaZlZBKIP9HlQVLjkgte6TiG0Q2Zk/MdL6xq5WbJIVR qUnFcAwB5N2wHflYu2Jmb6ZaZnfB6954JNvDgMPjPuCmwBWup5qsaHgsjg1z5aeG2686a8242RD dOL9AG77oUim16eVZ X-Received: by 2002:a05:6000:490f:b0:48e:412:3813 with SMTP id ffacd0b85a97d-4993bdb6c5bmr2095368f8f.20.1794330678807; Tue, 10 Nov 2026 09:11:18 -0800 (PST) X-Received: by 2002:a05:6000:490f:b0:48e:412:3813 with SMTP id ffacd0b85a97d-4993bdb6c5bmr2095303f8f.20.1794330678225; Tue, 10 Nov 2026 09:11:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794330678; cv=none; d=google.com; s=arc-20260327; b=ktawjyNwrcEB/YjsX9TnKKo0maGNsMxJJSCNHcu2fX+abFSmbJssYKjkss7ubYt1+f KGDr4lxs1R98/B02+hSsqGEu/xaN8s1PRAyxl7T8B/1kJEegXvm33vFLXff2te4O7M2b Yy0iFSEcjcALCRcR7JxU/vUAFRGegh8UWNhkMw6qSDyxGgoIaHOqWYtmRJ+f4agbE6hY vHUeABPpI79ZNDnV+byQIgT0Te19PD+5Z12c6o3zQ1wonaX+JQzcZ0JnSRhlzx1PQ7Ln Fx8NnfNC5wjK80MqiGRGTKUUCVMMOaCFBSSC2sB1f37tFM3x8ZSKZN4l7yElK1mL2o6N rNqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=+pArif49SMZ3XCpwHL/qwl4+4fCibiESB46AWFNnBtE=; fh=+5xttkgkwONswRd2Oq13QsL3ym20IqW/INZ9jy2C/wI=; b=GSffmyv4CPVlk9msIwB5MEeJVzQeUTjDEkt1bo6j0BTAq53dJDfzjrPhxtKaXrsn5v LWFaVMyE7fU5s8XNQNcRo7F539Ik8ExYhj3ket4IURrPPdDpgO6u6vUtwG+ApF6mZtk+ 1uVHE+hQW4vteFE+VQTBAy40Rb1eESoaJ7f0k3P1KYFIJe18PXEOaKXpcScmKDJGQvxO dxHggMTic8ZZpTnjqArRtFLn7W4njGa0jX8O9fE2ku5FyMCsNhHZKjm/iaAxy1MWEWvD wHdLo8YWdQIM95i2v/Oi0PytWiS55NCsYWek6ekvnyklsRqRIsGjZ+N2UrPaQHyl5Cem VvEA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=P8EdDQvA; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49832199d6csi6269781f8f.44.2026.11.10.09.11.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 09:11:18 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=P8EdDQvA; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=+pArif49SMZ3XCpwHL/qwl4+4fCibiESB46AWFNnBtE=; b=P8EdDQvAuEsr zNWdXW7J9D12jOpv+cPuNSyIFcM2LCmJq75lxN6GqkI7jwMN9dn+U4BVIp+XlweQz9eCaytdg68BX CfbQIVE6B7gzEWStQy/pxbT1J3BsEbNNSoUpIb99IT1zVV4K7UZT6ELweOsWnMUB90z3S/5WAzaTs eg6NOaJyR50aN6fOI4GNmSD+75Jo/kGuqBJWVdiyqM5I17wSoM5jCE/6TqygaTHRqbUxlYKrvJ/ul ohhRG80SxZUkTY0PCA6W535T/UTCch4yH1nXzJiozkxY2TI22NXx12mk1YXVvBxo8WZnF8LhVeKOM TxKnNQewSC3uGYM06BTu6g==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xQpJH-001jGz-28; Tue, 10 Nov 2026 18:11:07 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: "Denis V. Lunev" In-Reply-To: <20261109190604.1850504-4-den@openvz.org> References: <20261109190604.1850504-1-den@openvz.org> <20261109190604.1850504-4-den@openvz.org> Date: Tue, 10 Nov 2026 18:11:13 +0100 Message-Id: <179433067372.3552165.9282702902538488389.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1342; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=cpsNQe4KQynG8SHhUBBxQTPPmePWFZPiUObhBKi+0Do=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq81A0TxgLtQKWDNnMhDKrOMBVHK+spOsFjC23E NVe3/rIpXmJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavNQNAAKCRBRlgpH+WFc Kss+EAC7JVtqhxLHxXJGTSE7D2lVpheL5tIpCP/5qt1KDpQgxabS4CPHSiMSgybgZH2aFXwY6YS aCMx6d4kUeuF+c+SkgaoapY85/AIEpGUYqcSJrrNdBL88RJ2Q3vyilSWbR/Rz74GSn0NlXetoHr /Kc6HAf1COQHXh6BGJt5jGzMsHVJMkxcjNnIv5DuiBnYm0wGVxjuHhy7PadeWJcyriuzXyqtPmJ RNFMZpNCu4oZT7CPdXHjh9D2GP/B7j5tU0jugxgAu0iS7/7CUlgBhYgmDqoD68/L8qiGx9O/XLE HEpqL4OULCK91HBFT5CsoFPrilBmT+2Mih+DIGe+fwIjpRTHr2vn92LaJQEHO6jQbYvPari4t2A m1tuVRbz85c2Ssz8zlrjTbMEjSI8HXqG/KJd3CqkAKTIIWQGlNUbZ1yMuxBszcVG/fvzBoiPfC6 8Dtlh1OTn1vKqahV4Ljky4Ld9udo05Unllu9hNNU0Mm92oyKycLLkd6O3RbArGUtqYsHGPaFsa4 40DWt7QaNZFgOrK49hKPS4efvazmYR4wswglCPO9qwr48evHxwbmxK8/XcwiflGK/VNUPOHZqdk 8ABCI0Z0KQvNoZLuZdXCTMiywHFRPUIbCHHqP43dzf8OghFqQavfXEEq1lrAzw2QMgHbyynOcjc lf/4fDaNBVvH0gw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 3/3] dm-ploop: fail writes to a read-only device X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Applying with these fixes on my side: - "punches or zeroes it with vfs_fallocate(), which does, and fails with EBADF" -> "punches or zeroes it with vfs_fallocate() inside the file and preallocates space past its end. Both check FMODE_WRITE and fail"; - "Kill write requests" -> "Kill write and discard requests"; - added a paragraph on what users see now: a read-write mount of a partition over a read-only ploop device, and a read-only ext4 mount that has to replay its journal through it, fail with an I/O error instead of changing the image. On Mon, 9 Nov 2026 20:06:04 +0100, Denis V. Lunev wrote: > does not check FMODE_WRITE, so it reaches the image. Allocating a cluster > punches or zeroes it with vfs_fallocate(), which does, and fails with > EBADF, so part of such a write fails with an I/O error and the rest A cluster past the end of the file goes to the preallocation, where do_ftruncate() on the read-only file fails with EINVAL and the write gets EIO after the retries, not EBADF. > Kill write requests of a read-only table in ploop_clone_and_map(), as op_is_write() matches discards too, and both mounts above used to work by writing into the image. Whoever hits such a failed mount now should find the reason in this message. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel