From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id E7D2D803F6 for ; Tue, 10 Nov 2026 17:48:17 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAHl3hQ017676; Tue, 10 Nov 2026 20:47:04 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAHl3hQ017676 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="xhKrvFwM" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAHksQP017656 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 20:46:54 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAHksQP017656 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-49323e268aeso1800201f8f.1 for ; Tue, 10 Nov 2026 09:46:54 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErFKAgH2ThRxpOW4cd4ehoapMvPMJr/l1VmvsxI5txRmXsRFB2J673ilh6sj6ciQPecYElNtMg==@openvz.org X-Gm-Message-State: APuU4Z9Dt6mJ0Ep8gGp/E2STeRGVt5iMVo8d5hgaxQ7jYbwL8yBIRGKt PeqaZwY5HkZstJBhaS3ii1ciZqq5XB02pdVwBZLlgaIdKrM5euHkUNoM8fQsrvgeTgMFHX0yz6M x59ppKHzOBMt0JWfY9HRjdL8ksK2DIRBzrybwh6BD2o9SHWMfVm2zYA== X-Gm-Gg: AYBFou0s7di2WC0ZNRTUEUzq7CdwVpVS3RoTBEOzXS+1gcnPgLEnK7yWFf6k9C3TePH IPxiDlJdNydgMpb8glakV1XQEsn+9drjAAvVRxIQ3iRFfWl/ARCUcY2TFBbHy+DQn42CXKZNoY4 EM5/60DN6tnimW6ItrI2c33R3Wgs9dtJBvAO1EpW/5/GyYgdTJ3yJm29jDXRwuaBJQN8xqPRRD4 Ecrfslr4lg48qNPndSyxSiJb5r0xdDfpYQCqZyK/6VwtZbRWnxdZr3sPwPp8cvzu91dSoQjQnWd TMmsALWqJ8cjWwfiHOUa64tAGF7v/3LvqAIWk5Zp5zrkEW2fQu5RmVfZztqujn9apWgEfqnaE0+ dutin7qUiEcM0ofXk X-Received: by 2002:a05:6000:2612:b0:491:632f:2c8f with SMTP id ffacd0b85a97d-499928ef8e1mr525473f8f.2.1794332814316; Tue, 10 Nov 2026 09:46:54 -0800 (PST) X-Received: by 2002:a05:6000:2612:b0:491:632f:2c8f with SMTP id ffacd0b85a97d-499928ef8e1mr525430f8f.2.1794332813585; Tue, 10 Nov 2026 09:46:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794332813; cv=none; d=google.com; s=arc-20260327; b=hh0lbZcEG0jbvpGNovDZ9guAln/gACTYnoeLuGYAhBjIMAS/WwcI8Iykh/G8A0jXfO Ehk8BvrvAs9OSBeWaSNi1UDiS4FUNNRX5t7dbEQJaKRC1CM4guDwwFE14FYcdZey6A3u SMH+dEGkoDYZj0sndsugkkhGbZ0UAl3OYmILNsgcT1L77zWauWo+v0nuZ/zaSHnkoCr9 IOCxyCQLhmxKw24lseP1qKFmvvcXd2uvbaa+ndwo11dyuXZNGBxdzdQdD1mdWf3IYPkG y1K8Rpr7n6j4LFf7mkHtq6lXLWzGtOSyRX7qwzUNT0v7vH7s2G+hF/7PgB5Asr9Rzv5O 9SmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=wQiI8MeMBQFmwdUAMZ6v2PM6pHutMlZ2PSOsUDAf79I=; fh=NNIHAR0oQq9xcHtG6fvuNrouibWQy9PtHjAIRR7/XzE=; b=rzDjpjayRP1axmZ81v8lbNq+VkpEnbMDaj7Zd0b+qG5kuJ2A/Hac7qWWsJDU0ESqXu CZohB3+X5HGJgZPo53+uXTe2I3QK85F+328MYfh1CyRTUOidVtBoRyAjaWJJb+J07NBX uA5NRe0MJeWpcc981YUN5qAvKMsa6yZnmHiXh8d0F6qyPDKexufdpNBjjsvwsAe9pnpl CBIkwrcFkH3MX0T4dJ6SzTCymc2m0cDbulEAG6ED1IdVKPE9fWUnBFj/c8G6vFWfWiXI B9930skRiqvTAItPY0/QyMy2BWZAnwc1Po65tia1Ua2bQm3sj6VfucvxkeqQYk8n/IlY sOKw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=xhKrvFwM; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49835f17302si5986192f8f.214.2026.11.10.09.46.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 09:46:53 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=xhKrvFwM; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=wQiI8MeMBQFmwdUAMZ6v2PM6pHutMlZ2PSOsUDAf79I=; b=xhKrvFwM2q9S F7EL8FOSTAUmqGIbj5Dovu7JAh55RS7QGN0ABlhZZgf8IlJcl+MH7tEWY9FdNa75DrtxVMWNzeqBf XqeP5OP+RK3bYomu6nRfwtAR6kti8JTUwM+AXlNqzEYoiZbrGzEU+91nZ0S4J3Vr2RQE+h1t9CjfG k191SVEZ7VluVxihTwRBd29Pa/stlyBZ/oa590DPCCQ0Y8YMmVUuzq0ct0ixaP6vcsiofi4m8+UHO Zq2yB+TQu8zoq9jLW05Z2YSPDsikis4Tsx9FjV40mFfLeysF0SSAPn2BwWm5bRVRE5TR3to180F/I LgO4PX875buOPGCanXFhmg==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xQprj-002Q9Y-0V; Tue, 10 Nov 2026 18:46:43 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Andrey Zhadchenko In-Reply-To: <20261109153619.277888-3-andrey.zhadchenko@virtuozzo.com> References: <20261109153619.277888-1-andrey.zhadchenko@virtuozzo.com> <20261109153619.277888-3-andrey.zhadchenko@virtuozzo.com> Date: Tue, 10 Nov 2026 18:46:49 +0100 Message-Id: <179433280956.3561434.18350690260771711057.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1518; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=vgRVj5kVPjERJ4aiBhmoZuEdwnQ8f5TOHUKNC/Poypw=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq81iM7hZBkSL+m5EweJM0flx0y9kB9odcdpdRo F0g/+NnnJGJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavNYjAAKCRBRlgpH+WFc KuB5EACpmt3/WYilg+TV0lGLmY7sgxpM8jae7NlkxE7F8jnbZstFk/OSLCepvsUtbbxDcs96Jel OO6cQ5SaUXFQGyUFOPVEtKVkyNa2KXnQEi86dIOPy1N6dVxnswCJfMBOVM0UiD7hZt+VHM/VNVU LoDZ2ZgQXQt8w5b9fidJP/ONH3m5JyvSyamvWYKtExPdGwFixhS/Ei7heNGvZwaIHHziXP0o0Yb jTOztuXE1L+DOOKqgrHXBrerWb2eT980mzpTYNM2e4OvqhasLQGUBG45Phk1/aNqiKUljEBvbai lOOawN1gq7PMK3FEkhuZ4GuSUYPoCAT86iuyOByDUw7TMQA3qnR533T9MCiCZDgYiXQJhnUdOcd 0PqcVyhnXVjBfi9tF+ypvPqo8pbHIS1OIenutpqzicdo5eYqQIwm5bM+biXfWlRBVUpuLzg2R5F 9pm4dtDb3Yzs4wlO7ksNaP6oQr8Yo83uV5iaejRJ71yhsS3uRkV2gYscQskI52RP61DY6fvP7Vn TBk5NeyA7YNwIzXCWdGZht9L/JpWLjEKub+03a4WHCx9xPbnQtqPAYZIPchEKb6fUVmX0BV0K+P nfz3EDsPTED2HpscsQ1a5K+4QQJhTMidkl8NKdSaYXZrLIMdage5RZ0B1+Y3zKU3G+bbbSfvgA1 5k7z1ZYSVU9fwIQ== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 2/2] dm-ploop: set max discard segments to one X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Applying with these fixes on my side: - the example: a whole 1M cluster [0, 2048) built from bios [0, 1024) and [2048, 3072), instead of [0, 512) and [1024, 1536) - "range in the file" -> "range of the device", "always" dropped - added why the limit is USHRT_MAX and what the user sees, split into paragraphs On Mon, 09 Nov 2026 18:36:19 +0300, Andrey Zhadchenko wrote: > Imagine we have a request with starting sector 0 and length 1024, > so read or write means [0, 1024) range in the file. For discard this > request can have 2 bios [0, 512) and [1024, 1536), but we always > discarded [0, 1024). ploop_handle_discard_pio() ignores a discard that is not a whole cluster, so with the default 1M cluster this request discards nothing. Data is lost only when a gapped request adds up to a whole cluster. The message now reads: Discard is a special type of request that can have non-contiguous bios: dm-ploop keeps the dm stacking default max_discard_segments = USHRT_MAX, so the block layer merges discard bios with gaps. Imagine we have 1M clusters and a request with starting sector 0 and length 2048 sectors, so read or write means the [0, 2048) range of the device. For discard this request can have 2 bios [0, 1024) and [2048, 3072), but we discarded the whole cluster [0, 2048). Data in sectors 1024-2047 reads back as zeroes. Set max_discard_segments to 1 to avoid such merges. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel