OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v2 0/7] dm-qcow2: per-qio fast path
Date: Tue, 10 Nov 2026 18:56:36 +0100	[thread overview]
Message-ID: <179433339615.3573054.6008120892143626996.b4-review@b4> (raw)
In-Reply-To: <20261110114629.416695-1-andrey.zhadchenko@virtuozzo.com>

I won't apply this version, please send v3 with the changes below.

On Tue, 10 Nov 2026 14:46:22 +0300, Andrey Zhadchenko wrote:
> Andrey Zhadchenko (7):
>   dm-qcow2: repeat md page lookup if it was inserted in parallel
>   dm-qcow2: wait for L2 writeback in perform_rw_mapped()
>   dm-qcow2: prepare process_one_qio() for fastpath
>   dm-qcow2: add per-qio work infrastructure
>   dm-qcow2: implement per-qio fast processing
>   dm-qcow2: process fast path qios in per-cpu batches on a workqueue
>   dm-qcow2: declare DM_TARGET_NOWAIT

All v1 items are done, and the DIRTY -> WRITEBACK race is closed.
What to change for v3:

1. Patch 2, code and commit message: in perform_rw_mapped(), under the
   lock it already takes, check that the L2 entry (and the ext_l2
   word) is still what parse_l2() saw and that the index is not
   locked; if not, hand the qio back to main kwork. In the message,
   "X freed" becomes "X leaked", and md->wbd is dropped not only by
   main kwork.

2. New patch: a writable module parameter (0644, on by default) that
   turns the fast path off. Check it with READ_ONCE() in qio_try_fast()
   and send every split to the deferred list when it is off.

3. Patch 5 and the cover letter: describe the window between the fast
   path parse and the data submit, where main kwork can discard, free
   and reuse the cluster, as a known limitation fixed by a follow-up
   series, and name its Jira issue. In patch 5, reword the line that
   starts with "From here on": it got mbox-escaped to ">From".

4. Answer Sashiko's open remarks: patch 1 (unbounded retry, the third
   time now; a bound of one retry is enough), patch 4 (qio_pool
   hold-and-wait) and patch 6 (preparation sleeps too).

Separate patches, not needed for v3:

1. Writes and reads racing with a discard of the same cluster:
   per-md write counters or discard locking, as you planned.

Details are in the replies to the patches.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

      parent reply	other threads:[~2026-11-10 17:57 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 11:46 Andrey Zhadchenko
2026-11-10 11:46 ` [Devel] [PATCH hci-8.1 v2 1/7] dm-qcow2: repeat md page lookup if it was inserted in parallel Andrey Zhadchenko
2026-11-10 11:55   ` no-reply
2026-11-10 17:56   ` Konstantin Khorenko
2026-11-10 11:46 ` [Devel] [PATCH hci-8.1 v2 2/7] dm-qcow2: wait for L2 writeback in perform_rw_mapped() Andrey Zhadchenko
2026-11-10 11:56   ` no-reply
2026-11-10 17:56   ` Konstantin Khorenko
2026-11-10 11:46 ` [Devel] [PATCH hci-8.1 v2 3/7] dm-qcow2: prepare process_one_qio() for fastpath Andrey Zhadchenko
2026-11-10 11:59   ` no-reply
2026-11-10 13:50     ` Andrey Zhadchenko
2026-11-10 17:56   ` Konstantin Khorenko
2026-11-11 14:36   ` Alexander Ivanov
2026-11-10 11:46 ` [Devel] [PATCH hci-8.1 v2 4/7] dm-qcow2: add per-qio work infrastructure Andrey Zhadchenko
2026-11-10 12:02   ` no-reply
2026-11-11 15:34     ` Andrey Zhadchenko
2026-11-10 17:56   ` Konstantin Khorenko
2026-11-10 11:46 ` [Devel] [PATCH hci-8.1 v2 5/7] dm-qcow2: implement per-qio fast processing Andrey Zhadchenko
2026-11-10 12:08   ` no-reply
2026-11-10 17:56   ` Konstantin Khorenko
2026-11-10 11:46 ` [Devel] [PATCH hci-8.1 v2 6/7] dm-qcow2: process fast path qios in per-cpu batches on a workqueue Andrey Zhadchenko
2026-11-10 12:06   ` no-reply
2026-11-10 17:56   ` Konstantin Khorenko
2026-11-11 15:00   ` Alexander Ivanov
2026-11-10 11:46 ` [Devel] [PATCH hci-8.1 v2 7/7] dm-qcow2: declare DM_TARGET_NOWAIT Andrey Zhadchenko
2026-11-10 12:06   ` no-reply
2026-11-10 17:56 ` Konstantin Khorenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179433339615.3573054.6008120892143626996.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=andrey.zhadchenko@virtuozzo.com \
    --cc=devel@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox