From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id BF2DD803BB for ; Tue, 10 Nov 2026 17:58:01 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAHunP2017848; Tue, 10 Nov 2026 20:56:49 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAHunP2017848 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="Q0ufuypa" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAHufIN017810 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 20:56:41 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAHufIN017810 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-4930269afdcso1698952f8f.2 for ; Tue, 10 Nov 2026 09:56:41 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErHOivtJtA8OMe8zd1OiLT5w+GwaNnoRxSJMUjqkG+B6QClUcJuec+Q/8c3KnsLSxll4/BlMUg==@openvz.org X-Gm-Message-State: APuU4Z+Z45hCOE1fhxi9wjAXo1iPj3pNrhinuyj9LE6uOBfxijMpImbB uyogEZpZE+lyNJTS/J4sdsX86utlKtprbxlR5+4HJPUONblo1t5QvxPe+HMELBSmPMkegYZZoHN LuEDPyqoZqav8eAYHf6B33Ahlw8j/8sGZjR4lEgEmH3frR9FCDhS+ag== X-Gm-Gg: AYBFou09PF8B8J4QNAKidNB9b8ON4FuE8fFH2NcyNfXIBo2WOBXBAj+qxTwM69dJa8l niZpA90qk+UBkBc0cV7+1BDYSJ57y0Er30iEwtepyLXGakHazgTS1pskkKl73MkDD8BzKHHSqzN 7Z4ZxKH/3rScJ6zZwcVlPQUYB7wRFgLKOhV8YZe7gir8pEYNBTac80haaFCgbOa/faFGdLMLOSq KIcfvAaAT49+m8S9hlyJyYvHW/fDolB7PIExjdInUUUWKE4au8/314HgpY/fBTDMOCFNJ8J7Z5P S2mD7JfvGzXhJeBtGhEm+8BM3Jdrk5U6u2s0TZ8b3Y7s+g+oXay+FmQd2Sy8UQCiSyb5QN516H3 oLDLpG5640+BYslJ9rg== X-Received: by 2002:a05:6000:144e:b0:48b:69d4:bb35 with SMTP id ffacd0b85a97d-4982e82c12amr6910022f8f.12.1794333401607; Tue, 10 Nov 2026 09:56:41 -0800 (PST) X-Received: by 2002:a05:6000:144e:b0:48b:69d4:bb35 with SMTP id ffacd0b85a97d-4982e82c12amr6909989f8f.12.1794333401161; Tue, 10 Nov 2026 09:56:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794333401; cv=none; d=google.com; s=arc-20260327; b=mmCyWzLi+GuMjL3EsZaqvTdpJ5aBHTlT7p9iIiDLNzhlIEo8PCTBblJZoizkkWKRzn s/ZSaijZE6jjMGgYXW44fhQWT58jCjQDwV/4GzazTb5zGHK5u4k+jrEL95FOZXMZD8RD mHQI/VxJfLLYN6E7iXy9c+08gpl7+9bm8LfwAb0hmNfLXeLd05o4hp84YsM1crxkIpL9 v4pK2OnRpjh/vEJ53MPsZlmLFgxmOJt3MRPS/by2lxP18x6tOIJUJv48g8CgfXpZtqQ2 oMCDAzcq5OHk8OVadKKKREOKVPM/0Cji3tvkWICv4sd6Z4c+AGbUWhT9QIaskwzQJ6nX PpUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=CAx/J21fS6go7xQyo6Od7dNFDA4KIdBY8oqM7X8ut3M=; fh=NNIHAR0oQq9xcHtG6fvuNrouibWQy9PtHjAIRR7/XzE=; b=Xp0Ae6CS8ppnPUUhkF4SvSS2FXVtC60+l7fIiW/Xjmgr4OovVptFgR6DptTroXQ+C4 WzPgDpF63DW0RCT9cW1G2sfEJHOPZfAC0g3XoHj4De6Dzijpq1/vJzHByeK3vXDpN1XZ +sZ3Z1CUAsFT5g66FJm8L2teGRrQ8w4ws9N/RAEU24XoyEXwUecits4C5J7YZ6urCO9K PuWhWaRs4aiRESsR+hs9jrpi/WZwHWJlryVSP0h05tFFkWnOzWtZkG+nK2I4KLRPwShf x1N4LVNtPy/12oUEczjnqZKV82Hi+NjIYe47QEXQHeaEYayCFtvv9dP/8GlPBU2Ho7lI Lkpw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=Q0ufuypa; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49832199b30si6152735f8f.7.2026.11.10.09.56.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 09:56:41 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=Q0ufuypa; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=CAx/J21fS6go7xQyo6Od7dNFDA4KIdBY8oqM7X8ut3M=; b=Q0ufuypaCUoq mYAHVGIYmgxmW4PPzH/loSC2os5k8DNGAmOAJ8lEZEjjnRvz4eZqsevmpPdr7ubewSs1xwA0jCq1l k7ewHPwRUvN6FqjlLNgg+3ecGhHP1d71K2qawjA3bKLssh2nVHjo5RzxB/QHNvNZM4b9mobHX8G3D deCCApw2NIZ4P7xBxz/YwQ2cn7ed+XwCGXRra44M5S0HLJFYOQ7BNrRI7OUlaTyCK5rV0dv1tH4nd LMFOrNKdj2G2zRkXz3k8Qdo589U/VWJeUY0kDtmba18gI834sBfrUOYSRWDCd2Xr8FtCloyJiAHO2 9yRZ2g6b976XAd4G3Tx8Gg==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xQq1C-002c2t-2Q; Tue, 10 Nov 2026 18:56:30 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Andrey Zhadchenko In-Reply-To: <20261110114629.416695-3-andrey.zhadchenko@virtuozzo.com> References: <20261110114629.416695-1-andrey.zhadchenko@virtuozzo.com> <20261110114629.416695-3-andrey.zhadchenko@virtuozzo.com> Date: Tue, 10 Nov 2026 18:56:36 +0100 Message-Id: <179433339615.3573054.6734068680199561725.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1491; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=2iEWBBsqgpFg9LukFXsMnkkffcARCMwfKWumG6FTwkk=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq81rW+xU4cP3t06o3ENMknFWDLrXR99/JeXwdT 1rU8DYdxWiJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavNa1gAKCRBRlgpH+WFc KvPQD/47Bc2AN2NsHoQTCLD495HMZTSf+Lki+FbkDOSmss/K6WKydK4U9J3eOggXTZD2ZFh/z0t +B3yQD0Np3AjOjgKrmEe20viEIMRO80HvTrwZYYa487NGDMc60JmrfHrUuWvfpeiRl1DCR+v6cL OJe5dTkzWrh/AxQU+dAF+/Yii4DL/g0gMdxBwYfT2GqbYebPpD2FznidpJVUpmVoM99XmbsbhuG z/RPX+3I1JdlcS2RECZDUGGRYQyMYvwm5vTTtulGu+jsjr3ZZ+jrKayAfV/OeqcblRDV4DQKzps 9kABBYk77UAd+uWJjJrUAYLxPJrAS0/aptkLJn9qFrWeZrqlzNWBZrhW9gvM5/zNcMPxn/VrOe4 Il0Dhz3I9RXxmQJW73z5zNTMvnoqgydx+klR959scPvKZauo78oOpq/53OMtYDa5D/x/rmhbaSU ootZbpEQQlCA76oDTkxxoHEi7YIBIq1b+LVd9XK+B1yQlrGZZI7Zq2nBA+j4m6bVNkGTOnjbsI6 76boknQ7A4/Z+gQxAu4ZfbeudVJ0TWYuRzVPJhWXDiNq8edEp5vhAQmh1eJorqouSntEJGCym5q 5xXqPYUAaDiWopFJcinQfgmLA1UEEqaKnguygZ31h0ot5b7B0EWnYSbnterS4Wtvpaxh6QBKevi qbOpYeYiYKQzNGw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 2/7] dm-qcow2: wait for L2 writeback in perform_rw_mapped() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v3 with the changes below. On Tue, 10 Nov 2026 14:46:24 +0300, Andrey Zhadchenko wrote: > + if (__delay_if_writeback(qcow2, md, index_in_page, &qio, false)) { > + spin_unlock_irqrestore(&qcow2->md_pages_lock, flags); > + return; > + } Item 1 of the cover letter reply: under this lock also check that the L2 entry (and the ext_l2 word) is what parse_l2() saw and that the index is not locked; if not, hand the qio back to main kwork. Why: a failed L2 writeback can complete before the fast worker gets here. complete_wbd() then reverts the entry and clears both MD_WRITEBACK and md->wbd, so this code sees neither DIRTY nor WRITEBACK. The write goes to X untracked and is acked, while X is no longer mapped: the data is lost. In main kwork the write was attached to the wbd in the same pass and got the error. The same recheck also catches a discard that has already changed the entry (item 3). > acked and flushed. If the L2 write fails instead, the entry is > reverted and X freed while the write already returned success. Item 1 of the cover letter reply: "X freed" becomes "X leaked". Why: complete_wbd() clears FREE_ALLOCATED_CLU of the allocating qio, so X stays allocated and unmapped. That wording came from my v1 reply, sorry. Also, md->wbd is dropped in complete_wbd() from the fsync work, not only by main kwork as the first paragraph says. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel