From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 18E3C8017D for ; Tue, 10 Nov 2026 17:58:12 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAHuxlf017879; Tue, 10 Nov 2026 20:56:59 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAHuxlf017879 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="eHPFJuvO" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAHug83017828 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 20:56:42 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAHug83017828 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-4930269afdcso1698961f8f.2 for ; Tue, 10 Nov 2026 09:56:42 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErE4p+XmIG6B0V3YLP2S/g4v1ZED8hr6Ci1im6VfY0/QiFMbaw1AOTKVWmVQfGV1KG5KrBL3AA==@openvz.org X-Gm-Message-State: APuU4Z+zozmxFM7K2BL4GxFEthhVdIcgkQGuK+6vriLlpWjwDVP/BhBQ oRWGhXooeF4RHCmKlSFSsp0MswA4rQM6n/kWOrQ0MZRcGF/k/e9+Y5Wg5zQfd06cHHzu2eGWm35 bY6ipNqJRo0YLFVGNZv5lSJrr1zQ8mUV1qRaPkaOQJ8TTcFyXK72IDw== X-Gm-Gg: AYBFou0l9b8Sf0gqR759drmal7A1TjWlzvvQjYnufUoHSt/fFI/2y3pfI+DJZ9BnUew 1XfKfCaX+hvPUZBDUmnX+mAphMAOWrt6lR3NJhW71vfWtCjeJOLSPNCjab2ro3H9fFN2LOl55RT ODaGByoDWp6BCgN3+iEHy1jTtsLhGLw/9tB4LTKTB8KEgYTleEAEErNpc8oEeov6rIsHREuxrHg j9gwZ9WBMp0YuSxeSdsnTyWWJ4ffInoWeJFAL1mMjhD+ByT7KrPR8vTlcsaSOOVUs6vl3ca5qdm yVRxCg8OWia0ixhlekjhocr4wzv6FtKhyO3yiPk4R19v/cR1j4iQRfjUu5FC6KE+ULGi96toSQy HxuGOfJEAjXU6OQp1 X-Received: by 2002:a05:6000:25e9:b0:493:59c9:ebcf with SMTP id ffacd0b85a97d-49831432d19mr6040735f8f.57.1794333402454; Tue, 10 Nov 2026 09:56:42 -0800 (PST) X-Received: by 2002:a05:6000:25e9:b0:493:59c9:ebcf with SMTP id ffacd0b85a97d-49831432d19mr6040702f8f.57.1794333401953; Tue, 10 Nov 2026 09:56:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794333401; cv=none; d=google.com; s=arc-20260327; b=q77QjbQJMCQ/oM1NalKdY3ZQsVuq9P6nLMRZRK8El0cVPsARFSj2N150p9rWse+9tE R08QxmusNuztA3cOCEX2F9IQ49ffl9EdvDT+9ZR0KX4QBNUMILkU1ryv8h+g3VwnxYSN N4k0E+LLpMMKwAc8BHW94V5Pddfy+M6fBwevaCAB6pX91idSLt/i3Im0DWgBbZ5lfGsd PI9ksOaEH8C+QEOcb55tJEPjUf4DKLoO/5qV+Rwj61d5U1X7TxrCXb0cVkxyU+HsYZGG l/z8MbfB0GcddpmLceluV7RakVMx7ZxFiXM/14U5mZFQL8z3RAhOlX7cghJ7ZZ6AfZuu 1/eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=ZRwV6fghMoQJ66+bim2XerMWLErou2eIU9Jzb/Ffqy4=; fh=NNIHAR0oQq9xcHtG6fvuNrouibWQy9PtHjAIRR7/XzE=; b=icwCaKC59vVKUi26XsfDj5yXNWOClt6o60GkDuLFymlUEUXOWTnOY3+Z48n3TlgtA5 0RXuQEbdNZ/Rw7VN8E/DI5vHDfSgyFk3vEa8hnlYkmedROzs4XEtKPaZSOc06AF9Ppo/ Vk39MeXxOyRdzRfF0OYkyjRDLuEKPE0nwmVMcshLtp11Zu1tK4vnF5yl2bg6lCJuSPlM aWKV+7b0dDWm81DBnCt7JGGuWYAYfdVTCvWvznqCVUBd/WSklxIIyHAPJaKZg+Y1hzj4 15yscotTV2r147WYDpMSU8TpNf8+hlZCMSGw/V2yKpmjPvKGFJBXzRaNO2AL8FymAhcp 08hA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=eHPFJuvO; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49836d78c93si6740492f8f.299.2026.11.10.09.56.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 09:56:41 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=eHPFJuvO; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=ZRwV6fghMoQJ66+bim2XerMWLErou2eIU9Jzb/Ffqy4=; b=eHPFJuvO0rU5 fn57AeCQPaLXZ/H51KeRpTpFPGc3hx0XkHMayOi/YHEC4/gp68k/7hGG8nyV/Sg8+4SQBMkh7UbRA dNBpZd7sQgFewwgVpwzkvuGlHmwGl75TWSPIBJK91V1HDx6txmaYOWT4EWJqQx2fFZmDYcpN9YYii 9w0g+NWdoKlwHqrmf0A42/puZw8ISfUmYH3keAX14NE0IaUX59pBLD0Lf4FbZMSBpQgCU+bvxctHm uAPIse8kaO5FPnIB0c0tcubmN5JvLDFu1xLYuRi1EWRC9quuDsevqQoeNl/hIuLJX9AKP9b2417Gk Q8r0kMgtslvssaAnIcmbAw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xQq1D-002c2t-1f; Tue, 10 Nov 2026 18:56:31 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Andrey Zhadchenko In-Reply-To: <20261110114629.416695-7-andrey.zhadchenko@virtuozzo.com> References: <20261110114629.416695-1-andrey.zhadchenko@virtuozzo.com> <20261110114629.416695-7-andrey.zhadchenko@virtuozzo.com> Date: Tue, 10 Nov 2026 18:56:36 +0100 Message-Id: <179433339616.3573054.17156748575853494898.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=790; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=00YA78bXKrA8uCbmDTEe5AfjKO2qjR5NZJA+7uZiYMI=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq81rXz+Zr6xJw49oUYnDl4OiAwKI4rcaak0b63 gHKQgPWahKJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavNa1wAKCRBRlgpH+WFc KrxSD/97JM3AZCY24ECTUSEHfLcCDVzvaXx2trgvSb4eppOonG+xZvqDkuX+QQrnfYTcBWarty3 j+uIaJmfewvCbqPw6JsTvZVe65gs3k2AWwWu9xvpoKN++VxrBoiRxk0RVkEb8K5TJ1qLz0Dxpvu wRzGgregM3rjL734EBTb4ipojjzRAA8i1F9c43j3Ns99ix7pIhSA2Lik5U6l8YMiRuXudUTig4+ qQIn7V0pRDTergpoSc4wFg934w7LYuW4vZK6oGAPnBYeZt6dU1pRcwWHkseOygsCam9HwmP6fwX KGCbAmEab3QxX+eOMf0CplbIEsUbU96EOkfXpAUeE/HhrgSzXL8TXVeOceMcR40sTNBou46Yycf 8nlei7PcH8UTqhSlJeXSPq8NeUZ1M+BiQst07MBIyWC0MCg8ZpgGUgT2gABZmZi8Ul7lJLm2bit cNsSNY5qC/0Zn2yYd+OiWkilOqqJpOov1cebshbms9CE196rvx+HramU2YjoR8+obD1/t6dK6B2 GY0Zy3vbldTKZxxw9LfPdSTFDJc70388+UyZsj6YdZtDoxHNgsujl+FhcKwNSf5GljvLTPQ8hln TPQU1WUA0iABXGLYWDf0lf7YxZFW8OpdufBnUsc2zmilAIxFGbtv1YleZAFdyeLc2XIhZNJb0Md kwmPuVs7IUtH8DA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 6/7] dm-qcow2: process fast path qios in per-cpu batches on a workqueue X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v3 with the changes below. On Tue, 10 Nov 2026 14:46:28 +0300, Andrey Zhadchenko wrote: > CPUs are still processed in parallel. This is fine, since a fast path > qio is only mapped and submitted as direct AIO: O_DIRECT is enforced > for every delta. The exception is a partial discard, which punches Item 4 of the cover letter reply: answer Sashiko's remark that preparation sleeps too, or add it here. Why: before the qio is mapped, prepare_one_embedded_qio() allocates the bvec array with kvmalloc_array(GFP_NOIO) and the splits with mempool_alloc(), and both sleep under memory pressure. Everything queued after it on that CPU waits. The batching code itself is correct. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel