OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1] selftests/cgroup: Pin the hogs of test_cpucg_weight_overprovisioned
Date: Thu, 12 Nov 2026 12:49:02 +0100	[thread overview]
Message-ID: <179448414276.4060562.1522731532077557261.b4-review@b4> (raw)
In-Reply-To: <20261112042325.399633-1-eva.kurchatova@virtuozzo.com>

Applying with these fixes on my side:
- subject: "Pin the hogs" -> "pin the hogs", lowercase after the
  prefix.

Asks, not needed for this patch:
- Send it to mainline too, see the task below.
- Say whether test_cpucg_nested_weight_overprovisioned passes on the
  same NUMA host; if it does not, pin its hogs in a separate patch.

On Thu, 12 Nov 2026 06:23:20 +0200, Eva Kurchatova wrote:
> Pin the hogs of each cgroup one per CPU: the test checks the weights,
> not the load balancer.

This needs to go to mainline too, I created a task for that:
https://virtuozzo.atlassian.net/browse/VSTOR-154829

Mainline v7.4-rc1 has the same unpinned hog_cpus_timed(), so the test
fails there on the same hosts. For the mainline version, take Sashiko's
pthread_attr_destroy() remark: init the attr only when pinning, pass
NULL otherwise and destroy it after the loop. Upstream reviewers will
ask for it.

> -	return weight_hog_ncpus(child, get_nprocs());
> +	return weight_hog_ncpus(child, get_nprocs(), true);

run_cpucg_nested_weight_test() with overprovisioned set starts
get_nprocs() unpinned hogs in each of its three leaves through the same
hog_cpus_timed(), so the reasoning of this patch applies to it as well.
Its tolerance is wider in practice, which may be why it has not failed
yet. ".pin = overprovisioned" in its param would cover it; the
underprovisioned cases must stay unpinned, or all hogs land on the
first CPUs of the mask.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  parent reply	other threads:[~2026-11-12 11:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12  4:23 Eva Kurchatova
2026-11-12  4:27 ` no-reply
2026-11-12 11:49 ` Konstantin Khorenko [this message]
2026-11-12 11:49 ` Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179448414276.4060562.1522731532077557261.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=eva.kurchatova@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox