From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id A1D048017D for ; Thu, 12 Nov 2026 12:09:21 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACC83tJ008861; Thu, 12 Nov 2026 15:08:04 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACC83tJ008861 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="g9Z6EoM+" Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACC7oI5008822 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 15:07:50 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACC7oI5008822 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4b8b3cd61a5so4408235e9.1 for ; Thu, 12 Nov 2026 04:07:50 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErH0mirs+IX/2p7eulmW2Sw9usYAYfkEhwfcMEOK1YXVICQpe3tJf8Z7PL33ycvLErm/Vf6A8w==@openvz.org X-Gm-Message-State: APuU4Z96EEGw91yPVLbs5tDkxNN5wG/0iJEIs2zKcZruXJhHsyHQHId1 QE5cPZtmmBmHUabnKwcqUwco51dWtVHwnVxcOdWQHZQn7rt5o17t7FNgggAlfoXM9qO+1bJ7W4e Eza8lbvCAnAj9Io4ViA+JGP6vsT/aCXHYmiFfpJnzgVECLNScnnyX9g== X-Gm-Gg: AYBFou31AdvOHWL6+tyh1na3hv9HaW6CST3phj8hfPWAopEW4nrjwxu4l4UbVQ/8zfv w1xmDopvZK0jPC/e9AucVUXTTMcWy6K4fwWdWi+GuunXs5fL78DofBhJAYf6KHmOTfatVo5JRaI dvOTI9/C+Qce+5QmBUIVNvXsAttZ58FC1mA8+rFuWp7b8d4NLgZ+nfkl9NQvorUOtESaZJEHtiw nhjwikqzrARqQeWLP7qu0sfC8hbJi2ikY/erRS2BtKzXNUKQ/xPA/p3oRiQt6zfgCw04NvXQ1To pMDlvuMaQQ9KmJ1rdKWBtXgAzBRlED0qkxS4u/PYo3FvXMfYr8gncj6f1kGrt8e5WyfpZHKthkJ Da24h26tyM2S5dBIe X-Received: by 2002:a05:600c:a217:b0:4b7:6b05:acbd with SMTP id 5b1f17b1804b1-4bb4e2df944mr33265305e9.8.1794485269787; Thu, 12 Nov 2026 04:07:49 -0800 (PST) X-Received: by 2002:a05:600c:a217:b0:4b7:6b05:acbd with SMTP id 5b1f17b1804b1-4bb4e2df944mr33264835e9.8.1794485269214; Thu, 12 Nov 2026 04:07:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794485269; cv=none; d=google.com; s=arc-20260327; b=I2mjOvgmn3kYJbQeCM+sIxsGuz34fAbYYOh79OoBbRdW9y49qpCjcgF1lGtILYFO7K dMaO3Qi5dMDsAe91bOys5ohFC4s+0JKVZjp6A4UPApw1ySubLWVT16TtQPfniScwp0ig pekyLctaQ9rj/Fvf3BpcfosITq2jIN2IshIKbIk+SBA+XfULnXmq7EnnZ9fRXM0niehE 7ipa0ZAEnTDwZV+Xlr8p/P14cnUTgLxlWX91cezdByZWaw2gu1Bizijpmufl/DTwujlB pfen6gUSEVkQyYjvKzeYEqRHkm3U6BPNL2hG2nbghcWGIHUOtyQGzwlgG7ZyYsJXq941 Kg0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=SPXKk7YRtiHNCPXieJwV4nhHF2/oP3Z91JyMu+IFeqo=; fh=8+L1GLzK3OTQKnTfH5/my9NmwzU+1/k679YBeB1tMzs=; b=QMhR8eRRBMfg9nWKIb8oRshKMsx0VvxAsCEwxVsb7/qLsf2sBCI/ffI/3miPm8Esyo zrRy1DUdgwCBo78usVcNik2hj/YvbCM+bWQqvoyf8ZKdwYztUq/VMre/QDwGfweT6huQ eRJxU1HeTWHhsbGA9pHju8eKvFqFVzdm4iAZqP+SqJD3QknalM+vUVJV9BRJzr+suBKt UjkxC0B2+ZA+4TbM0YE0NPM6Epy22SM8hA1F9ZohrNfCBVEJ4lEtNBnYsKvnkE2I3Wlf IKeVV5xlY3NH7axBdcwBuaQNhQvtYDIkklVjsbb1MZ3ULM/ZSn13BLui4j8Uk6pWnGuP GjpA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=g9Z6EoM+; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-4983585dc86si16464634f8f.95.2026.11.12.04.07.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 04:07:49 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=g9Z6EoM+; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=SPXKk7YRtiHNCPXieJwV4nhHF2/oP3Z91JyMu+IFeqo=; b=g9Z6EoM+myhd D6REKpj+KeKH0f4IyXaYFwpiDBI33JI0sPosIPigb9X8QothsRpGVf7tI93oiK5MKsWMAJ2gk6wFB l8yXav0s4lInhb6ekhJNkbv3e83EGksDdJ92eKXQQKRKL24cLoAbyXeoU+Ja3atnxrhWlg8BT+GsC 1Mc6KI1nKZ4B6THxNWd9hkWiZckqwj1G6d8UMhgOxDOL/Qf+NGk85yJPKi2TLKqhCCL+JVntuIprU BqnCvVZ2Llr8xLOVW+tUNB88gwhjjg5ONNM09G4LbYjiQe6rhoVAuIu7ED9xlwrvwKkNUcSySaWuv zNTeLww2MKl9JqJvI+1FwQ==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRTWd-00FyT8-1e; Thu, 12 Nov 2026 13:07:46 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: "Denis V. Lunev" In-Reply-To: <20261111113135.4023555-1-den@openvz.org> References: <20261111113135.4023555-1-den@openvz.org> Date: Thu, 12 Nov 2026 13:07:44 +0100 Message-Id: <179448526421.4060562.948782930462115219.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1893; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=Ixw2X3TaQezF8MkSF4o1/E65atmdsQdThc/f9AHcqlE=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq9awSMN5lFhB1KOc6XRb8YOuZmI7dxt2GpTFYt o3yA8Xj6yqJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavWsEgAKCRBRlgpH+WFc Kuv0EACCmIuT7wmkLF2OECG2W+OsQ02vSinJLbm9VjVScjAsSq+txG4Snqryy3ahZjnpPUrS9NE QUyZ0S+Sug9IMyRUL6v5rfeA4QwtNCXH6yrpuQRratJZNJyXXkNVN7uuTAUgN8iV+cl8b/1+3Mc h51bYk4wzJeyNGPaXr76fgT9kOEWavzKJWwAwgi8YyELGHT1Uuj9MCXWPhJ4dk5LRINaIuuAtSL EAu6BSb5JkrTpp0S5HlUIkaNTbLlsNIVjm67CB7eQgPjOuKS8elOfmVC9au1+fWSeGKRFFfAdHc bZPWa/qO/P7RY7PuAh7icmJr5qO20VkqOnwUA5i/WjJ+C6W7FaJZzwlZiCc80p8HUxADfWrZ/vd Sjpg7LSuIKkoV6lh1sw64Z+Abug1H5OEL5/GaXAQrCTgRf62l6jsJDkwWT92MgoLhKO92cdYDQs eHsDolfKxO3xZsxkPIAGBy+RDikB80NClGOlAchn6VaakZ42gxVyEeYaypcZKHswXNHbpH8nttk D85jsPIOjWkrJ3LEBjpdvOad/jZCAz1TEqgRzNlAF7O9fnrw/hgk2nKFgTPZYAf79gWanub0Ae0 yuuCT3w3nVi+pguDDu/obsyWoykw5XGQaV4epdfTSwCflsTC44+guWGui6Z2a0+OVu7k4C8OBsQ RerCpBVN4NOXOBQ== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v3 0/5] ext4, xfs: discard the balloon on FITRIM X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Applying with these fixes on my side: - 3/5: added Fixes: 3681ad22775c ("xfs: Teach the fs where the balloon inode is"), and mount and remount added to the list of leaking calls - 4/5, 5/5: "opened only through ..._OPEN_BALLOON, which takes CAP_SYS_ADMIN" reworded: a file handle opens the balloon too - 4/5, 5/5: "Physically adjacent extents are merged" -> "Extents that follow each other both in the file and on disk are merged" On Wed, 11 Nov 2026 12:31:30 +0100, Denis V. Lunev wrote: > Daejun Park (2): > ms/xfs: don't skip free extents in later batches of a whole-AG FITRIM > ms/xfs: don't skip free extents of the longest length in a whole-AG > FITRIM > > Denis V. Lunev (3): > xfs: release the balloon inode when xfs_balloon_get() refuses it > ext4: discard the balloon on FITRIM > xfs: discard the balloon on FITRIM Separate patches, not needed for this series; I created a task for each: 1. A balloon discard error fails FITRIM, while both file systems ignore discard errors in the free space pass. ploop_trim() then stops and skips its smaller minlen rounds, which worked before this series. Please say whether that difference is wanted; if not, treat a balloon discard error the way the free space pass does. https://virtuozzo.atlassian.net/browse/VSTOR-154840 2. The chunks end on multiples of the discard granularity counted from the partition start, but the block layer aligns discards to the start of the whole disk. On a partition that does not start on a cluster boundary every chunk boundary splits a cluster, and ploop keeps it mapped. Partitions made by ploop start at one cluster, so this is minor: add the partition start to the remainder, or narrow the comment. https://virtuozzo.atlassian.net/browse/VSTOR-154841 -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel