From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 93AE8803BB for ; Thu, 12 Nov 2026 12:09:36 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACC8Mud008875; Thu, 12 Nov 2026 15:08:22 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACC8Mud008875 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="CF95jx+g" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACC7oJs008832 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 15:07:50 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACC7oJs008832 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-49337a224a8so3496874f8f.3 for ; Thu, 12 Nov 2026 04:07:50 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErG9my7uRai3ZIH+REI/q2ZNtKKSypgV+B2jn9k9Vr0voSuKDJo67cAM285xWDg8wXF2ZG0isQ==@openvz.org X-Gm-Message-State: APuU4Z9QrdBaTPXVZ/OkDaWZx8r30nULpN5veUS2goxS4QGr3vgwBoHX ApchV42gwKsb/RWlu6y1EilZRQrmJ2Ur/QvAjAov9Rhym6/QkZHyOEm8+Jw9FtTWzRHZe36Jlh7 lugCRHA2aCy6IbwzkwmULl6DsOYqBo264fZosbUnFQayvMHiYwmt0Xg== X-Gm-Gg: AYBFou13UpDKyl/0tXmfKPl1w5uX4NsjuwC4ifYcXCzmSIRkEsmZC4MH2NOy39FlRxp 8whEwQLUa4Tn40rNtSc7GR4EWi9FK/FhZhWia/Okr7HjYKpVdpHf0r5ZOoIJ8kSRn8ACzZ5RHx5 OKcBFjpMug8w+mN6LfFckHm7QwBHFsLJYwJTlEW5C+tv6TY6i5rhy3c5kH5gbNyEH4dJtvDEnNx /oJ+d4xTFQLXKVMDyS8Asn1IjhgCU8DYxjmBPlVI4RYtyPOaThQ++IWoFjIdshnaxC2LjfREw2s ZY0LUwVfcvdsEcia6Sxuu0yl4kfbxAnZUyiQezKU2b7PvmOi8eWsf7duUWO6Qv4ghrTgO7caYgv VpPgVeCTpi6pX0zJd X-Received: by 2002:a05:6000:3107:b0:48b:d9:cb52 with SMTP id ffacd0b85a97d-499c7b1c5b9mr12320339f8f.27.1794485270075; Thu, 12 Nov 2026 04:07:50 -0800 (PST) X-Received: by 2002:a05:6000:3107:b0:48b:d9:cb52 with SMTP id ffacd0b85a97d-499c7b1c5b9mr12320282f8f.27.1794485269617; Thu, 12 Nov 2026 04:07:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794485269; cv=none; d=google.com; s=arc-20260327; b=kddtAWFNeRwsUmvba7SEThel9/p/wqG01y4+WSrBH39fd7w3ILFWjogRLWCB306zRb QVAjow4kZpr16xKQlkKsrY3SVZrMPKvK8SIpH1wR2Fbf3lGUbG1f1kzkoB4ml65j2ywV lYi/pYDBkCF8tdpotCL4Q8e6bEEw7L/y7Gkuvu46QeAf4w+OEFgRXtNln3PpuRE6BoE7 Fs++kZYd+HBP6BTL9GKHtAlBOje92s6DgJHaKno6SOblruz8D4RybTEMKwvyP0NuOksK nNBl4HqDUwcNgo3/Q5UwB5e44oEJQ+10UfiAsHp7DKBS21HFqqJTaYShajTvkBvbSZ6G 9k+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=JMZnYeTIk6+1cno63NTuGG8w2aOjNPt6h1+YxV7kau8=; fh=8+L1GLzK3OTQKnTfH5/my9NmwzU+1/k679YBeB1tMzs=; b=c7IpIeDRf6SDrhf3kvqAdlO8t1UfRVLsBYtLTpHpubmCGdxRn16CPjoB+yHMIlTJoG xtXZDbRO5fwuLDP72PPgdd6caVVq0ApsXyG3++a0AHDRO2ICijKtU7728proqRfqW3ps JLjMGmEFf7VPefrW5hakMvHQdl+2Gih0P2Sv/6t71B3EejbMmWe4a9i2aJFK29IWXgln DN06XTr4v3AMM5OegDJNvIinQ+BT6p4PE18ySzs3pvL22SoAOpG7SGAf6YAbrdAv6tbg 51NWVB7mA+GI2s1d/R0XJ2C5X7NNu+ZD4Ahz3jxjPd+1TpeepXZ6OjXPBAX5fJjNotiK vaLg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=CF95jx+g; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-498378f824asi16706779f8f.414.2026.11.12.04.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 04:07:49 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=CF95jx+g; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=JMZnYeTIk6+1cno63NTuGG8w2aOjNPt6h1+YxV7kau8=; b=CF95jx+gqseJ 46Y8UXieMT5SWsi+r2i5vMnZjwHgJ4KnIBrW3JFw3ciGfEmAdCPFq9jvIEOZ1ucXE/do5Ze6aoNoj ETHTDq2Usg7T2LZAHk6+XFoGxuz67Z5Kd40nfsj0XZfznDYiA3JI95DiQbHa1arzsT42n4/K2ygL5 rm3eB/V3ZE39Qbku+CtkPy1/Yw4V54+2dm2XIs8V2J2NjiuSJ+A3O5l2X+XFKziHOwP88xQqtgx+t tZkVjxTH/fiTzdLccWy/cFhliIMMDy2vRA2lVJziG394a2UXsWLkeusC2LWAYyQsDJ/+mqCZWoXOR Lu95IltYhk2eS4dcTywOPg==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRTWe-00FyT8-17; Thu, 12 Nov 2026 13:07:47 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: "Denis V. Lunev" In-Reply-To: <20261111113135.4023555-6-den@openvz.org> References: <20261111113135.4023555-1-den@openvz.org> <20261111113135.4023555-6-den@openvz.org> Date: Thu, 12 Nov 2026 13:07:44 +0100 Message-Id: <179448526422.4060562.5815462477044375028.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1628; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=uE/p8Lg7wDDnb5p1EA0si+m6hTWjcVzti3fInq+xmqU=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq9awTC2sv0jtO4g9NKNVuw8UyxBarf/FhRFhGu U6H4cyuhvKJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavWsEwAKCRBRlgpH+WFc KqGoD/9DYTdvLpmMb/171ww7Lq1MDxrb7mkh1n9C8aYT5O4qZzyZ2ZUmqZVPWZaXShSgn6UOgt3 bxImQ/G92JF6G4oZ2hfYVUf5JpNvY6RzDZyOxwwWPDYQV0d2A5jLs4Wb36jyZyhglC+r2zsMo5Q vOSIfg9/XbLgQ4VA+i1sViu2PIpQzSE5WxC355JKtCdOtgq/xwi5Eolw/WYxhjCI1Y8Q9G47vk5 dB82++nvd1cUs8qzB5b+VLUqUkrinhuQteFxtc2jVIBbEWyBixjR9XvPTX9lexXumtVGBFB1clg LHi+T26Xo5zI8ONW2UEsMiCAswGCGSItmMAFmQdzIlONQ9AQA46RXiRkdPRBBo0uAg1xMtCpn6i TfG6e9iZuRZI7e76YDWLNec3SVF5szLWJubmXUheFUdwG64yGf++JzYm4VbQjpUk8Iyw5YU+iMc SAYAkT8VV7lSxWXzbYSmI13atao8TFvoE7fbhs+t6S1jdnd+OqilYcv4UXgUe5+wTBs/3GcoKe0 upI+ZFZ6wiaoJeKTY61p2tKgKz+kAM/0MQdCHX12prEs2NtFoAGp2L5jCbuxr3FNdd5dHhYW7Bt BPo6RptUIfRHzJ3KGcRk5pf3hrBgRMA4NQbBPawJKPE/81/o7sdVfrLI/sVSZzxrnAge6IwnVFm ldLkKjzGgBQtoag== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v3 5/5] xfs: discard the balloon on FITRIM X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Applying with these fixes on my side: - "merging physically adjacent ones into one discard" -> "merging those that follow each other both in the file and on disk into one discard" - "opened only through XFS_IOC_OPEN_BALLOON, which takes CAP_SYS_ADMIN, so the locks only wait for ploop" -> "only a privileged process opens it, through XFS_IOC_OPEN_BALLOON or a file handle, so in practice the locks wait only for ploop" On Wed, 11 Nov 2026 12:31:35 +0100, Denis V. Lunev wrote: > its unwritten extents that fall into the requested range, merging > physically adjacent ones into one discard. The walk goes to the end of The run also ends at a hole, a written extent or an extent placed on disk before the one before it in the file, the same as on ext4. ploop fills the balloon from offset 0 and never writes it, so the code is fine and only the wording changes. > and opened only through XFS_IOC_OPEN_BALLOON, which takes > CAP_SYS_ADMIN, so the locks only wait for ploop inflating or shrinking > it. open_by_handle_at() and XFS_IOC_OPEN_BY_HANDLE open the balloon too. They need privileges as well, and the exclusive locks cover any opener, so only the wording changes. > + /* > + * Chunks keep a long run interruptible. They end on multiples of the > + * discard granularity, so no cluster below is split between two. > + */ Item 2 of the cover letter reply. > + error = blkdev_issue_discard(bdev, daddr, next - daddr, > + GFP_KERNEL); > + if (error) > + return error; Item 1 of the cover letter reply. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel