From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 260D3803F7 for ; Thu, 12 Nov 2026 13:18:42 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACDHPXd009471; Thu, 12 Nov 2026 16:17:26 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACDHPXd009471 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="q7aupCa0" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACDH7mY009426 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 16:17:07 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACDH7mY009426 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-4931c89d228so2800993f8f.2 for ; Thu, 12 Nov 2026 05:17:07 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErELJVhlmW5gD2xtxN0vCmBufKFg9P5e1CNYpBgYZxK0ufCR6eFryCEoY8rn6+VVkEkMtZFQxg==@openvz.org X-Gm-Message-State: APuU4Z+XQYdtJi892fxQ/+cLHFM/rcUWzfFbS0zE9duZibRqrtQmP74y 4pdH9lxtLbNQCgsJJpOxQt9g1SyYBQjEWkyZ9gtl3X3wDwXAYlvfvX2wpmJSc1DgNNS5vntHu4F 4lHQI+NeYw3lVHlj+COBSXYf+PqRHMM4M+fgTJ9RCrKZkcDZ1ubg++g== X-Gm-Gg: AYBFou3L6A1Xz4ICa1XLvEfTVMslQIaZRgL6POYzMckoqO6C8oMIR2t1nvYx3LA1M2t ASoaID6SkgyZCxVZKqY363uLaCAnekC4y9xpRip2Hqjw/dde4EBXMXAMGdyus7eRB7lB4gge8dx HHDTbSEX2TIlKeCMTXK3LJe9tWCe3G2reIK8C/zrDptR1SdDqap0SlPPmLueIc98hCZ/acwXmOy ECHu4eWqmwjcmcfQzoXUPkGSCpniBS3fV/GkQ0+KkuOuUUQJObs0wkuXRn0Oqmz8kOBERkQHbhc ZPvIPHj+VX5t3DbMLJCUPhVm/ELQnAC1b1ikTbfosm6heCAJz9UYWHfd7rje7sEnOUNLz5lQLz7 bY9CXR+58gFvDqUEh X-Received: by 2002:a05:6000:4310:b0:48d:fd4b:cdd6 with SMTP id ffacd0b85a97d-499c640596bmr9390920f8f.25.1794489426973; Thu, 12 Nov 2026 05:17:06 -0800 (PST) X-Received: by 2002:a05:6000:4310:b0:48d:fd4b:cdd6 with SMTP id ffacd0b85a97d-499c640596bmr9390879f8f.25.1794489426437; Thu, 12 Nov 2026 05:17:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794489426; cv=none; d=google.com; s=arc-20260327; b=B2WYsNWzkwztB+0fwRiUeSnXeL2mZZQ/E2/ZJ6StBroRsu86bCP1qiXm7QMBKGG4cM CvPctA9A26Z52hRA973Fsy4xzek2BZIdKARhUBy9SFcqErTa/cn2AWwiskK4t1kaaUzQ 6hnk9Y6fumxsjgDHtfCcByPfH2iY70cPtuzsYMrHYT7mAKLHOvLpOdvRWFTbrbQRCH4U ifOvZ2tBy7gZxejEsbTFkp9RlCxBy9oIu/6ld/oB5S5ULbMmxupH1HNvwjsqkL7zqlGf 1jRMVPT8GUEtzRVtix6prdbGrGEvsRzIdk4vaaQa58E2StAcoOKrs3o5q67JDZmGXPpp 0a0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=Vu81v+YvVxhBvZo9KCPkvXPzHLnPEWlEtr2fRDXxzs0=; fh=Q8xrIeKEv9kNt0kBAZ24Zoq+O3GjFEiuW2jIo3+yJG0=; b=biH7RVFX0IB604OfHC6cr1+PLeS9KXRzF8Qd/QRXA7uFO2z8YI4kBGSWbWbUF1RO0I gx/8ej1yCinJx2jiJzJ82m8ART2+s7AKg88kH6UriTKoj0Ff6od9RRSkoOOv2GhdJUdq gDE8ySMXEhebdMRSaTKrWIYbLofZLqt0G0fosHNnvQoK4xPNYNu5/m0QWDLbCoRJRf/C mNexkRTRFLDG+Z3B3TiS8QlPg6u092T1ofGd8OMyU9QBRvq67m8Ua0bUA8Q/IsrGg1NY 3oUxIKOsRloWfbDATL/oZlBU4FyOC2JD5YizhRvzQ86ZDS65i2LWM5Ypr8ZZ0xaIJkgc nTEA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=q7aupCa0; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-4985e25fa29si16571128f8f.14.2026.11.12.05.17.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 05:17:06 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=q7aupCa0; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=Vu81v+YvVxhBvZo9KCPkvXPzHLnPEWlEtr2fRDXxzs0=; b=q7aupCa09BYy p1arR0M60RZTPwBrCI0rwQ9C6t72PjTSpWIMvMaa0DE7MfPqYfLkTMGQY/pO+rfS3P+2Eynqe+av2 YkKWx+y8UGtFcc6GIEsCKiUM3i4JRtYOPDhpt/Pdl7pJ4TiJ7/tMZJ2QLbStYLsENymbzxY42ngE1 F3KMQTidU4DDPVM5EO+ds61/VAlZ/SJqauVjxTs7yhTr6ABON6ZwMvYhGwZkiVejUB+oPZQl/jZoM xVwUEIwZcQtH5n6vaGM/tl3AGnU0XlQdx89JZldSkNerzMs6uJXbW9jWX8CFDq6RTda+sd2HOk06n fIdyTfNs48hSMCsi/GR6og==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRUbh-00HHgf-0o; Thu, 12 Nov 2026 14:17:03 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Vladimir Riabchun In-Reply-To: <20261110-ovl-use-orig-ve-v5-5-f3f2bdb29e23@virtuozzo.com> References: <20261110-ovl-use-orig-ve-v5-0-f3f2bdb29e23@virtuozzo.com> <20261110-ovl-use-orig-ve-v5-5-f3f2bdb29e23@virtuozzo.com> Date: Thu, 12 Nov 2026 14:17:01 +0100 Message-Id: <179448942112.4060562.13453206168673800541.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2229; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=dR9IvnAFrOkTntLP0/nWXRVEVHhwtEfboYpkpL4FqlU=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq9bxQI6Z+naQFLp1LdYeoOqTF0PCZ/mFxcQJxc 2JdggX8mUyJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavW8UAAKCRBRlgpH+WFc KspqEACST+wNhWfmV6hxno9tnl51yGUqBU2qD8FPxx5yXdo9M62L3781HvHBywRGLep4F6m0CPO biwVsGUM6sql3Qj6qVP/JW9WOooVgZAn7mWb7Bjd9fUUyROR6Bz6SOYTUYgjCaleN9ijK7esML/ O9tMvSiJcgW5yx7rHxbPtaLJU+HPOhwHvC+Fsm/zZ8YYu8QDriEnt80IYFNc/D0jdCLqPOqqKC4 Wmxi3KMDH/H4BK9AJ8VkyvbG4CQbC2xJfKvhXeEiZ2FhrNT4zOr24kMniMBhN8hrjI7SBbk/VHy HYtlXTb7652taeG+mBwbaml5nUgNC7FL2apVqT3bkB/02sLyLA+NePHCT/fXtgSInI4jLsdQxiL MJDLDwG1b5hZMbGr8hf7C+MiaELH/j3fh7INSmtdvGT0VA+hF7X3wTaPTCPkpKOqfvcD5CPuba5 5cGddMYEDqhdFQYH2rDRShTwrZwsIsoaIUEcmiznm/BGGHeC6tVaNh/jWXlX568aCsfiDUA/BIv +EpZ3XDy3VhJdC9VQWficyPpItA1Lbt9VpWl+szGHQwZS+ihqb2yRVaRy8MzXgQ3yI2AyWLojMY +PsjS1WgN926CBXqB08Z3VSSKLnNw7eQRB51YX79B3J5D3ac8ACXbpp9CmA5yWs0VDJD/6RVgx6 XXvfXBgC0T6HIBg== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v5 5/5] ve/overlayfs: Override VE together with creds X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v6 with the changes below. On Tue, 10 Nov 2026 18:26:52 +0100, Vladimir Riabchun wrote: > Modify ovl_override_creds so that it returns both old cred and old VE. > This will also protect us from future rebase issues - all new users of > old_cred and ovl_override_creds will fail with compilation error. - Item 8 of the cover letter reply: add a Fixes tag for ec01a90d0ef9 ("ovl: replace capable by ve_capable for indexing feature"), limit this claim to ovl_override_creds() callers, say why cross-CT use must fail, and fix "swich" and "Stroing". ec01a90d0ef9 turned capable() into ve_capable() in ovl_can_decode_fh() and ovl_decode_real_fh(). That made the result depend on the VE, which is the bug. The compile error catches new ovl_override_creds() callers only. ovl_creds() users, such as backing_file_ctx.cred in read/write/splice/ mmap, still switch creds without the VE. > We don't allow cross-CT overlayfs usages, it is broken and reported > as -EINVAL. But we want to allow usage of host-owned overlayfs by CT. "It is broken" does not say why the error is needed. If a CT-B task kept its own VE on a CT-A overlay, CT-A creds would be checked against CT-B's user namespace. That fails at run time, while the mount-time check passed, and it is the same oops again. Please say that in the message, since Pavel's "just skip the override" looks like the simpler choice otherwise. > + /* > + * We want to allow passing host overlayfs to CT. > + * It is fine to keep CT ve - host creds should work. > + * Cross-CT mounts are forbidden. > + */ > + if (IS_ERR(desc->ve) && PTR_ERR(desc->ve) != -EPERM) > + return PTR_ERR(desc->ve); - Item 1 of the cover letter reply: test only IS_ERR() here and in ovl_revert_creds(), once override_ve() returns old_ve for the VE0 case. Fix the comment: mounting works, using the overlay from another CT is refused. The user-visible errno also changes then: stat, open and lookup on a foreign CT's overlay return EPERM rather than EINVAL. EINVAL there reads as a bad argument from the caller. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel