From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 3F2B18017D for ; Thu, 12 Nov 2026 16:37:45 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACGaNUu010528; Thu, 12 Nov 2026 19:36:24 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACGaNUu010528 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="v9TDf5PR" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACGZn3e010479 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 19:35:50 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACGZn3e010479 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-490ab0a20ebso3360742f8f.1 for ; Thu, 12 Nov 2026 08:35:50 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErHK3TWE/y2wUgSoOFc2eeESYGv4AvvnHEIi1pN6VBClHfP+ZmCqWAHZ32+ytlX9vfvTorzxZQ==@openvz.org X-Gm-Message-State: APuU4Z9yeYgcBxDLzs24uiNfxC2Dd1ZyPiwZixUZUGmrVyUcrzjBGMKT TqGygMPhO3YCo4aLVGzbVNTfmci9HRrtS/tKuECs82uhd/epul/AMP9zme2AZROLa6l0Kwaa8ZU 97iW1X4bJYnPsK8rXhGOtjmH4IaGBMjjxIdCE2zIVojrTh9m80MliwQ== X-Gm-Gg: AYBFou2+1frB4jigpubcegF3UO4xYcABidIzVrpJF0Od5/E2dINoQt+NOnu+oDkESj6 5VPpumZ4hrq8j3jjW1IpFBU/GxUHZrFczPK6SAp9r2aGmB97N8rr2TNA4XmB8F1T+S6W+AXDYpV Bxx9ql1tQMgJJMYI/4oddK9IbhVyIR6YcxRdPYKE72RqdcBpgMnFwMFgL7J/YgUqsUxTTZ2g5eI DHLq/j2E11lZE0MJmCC58PxojW/646724F2LfNPP9aW0Ld4zJH6s5K6U0WDFpvuouRVYAjUDv8/ WIO4ZYuF4pCjZM8nNfMcqWjOrnnZiztS6VPeyljYeb3tnx5MMECUckxJBSjZxFhILXBEBWnZzTd iiJAyem/2CSpXDQPvcg== X-Received: by 2002:a05:6000:2489:b0:48e:7a41:d78e with SMTP id ffacd0b85a97d-499c7552a56mr11259739f8f.19.1794501348857; Thu, 12 Nov 2026 08:35:48 -0800 (PST) X-Received: by 2002:a05:6000:2489:b0:48e:7a41:d78e with SMTP id ffacd0b85a97d-499c7552a56mr11259535f8f.19.1794501347402; Thu, 12 Nov 2026 08:35:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794501347; cv=none; d=google.com; s=arc-20260327; b=e3u4xCKm9cvkelvjLjNjsYwnNDHw4JyVH0KEcHY9HqhDQV3PN2ogJD2Mh4V/6cwIMB wCVKZZprBpngl7k4tRly2+tk/Q2LhyBaVnzRKAu1o9U2LYtPSCb5ehJc2+YPk24owovp MhPiqgzhPlspedzLY+vCMOfL/15KeVVSN5vfuO/5L1lUguxUaTwRWYlBEMe5C/8qaQfo CermXOhbgfnlavLIrEsGN6/t2nFQVbFXvmIeEm649ZsaRNCJ0bznxfh+ahenOKHlgP0B hEa4BDfICoIkcWBH42MMdFt1G7GtzEkUupTKi/VEQaYRSawa7x6fW7dCe1vClL3rtL4c nVGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=7HR5yA3E7MueNhYn8OnI5a7HE4mFpF3v/mVvbzH5fXM=; fh=Q8xrIeKEv9kNt0kBAZ24Zoq+O3GjFEiuW2jIo3+yJG0=; b=TeVHI7zid9PyzPdfTOoN3Q27vc53Fq63v13u1Y3+1575p8Wzq91uFW9f0FwkXV19/j Qe+Uu87qXI/vrY88ENRFaA7hsTbJFojD6Mv3tSMO/5nATgFH5BZsCdwAxOX9iOQPdDUb 2yYbFKuGgRoXaW4U/ssa3AotxmkWTmGn9RgVNdU1CpuExyPFAqyk1tcXjeIhlVPC6rIl fULGybMQsyJiKJwHQDIPsHZ0seY22+8yyclgO1BWAh0+amW6H8g8l1b+VjpvHQjO3cpx wMuNVVxeUUP1yk1edUOLp2bJVAqtZ9edRG/mn123oH1Np4qXh4DRBb4ABSqR7xOrdNzC eZHA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=v9TDf5PR; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c64ee0adesi71199f8f.451.2026.11.12.08.35.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 08:35:47 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=v9TDf5PR; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=7HR5yA3E7MueNhYn8OnI5a7HE4mFpF3v/mVvbzH5fXM=; b=v9TDf5PRDror wm1r4HCRJAGIz7EkGjxAVNNv8ittJuR52ps4NQzdPPeez5am1uej4EezGqa4DedbqrqvVO5baiFx5 0W9X+bS0ErvjkT6WHS9GD2AE75Gijt6Gzchh1HktUG1laOhuuLSDdiiDog1yBKnh1KEgh0ovkxSV9 W5rMkOT7R5voLFtJCqCzfyVlDy4ecBqJqXVgWgNSsB6/Ud+cJv7q2mfCAngsDT3bApsv5Akn2O1dH xPJXUW+0iE8QbWq3GXcOMsIFF/gUX93Z/HY8v2NFE0vGFV0a3kllRBKCLMDz8KIG7S6TY/QIb12KF jlBTxc59DjAB4wGRX/OLKw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRXhx-003SjS-32; Thu, 12 Nov 2026 17:35:44 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Vladimir Riabchun In-Reply-To: <20261012-ve-printk-irq-v3-3-efc95fd5c78a@virtuozzo.com> References: <20261012-ve-printk-irq-v3-0-efc95fd5c78a@virtuozzo.com> <20261012-ve-printk-irq-v3-3-efc95fd5c78a@virtuozzo.com> Date: Thu, 12 Nov 2026 17:35:40 +0100 Message-Id: <179450134078.4060562.14805563857518430497.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1856; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=oDH5O14WpCmg2o+O/s3iV+8mrSzKlZSbye2K94DW3eQ=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq9erfVIaRpvKkIYL8VMqc7UREAAmRpMEIrA88E VJrHs/tnl2JAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavXq3wAKCRBRlgpH+WFc KmrND/sEoOUCyq/u5heGwTMjhqn/5Z160dEiKNtGqyWh9yB5WKBxuH4a2ht51aKCY5XK5nfjcnN CFWfYQsCtw7G9ljtTYnRPnaPz2KrfJ6wyYG+y25eATd6kDRg5zB6k7dNg29PcYYnp7qelsv3svH 97BnFglzjAkH7YqcYILGvBjR0WW5xuWAAEc1tmI7yd0uFnpEk55DQdzkO/aKRvoWlMFTtPbz6cU 27EhNnOmFafbVjmm93njOtZ19m/zxdr8DoTNCB5GYsYu9yjUBUfE1Mpvpovy4bih4bwlf6utIzm QH/6MATR/RIW1UubcjJ6RLdRfrr26HphRRb3U6v1FURdfZBFrx2rMp7GjCFVlXm1h0i/N31LUYy pPzhzh6I1EH2qa0KXxxQIEwAvjxMnLBCP31FVRA0xJHo0lg0AjpRIQjCh4LA7Bg86Se8d+7WUxw L5VcwBVNnyNqav60QEwB9yXBB8zbjA4A134bKDePPiwCxvo5kyI3U2RjmOanlQhPhCk9QTauw39 q0B9Dm/PP598FNg/PL6eqhPGd1TN2dhcxGgRoSZq7uUKF66iT+/KUM0ZkImS/oRFFcWT8O42YIM dWR+1RUcdWbOEp+DD8t3MbfRgjZYzpiITlx0nd4wtbkOBQcM4KSYPSBGiBm1yEaUk87EZFAwN/h Ok8HcViiSJABKhQ== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v3 3/6] ve/printk: Specify ve in printks X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v4 with the changes below. On Mon, 12 Oct 2026 00:52:30 +0200, Vladimir Riabchun wrote: > + struct ve_struct *__ve = get_exec_env(); \ > + \ > + if (WARN_ON_ONCE((dst & VE_LOG) && !in_task())) \ > + __ve = get_ve0(); \ Item 1 of the cover letter reply: rename this local to a name no caller uses, and write "(dst)". Why: ve_failcount_inc() has its own "__ve" and passes ve_name(__ve) in the varargs. Inside this macro that name now means the local. At this patch and patch 4 a failcount hit from a host task (vzctl moving a netdev into a CT at its netif limit) prints "CT0" and goes to the host log only. Patch 5 hides it, but the local still captures any "__ve" a caller passes. > +struct log_state *__ve_log_state(struct ve_struct *ve) Item 2 of the cover letter reply: make it static. Why: only printk.c calls it. Here it has no prototype, patch 4 adds one to internal.h. > Introduce ve_printk helpers that accept VE structure, > so we can provide correct VE where get_exec_env is unreliable. > > This is true for ve_printk_deferred functions, and their users. Item 3 of the cover letter reply: say what changes for users and add the Fixes tags. Why: the second sentence does not parse. The visible fix is that the conntrack table full, expectation table full and TCPMSS messages from softirq go to the log of net->owner_ve, not to the CT that was interrupted. Also, ve_printk_ratelimited() with VE_LOG outside task context now warns and prints to the host log. The tags name commits a335738ad21cf ("ve/netfilter: ve_printk for "nf_conntrack: table full"") and bc279343e9663 ("ve/netfilter: Send iptables/netfilter kernel error messages to Containers"). -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel