From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 29AE7803BB for ; Thu, 12 Nov 2026 16:37:15 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACGZof4010481; Thu, 12 Nov 2026 19:35:51 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACGZof4010481 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="glzMu3mY" Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACGZld3010463 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 19:35:48 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACGZld3010463 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4a359c7f47bso38571595e9.2 for ; Thu, 12 Nov 2026 08:35:47 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErFkx/8B7WftV47VjMPVxsse35pUYRxn/FmYXUNWiusBdaj/WyXkXwxlED2ZXKA9n9KK/p2WEA==@openvz.org X-Gm-Message-State: APuU4Z9a6MZVy+lYAnP0Qed4biJk/g+N3Vn1slAYc3zSS+EJx2MLLHpE 7UXPEZDmx7AT1zdW6Z6CUTd7pvNYO/P2VrgYGbI48Wa+HJGUTWxXOkxHltuMMAzwN5WVpXVa5rU qSNovpJA2Ihzf9YxOORDXR/dGfa31wpdKsHMSptsYWOkVKWk5D+MDdA== X-Gm-Gg: AYBFou0ttxg+aG3c5yfeyysMVVGMADskcA5JDderuB3Gbt25apsFnC0WTbc3qyTE/vZ MwzTVpPsvJKF+/RcB3WoQuuiRS4cahNci/gc1PhECJ7mzmD+VzGgA4UWkYi9+hpjBRCuJ3405Hm 5xvM9Y0yAQs8EfyPFqRSWcTXjkGK97rB69eKqtpsaWXydwiTUdESWYkntaLvctU8r62VxL3q3LL pPX5wSt3DvMgvbZsQegiO4HfFmig85yHfyCU6CYULPDGMqcuhPjofAQzTwqENt+GW/ZEkonH5/3 VfM0ZoiTLRGLWDL4IvITXgXtVSVpVUJYwXSbAkxAgFjyCg6+5s4W0pzC/29oFOBQ45qqp4E9dpU +tUFx32hi0x0mZ+KC2g== X-Received: by 2002:a05:600c:1549:b0:4a2:cbe:bebc with SMTP id 5b1f17b1804b1-4ba0938ba0amr116640935e9.23.1794501347388; Thu, 12 Nov 2026 08:35:47 -0800 (PST) X-Received: by 2002:a05:600c:1549:b0:4a2:cbe:bebc with SMTP id 5b1f17b1804b1-4ba0938ba0amr116640415e9.23.1794501346924; Thu, 12 Nov 2026 08:35:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794501346; cv=none; d=google.com; s=arc-20260327; b=hGqPow+WIzsi3lsdjKW+WMUl8NHsnibEwe7ojB6KWgdp+pSrzyAYjVvXoP7RAZkS/K uG00PEv/fhjqdbKtn6bEapZNgfNzea0Kzr7GYA6Pm0DRjgiU3FoKsS+zFM2MWPMyQn2g D4X3ek96ZJuM9blmR7NqStc0z9nKtM3cQlMfuilR6QfJJg90xuFQYPWDb/7Q5yLL7UDh lvzfGw5Pro+UFEXLUv724rxDSQhTA/7UXh0PwLlT6/2e5kOrDhGClUnKnrwwSmtCEw7y xzCxL8HQr0J7ipj0z9dbbhS4FQZaFKYimNQrLyPn185fYd3Y16wOAh9IbQjACdoF0vtA 3EIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=bk2BghCI8CnH4LU0tD0fuVCL0O8MQtpVOZh3YPjZeZw=; fh=Q8xrIeKEv9kNt0kBAZ24Zoq+O3GjFEiuW2jIo3+yJG0=; b=OlEL9HqVCR/NFnJ6tIYtQS7Ob6bSktCkdhe4sLLxITHc2UyVijWMltIoKgS1lSsFW9 AG75W3rkD5kShVf7Ol2cDyNw+Bb59pPN2znOkcGka6TvlzSvuhAMlnL91UX503JkgqtQ Y+tu2JLICFQLlupC5KailjTgQX+BEuSDtRt6pHxTibFlKtZdpfnvHi0D/FKhaiZRZ5Xs /yKEHB/e+ROVjUgcgBAvlZPBFpt7b8PXvhLRd5i0T2vrxLvFhUckhGcziqgRYlgS296h kbRmxLNnLsgbiqbIvwD1ohDhAuJg0bxYTBc24iH5bNMUBfIbfOLlJ8oxEO5lE8Zg7Nic elcA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=glzMu3mY; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id 5b1f17b1804b1-4bb4e25ab0esi56525145e9.10.2026.11.12.08.35.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 08:35:46 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=glzMu3mY; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=bk2BghCI8CnH4LU0tD0fuVCL0O8MQtpVOZh3YPjZeZw=; b=glzMu3mYg5+R Gq9mA9PXOuZYfeixR+T/mZhVozJP1HJiTlKzDJGa/BcNQs3guqt4xwdCy5v67e/7gWtOnT5lkxzYr iJ4VlrlKSfFrAX9PoZht8y+D2GeMYJRKW2L0hE45rQ9PqSDgJkM1d5SRLlrUKLGXfLNwGLgthiPd5 ihMAwBd95FZa0QVJ1vPKnk+5WBnG2RPbWuZOx8n0qeZKmMq4FAFrpFVeWXzlooGv8TqbbN4DfmTti MC6OpAP61+kpbg0GMS4t/OpB7kllVHLl0z8h2gBHDYMiElPpUSuMjKJddjHjQbMwo+DAbieSKWkGn znCRobq7wVtCTzXIQfMmrw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRXhx-003SjS-0n; Thu, 12 Nov 2026 17:35:43 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Vladimir Riabchun In-Reply-To: <20261012-ve-printk-irq-v3-0-efc95fd5c78a@virtuozzo.com> References: <20261012-ve-printk-irq-v3-0-efc95fd5c78a@virtuozzo.com> Date: Thu, 12 Nov 2026 17:35:40 +0100 Message-Id: <179450134078.4060562.16522511515702111377.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2766; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=jctxb8mCDvJc/Ueis+OWSCHRGorNwwlFFWijlnh3Fzs=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq9ere+DJyLeRw3Mby+NksIjuP+sTP2/z9RvTs9 FBJs5FoG6mJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavXq3gAKCRBRlgpH+WFc Ku1dD/4u5JIH+KrjCy8rolZmAk393owxEOAdtC9EYfvxdPA5qPbwwiCAPFgwIE+Ged03EQUIaWN KAmWccVW9Jg0WJNiSVFJh8uqibLtEAf+96AVtyf3eWb0LvtdmEAXF8rGZ+kW8KUxNbQkgqpIXqN 81NvUHhVKGeNuS7x4dOC4sqUKF8GE7K64PUmYiWTTjIA13zgH7i6Lx7YpeU5doGs8x8dBhPK2fY 7K+kIi4P7Bp5f38Zuuiz/EVCQbGFA/kBV9xROximctkn9lbyzhdsRNElK6jaQeT4GDlgXuG+Wjr oIxRRSyO3cX9ZPiefVkn1IK5O1LLgscVmmOp2/a/YggoR8PEqoiDlxy2NaEMSyDC7/RWud8XcvB 0CrHYqRFRYp25VW5RB35OQ2OUOl6PKxHTcRwGj6atsbss3GrulFrZynJQR6+EkprqKkv1weAx6h bFjzDgr9XLZtEDGjnMkCJAGaGdqwpw2d/PJqvXv1QFQtfXzRzxkbd4xcDGoLH5ymL/iiUFfq3Ht V9co79EV2E/gI9e9EOl6+iJK9Xtkr0fHgrel87uNs9O6SsmHuwGIFeIIhvRjqKc84SvYRxdvJlq f/KZkulY9/yKT8EETr3t1lrsm/tzH7joZLCEPUPXlPTx/4wuzEBUN1FwhzR47qnMy9rViIjvzfZ DjxTl5ctgg6USOg== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v3 0/6] ve/printk: Fix logs leakage via ve_printk called from IRQ context X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v4 with the changes below. On Mon, 12 Oct 2026 00:52:27 +0200, Vladimir Riabchun wrote: > Vladimir Riabchun (6): > ve/printk: Add sanity checks in ve_printk functions > ve/printk: Report potentially leaking usage of ve_printk functions > ve/printk: Specify ve in printks > ve/printk: Fix time virtualization > ve/failcount: Use ve_printk with specified ve > ve: add neigh_tbl failcounter The approach is fine: after the series nothing outside task context picks a container log from get_exec_env(). What to change for v4: 1. Patch 3: rename the local "__ve" in ve_printk_ratelimited() to a name no caller uses, and write "(dst)" in the macro. 2. Patch 3: make __ve_log_state() static, it is used only in printk.c. Drop its prototype from internal.h in patch 4. 3. Patch 3: rewrite the message. Say what users see change: the conntrack table full, expectation table full and TCPMSS messages now go to the log of net->owner_ve, and ve_printk_ratelimited() with VE_LOG outside task context warns and prints to the host log. Add Fixes tags for a335738ad21cf and bc279343e9663. 4. Patch 4: rewrite the message around the real broken case, and say that records stored while the CT has no ve_nsproxy keep host time. Add Fixes tags for 1249fbadd45b3 and 8b42370ae936e. 5. Patch 6: count and warn only when !ve_is_super(ve), as Vasileios asked. 6. Patch 6: keep one Feature: line, "per-ve failcounters". 7. Patch 2: add a Fixes tag for 8c24627ed5346 ("ve/printk: Introduce ve_printk()"). 8. Patch 5: double space in "Use new __ve_printk helpers". 9. Patch 1: say why the condition is reordered (so that patch 2 can put the WARN before the get_exec_env() check), or fold the reorder into patch 2. 10. Cover letter: - "No tests crashed" says nothing here: these WARNs do not crash without panic_on_warn. Say whether dmesg showed a WARNING from these functions in the neoltp runs. - "failcounts can be now used in any context": not under the scheduler locks, __ve_printk() is not deferred. "can now be used" in softirq and hardirq. - Typos: "there an no", "GET)VE_LOG". Separate patches, not needed for v4: 1. WARN_ON_ONCE() sits inside the shared functions, so only the first offending call site per boot gets a backtrace. A once flag per caller would report all of them. 2. ve_offline() does kfree(ve->ve_name) without RCU, while conntrack and now neigh_alloc() read ve_name(net->owner_ve) from softirq. The netns can outlive the offline cgroup. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel