OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Vladimir Riabchun <vladimir.riabchun@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v3 4/6] ve/printk: Fix time virtualization
Date: Thu, 12 Nov 2026 17:35:40 +0100	[thread overview]
Message-ID: <179450134078.4060562.3011087073695195504.b4-review@b4> (raw)
In-Reply-To: <20261012-ve-printk-irq-v3-4-efc95fd5c78a@virtuozzo.com>

I won't apply this version, please send v4 with the changes below.

On Mon, 12 Oct 2026 00:52:31 +0200, Vladimir Riabchun <vladimir.riabchun@virtuozzo.com> wrote:
> The usage of get_exec_env() in ve_timens_add_boottime_ns can lead
> to time travels - a printk from IRQ might use container time for
> printing to host dmesg and vice versa.

Item 4 of the cover letter reply: describe the real broken case and
the records that stay unshifted, and add the Fixes tags.

Why: the shift was applied by whoever formatted the record. A CT log
is read only by tasks of that CT, so "vice versa" did not happen. The
host log was formatted for the console by any context that flushed
it: a CT task's own printk, or an IRQ on top of a CT task. Host
console lines then carried that CT's uptime.

The code is fine. But records stored while the CT has no ve_nsproxy,
before start or after stop, now keep host time for good. Explicit-ve
writers such as netfilter can reach a CT log then. Please say so.

The Fixes tags name commits 1249fbadd45b3 ("syslog: Virtualize
timestamps in the data reported") and 8b42370ae936e ("kmsg: Virtualize
timestamps in /dev/ksmg output").

>  struct log_state *ve_log_state(void);
> +struct log_state *__ve_log_state(struct ve_struct *ve);

Item 2 of the cover letter reply: drop this line, __ve_log_state()
becomes static in patch 3.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  parent reply	other threads:[~2026-11-12 16:37 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-11 22:52 [Devel] [PATCH hci-8.1 v3 0/6] ve/printk: Fix logs leakage via ve_printk called from IRQ context Vladimir Riabchun
2026-10-11 22:52 ` [Devel] [PATCH hci-8.1 v3 1/6] ve/printk: Add sanity checks in ve_printk functions Vladimir Riabchun
2026-10-11 22:57   ` no-reply
2026-11-12 16:35   ` Konstantin Khorenko
2026-10-11 22:52 ` [Devel] [PATCH hci-8.1 v3 2/6] ve/printk: Report potentially leaking usage of " Vladimir Riabchun
2026-10-11 22:59   ` no-reply
2026-10-26 15:21     ` Vladimir Riabchun
2026-11-12 16:35   ` Konstantin Khorenko
2026-10-11 22:52 ` [Devel] [PATCH hci-8.1 v3 3/6] ve/printk: Specify ve in printks Vladimir Riabchun
2026-10-11 23:02   ` no-reply
2026-10-26 15:27     ` Vladimir Riabchun
2026-11-12 16:35   ` Konstantin Khorenko
2026-10-11 22:52 ` [Devel] [PATCH hci-8.1 v3 4/6] ve/printk: Fix time virtualization Vladimir Riabchun
2026-10-11 23:03   ` no-reply
2026-10-26 15:36     ` Vladimir Riabchun
2026-11-12 16:35   ` Konstantin Khorenko [this message]
2026-10-11 22:52 ` [Devel] [PATCH hci-8.1 v3 5/6] ve/failcount: Use ve_printk with specified ve Vladimir Riabchun
2026-10-11 23:05   ` no-reply
2026-11-12 16:35   ` Konstantin Khorenko
2026-10-11 22:52 ` [Devel] [PATCH hci-8.1 v3 6/6] ve: add neigh_tbl failcounter Vladimir Riabchun
2026-10-11 23:04   ` no-reply
2026-10-12  7:59   ` Vasileios Almpanis
2026-11-12 16:35   ` Konstantin Khorenko
2026-10-12  7:59 ` [Devel] [PATCH hci-8.1 v3 0/6] ve/printk: Fix logs leakage via ve_printk called from IRQ context Vasileios Almpanis
2026-11-12 16:35 ` Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179450134078.4060562.3011087073695195504.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=vladimir.riabchun@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox