From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 0FB32803F6 for ; Thu, 12 Nov 2026 16:44:36 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACGhMSQ010606; Thu, 12 Nov 2026 19:43:22 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACGhMSQ010606 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="bzHo0z4r" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACGhBRd010566 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 19:43:11 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACGhBRd010566 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-499ca65ae87so623955f8f.1 for ; Thu, 12 Nov 2026 08:43:11 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErGIIU3+qX07YbEXPdOoHxDt5EpGUfFE4GlcTtzaXGl6kMf/mxYkJNhzoiReIrEz8jrU6LNhMg==@openvz.org X-Gm-Message-State: APuU4Z9MTi64tVVc7wDlRMoXarB9wIvZI/Yb8qQaYeHrIxRgq+wB1q1+ AG22clVDmIT9Rs/UymCiHUXknmq3xmQ3wNacwxLTyVK0TzjkgUut0J5pa9mNkmhph5CPfK4103a ujTuMLwwhfoOHmyA1wC789RKn0STV+wOvEz0IBZlaIYxNnhnGTqDHvw== X-Gm-Gg: AYBFou1KKLZO4prepTSjtneydRwdLXkd2f/kEiuCMPs6LullET42PNOu1+trKgPNnla 5x1x6GMG0rlN9XjExwUqiZ12/Ow04ithhaRJw27D1yoLe/JmAb2s050yCsJZfoDc8VWgt3ApFes 2uJxLQKseQMs841P020Ua3a7khyRbOmO+etGzn7a4ZO4y61wTenTQ5LTOEWR41p46OSMjkVzq7x AtHE5qM0uKDiWqSq/O9SAU0WRzAa5rl+rqJt1Mqr9I4LtwZASeBtztf4lJQkNoyMfz+oGjXWzlv WK8uH3c64y0l0/pNU5Lhfmb6Nnx8ZAa2lrEB9gcYp/6a/KUbUG5osCZJBPn7Td84t9Qj87YCS+y 4ZKUg4/Ghfi56jgfZsQ== X-Received: by 2002:a05:6000:1788:b0:491:3c17:aafb with SMTP id ffacd0b85a97d-49b0287cd32mr7001168f8f.20.1794501791422; Thu, 12 Nov 2026 08:43:11 -0800 (PST) X-Received: by 2002:a05:6000:1788:b0:491:3c17:aafb with SMTP id ffacd0b85a97d-49b0287cd32mr7001062f8f.20.1794501790932; Thu, 12 Nov 2026 08:43:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794501790; cv=none; d=google.com; s=arc-20260327; b=sClig78n726wkKIMjZbZ5F/NmaCTM19spfKzFwXjXQusgnAvy7cuMI9LQYv3zikDOG HExXTNuYDaiCqXwjFYVFaRQFgOU1htVkKGEXmVBf7f0laRcEYbkS454linG/hCL4kTVN PcHWNNUsBqmmEMfRjtuJ1sjpknxh2dGosrst/dY9tGxyXcVnM9r19tz4EFPHVvag93ck HsETiTLhisE0znd/NSqyAtRU/I4xzdZiUnHAsSxxwQ8OqPUoh4aR6KzqucUQtK7eWKOY t8tEtqC8u8V6y+Go16Xn5DXQWzthsykZ5Q5ijiopSh7qTGnHG5JNmNdi1dQ0GZBIRQvi Rz3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=wN+2TdRM6+Rr+MoyYoBhENccQR8uNETYQ8ojuMvUr+s=; fh=CTF2GHyV+XdzB5TROrdG4fdLri6JSHNOBC+LNuNq5bA=; b=I/ry5lo61SARoPv7pEKamhnYVXZlrU21aNPW+ftO+AaGlci/vgGqDyBwLMlgGAh1Ck rarDQotB3DNRqo0bvMdgx/M/E3ykcjsZRKhlxTXB1uMQgHQ1zn3PPkx+ZkVdnHAtGU10 RjYt237lOgX8SV1NxLdqn5DfhD4/4XdLum76TaG1LHWcUqNbWIuVtsWgb2g5VzrapebY NTPCX/M3+nQpxh87U8bft7RGobPI5TEhjVD0sSQbn23dg7Wnx6BE5FTeshqG1BnYqZYp P1Z6ZTKGoCFaD6kygDJiFJDsjcm5KTbRk80xmqOuINFOh+0f/ILxxtGaJZ79yqsv9kBg s6dQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=bzHo0z4r; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c63da36fesi133082f8f.225.2026.11.12.08.43.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 08:43:10 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=bzHo0z4r; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=wN+2TdRM6+Rr+MoyYoBhENccQR8uNETYQ8ojuMvUr+s=; b=bzHo0z4rIYN0 7JTlXNhRT96YhtEwnifwspXfGGuwb40vFeEL89ChXfQdLEn1LcrDsKSqHcSzwNNIrwz40NLcFFUWC uEQrfz1FOCyPu0z6lvYjbMaN3/0JpGYH1eL+pAOjEh9sGHrwvjjHfPS0/O+lcgS0cCqAsxSdgde0R bx99ETFtqtpg6aYbpu+gbPemDEmVaPq2z0/HtR0PETArv3j5Fh0abMmvVPp/A2lPemaFxIk7xErxo VIcDwhclrFwZYp2hxa+UISc/UMcy2qgHqibWjbou8TcLc7qk9qzfvA9qOoSAzITWaeOinX4d5dyRj TtuYOQBaThJ0SaDO0Agkag==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRXp7-003ay9-1l; Thu, 12 Nov 2026 17:43:08 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Eva Kurchatova In-Reply-To: <20261112000926.381308-5-eva.kurchatova@virtuozzo.com> References: <20261112000926.381308-2-eva.kurchatova@virtuozzo.com> <20261112000926.381308-5-eva.kurchatova@virtuozzo.com> Date: Thu, 12 Nov 2026 17:43:06 +0100 Message-Id: <179450178653.4060562.17939443547609999995.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=890; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=Ri9HW0BwU+iS3VEzTtbjb15W8cX4AjC82pZnC6a0mwY=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq9eycOuKvsouK+dndCLLHdf0vAq67BlcHMTC5z P6Z+n/OznKJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavXsnAAKCRBRlgpH+WFc KreyD/93FNRJB5NmvH63dy9tEAcN2e67XTmpX3XSJ6e3gkip8qCwSSmGMvCKXlZrTDKwKs33PU6 g7P06InbdAOhOyEVIAHoGvoWOTHHrfR1ZzCIR58Jx/dClONNX7OaUI4IDm6XmkUaA63t9wk9011 TvOKtp4KsoEQPWTDBC+5luLvHi2M0EXqAdkozJJuP91cm+rwb2P81+cc4DyL+K4FU9tHhhgqGki +tVRDo0HHHalpkj8IrzdFdXGfqZ1bSzEKYFMYuMfyfmfWiTlgcpcaGvBXpyzeiNtTCEdBXzkxeF DOY2/uOh2497efHZ6SKXTrzl91hnyu0Ehm3h0dsn+JNF5+Xc8+SKMdEteL4mYid0cDWTQ/F8Xb+ 89WJbzpI7EDgkTQ5A59Yys5mjbxF4vYZ3RBLMZTpK7H3RQr4leQ5/fA5kHG8iU2+HH3t0WKzHtt QZigoXs3HFobKohAPUIW88mPNLqN9tLbW3Yh9DJI+12V05yV9gP0THgQcmSw9Q8s0OE7c1S29TR mOr86kApqMIRO+DRWPHWhMp1sZpKNiKbeggVfLTKNhnlHjV5E+xAJdZeTuOc7e/ZywVRmm/OvCC 29NUlyI5d2ln46Hwhvn0uz2CfsPh7+Q6IbDYlLjMW5sR1JXp+oAgcXrxFfpt5+ZgmOqKHI+3IaS EY5SFpufeHLUS8g== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 3/5] ms/eventfs: Use children field for rcu head and add memory barriers X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Applying with these fixes on my side: - put 5/5 "ms/eventfs: Initialize ei->children and ei->list in init_ei()" in front of this patch. On Thu, 12 Nov 2026 02:07:55 +0200, Eva Kurchatova wrote: > if (ei) { > + /* The ei should have no children if it is being freed. */ > + WARN_ON_ONCE(!list_empty(&ei->children)); > ei->is_freed = 1; Why: at this patch eventfs_create_events_dir() can still reach cleanup_ei() with the list heads zeroed by kzalloc(), when tracefs_get_inode() fails, and this WARN fires there. Your answer to Sashiko holds for the SRCU leak, but not for the WARN: 6.12.y took the init_ei() fix (c480f8af173d, v6.12.109) before 1b95382da85c, so it never had that window. 5/5 moves in front of this patch without any change, the final tree stays the same. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel