From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id B4F90803BB for ; Thu, 12 Nov 2026 19:01:16 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACJ00pm011657; Thu, 12 Nov 2026 22:00:01 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACJ00pm011657 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="kaE1LJdt" Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACIxrZx011630 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 21:59:53 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACIxrZx011630 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4b9fde3044dso769355e9.0 for ; Thu, 12 Nov 2026 10:59:53 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErH3db40myTwUeWiq4QnZzZ5MQ8EA9P6o+PPXjm5GkOOULZB1aBZvlZQwZT11yZsM53SNZc1Ag==@openvz.org X-Gm-Message-State: APuU4Z/dyt72h2M5K+t2lpV7EuiSKaZ0m621INq4O/N3LNk+TKXYj9vc Ex384JhDwkONmx2Es5nq80EgqLl3k6hre61oGx0+Lm0xQmsitPyI6wM6HS93RVTz1P0BhYaFJwR 8apwdhZSdDZ0vI2ZKX4Qvtrp9IySPtnm+J8lnfFFSYnTzkdzmbwNy3Q== X-Gm-Gg: AYBFou3K9ogRyQio0PuDkmmhWyEQ54s3TDOPUDWBtiMtG79YoVDHwKdQz4zJ10wEwgp BnFLVRm1y4pJu9TjIJnXCtb8C0/17S6hIECkthlEikNUr8v2MlcuUpLT41WkoUIUxwKxU5YUTd6 W/VjDpluhI6Uoq9HxbSo8roWwsPePWO3qeYJYvkuRpH1Lm/vksPck7j30fRaF8CChK7p6qeCNTj JnMcX2Atj6X3ci1SSqUZZdP0px8Rxm1ltkfiQ+db4PnkfKbusO6TNRoB1rvLU1Y5IR4Pa2LXXEP SOvdF2yYVQ+skKkZm+FTfmIdOJBnloHqg+sFhW4Bsl05yFRMWeW8764L2LZbMzdCOE2Ahn+Xcwr BjCbhvcprDJoccIn5Bg== X-Received: by 2002:a05:600c:8b34:b0:4a0:1c0e:b057 with SMTP id 5b1f17b1804b1-4bb55a25bd7mr3211105e9.4.1794509992884; Thu, 12 Nov 2026 10:59:52 -0800 (PST) X-Received: by 2002:a05:600c:8b34:b0:4a0:1c0e:b057 with SMTP id 5b1f17b1804b1-4bb55a25bd7mr3210625e9.4.1794509992415; Thu, 12 Nov 2026 10:59:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794509992; cv=none; d=google.com; s=arc-20260327; b=fThHxeo996ShmwX84xX9adqcpencYdHZRa95FbqtTN0OjNsclMhRvcAKVyM5a3v+C7 dTShptdmIYXHQhXukCTIGFWRtZzPfVB9J/NWM+jumPR9LFnC8FHEYcJMB0mYi+g9sBDT UOiWjKyP/uQ9d9m2aCfmoqOuiekbUuBRR/qrSzL1igAZJL5qb+4zRs1cXwubdtb4DLK6 KoNGzO5OikZeeIKyyEhL9x6YkltdAv7NFPv8dvnR4iHg+Mqg9uHOtHGBNBdebFqdRH2E aSgXjG7FO23YlsuxWINXkbWUeoFhua90fTRO96NMSSUk78P5eHju6IijXRmFYWZh2/en tdTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=4sbQCXVYUg9yEeqt+2sD8bqVTxxllSkTGlsbDQ/2qWQ=; fh=NNIHAR0oQq9xcHtG6fvuNrouibWQy9PtHjAIRR7/XzE=; b=MQE5p4BOxD93emHIUppygUUXHv8429s0i6zLQ6yL40dPV4UQFTaUYYdjc4RCjX7tzF dVLUrlio2If4HNEOyvv6RSe13fK4wp6qIVBq8i7Gghwjj3eFc9Smrifo24P1npz95khW R48+xAicix3DehLo3WuIEkrt0rQRVxdNAOmkoBKl+iDGagBAmtS4pktwSjAhOkNgsTe5 Aq9qKQXcKwdrSG5fOFLI6A9KdXjVym5k5y4JRaevajkzfwJfAtThEO0AtyZs+2zGMgk4 CTaQqoK0954NM/Kd+IRmCy9axjlWbn0Iu+z59v8pCh/S9py319SIizXzJZ0Wonnalw4B tNpw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=kaE1LJdt; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c636edf27si794241f8f.189.2026.11.12.10.59.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 10:59:52 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=kaE1LJdt; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=4sbQCXVYUg9yEeqt+2sD8bqVTxxllSkTGlsbDQ/2qWQ=; b=kaE1LJdthJnl iJBjlzmig3SUzAsHe4qyFSmRdqh1Zt9RnELAmqIwc7b5eGza0mmNsSnva7RACXmjNnzmhEivnlhwU FjW4ORo0mJSbWh5GA0TiMRAD7zLR2jITDvW6ZpPD+Q8kgXXVo0ZYlSe9QQyXFFFoPHBCljnn2fqLI jPIb8iO0laCfUVChKplVvBtRQzuF1IVB4hHVhkzapkcBOjz/PErGhqck8q5tPsDoaZ1fUrzP2Be1z nj1vuUo2VbdeaE1VtfsAl8/pZkiUtXTH6LB5bJdjiPFr0uBlVrT0cqeQrna0KuoJMxYauG1HhsemS YfneiFIwokvz/o+DUr5CsQ==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRZxO-006C6q-1t; Thu, 12 Nov 2026 19:59:49 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Andrey Zhadchenko In-Reply-To: <20261112111205.736027-1-andrey.zhadchenko@virtuozzo.com> References: <20261112111205.736027-1-andrey.zhadchenko@virtuozzo.com> Date: Thu, 12 Nov 2026 19:59:48 +0100 Message-Id: <179450998877.4060562.6491294425653598184.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1271; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=+jRhZvRhDpYzRLZxXKkYq+q9dw1outPrT71L7eU4YeI=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq9gymNu3oJPbXMvnEguS6X1uXhbGkPhd9rSeZH 6ETdQY4FlyJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavYMpgAKCRBRlgpH+WFc KjOXEACbIeVI41OpNgjxY3vSTaOjRN0YNDvoJHg/R1/Nd6YgKzdecBY2GJr2wVcWI3M+2A1Bv1v aXU9ZPU14gsDNk/iF0LDP7eE9bJOr4fyANFybBZp8C+BaGlzEvG3kdEk+1PJzv9aGkgC8M6/5B0 5UB+49uI4KQk0HS045M5xkWNShm+UbhV9Q5FAN39RUdr2DkkdMMyASVGeVP15Mt7ffUaEDgQIfW BY2xyi4+v6C8onug+TkwrIkRYnTbxEeGJE4J0mfSwNf1kO3KVgI6OKOY8GuINM0GWTAhdE78h3o sGO6pKQGRW2BmFyioqFiP/uweLscqQQ4kBuP3d52I76TWIIqRyyQHsFMVXCNilao1LtKgHy87JO 0r36CJCSB8OEa9bWnJ1igBy9d3l5K5UYM9C30grJ54dRxdIkzNrns1MpbFYk3ShqP6g64Phl0to LXxck2UHBzLYrCENm9OGiGX5wtK+eTO51pApcr24jJgJv9N6JqvNMAOqhh7hrVuKmGg6WAX4ATV 7UcS0nBQrwi3S2uS9CouK3an2I7Y4SgZ3a6UbdYgcXAwB9+JCl8UlZuty+BBXRuvyUP5KxfHxqc qQy7q1sHrQynmEzubgDl9Hfzh4LDFywxtSWzH3o5eodBAaVGdzDsTVcJ7jOUQUPQPzsV3F58G++ 0w3LDuMPsTW8kRw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 0/3] dm-qcow2: do not free a discarded cluster under in-flight writes X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Applying with these fixes on my side: - patch 1: "The counting is done from the main work only" -> "The counters are increased from the main work only". - patch 2: "refer the cluster" -> "refer to the cluster", and the comma splice "of a page, others wait" -> "of a page; the others wait". On Thu, 12 Nov 2026 14:12:02 +0300, Andrey Zhadchenko wrote: > Make such a discard wait for these writes before the cluster is freed: The code is right: every data write decrements exactly once, also on error and on a resubmitted short write, and the generation switch cannot lose the wakeup of the waiting discard. Separate patches, not needed for this series; I created a task for it: 1. Reads are not counted. A guest read resolved to the cluster before the discard locked the index can land after the cluster went to another LBA or to an L2 or refcount table, and return that content. It is older than this series (6e1c3e5a91fd). ext4 and xfs close the window, their hole punch waits for in-flight direct I/O, but fuse_file_fallocate() does not, so images on vstorage are exposed. https://virtuozzo.atlassian.net/browse/VSTOR-154939 -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel