From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id DD425803BB for ; Fri, 13 Nov 2026 19:44:08 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ADJfll5019426; Fri, 13 Nov 2026 22:41:48 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ADJfll5019426 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="Zg/bYgzN" Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ADJflp0019414 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Fri, 13 Nov 2026 22:41:47 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ADJflp0019414 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4b9fde3044dso8932705e9.0 for ; Fri, 13 Nov 2026 11:41:47 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErGUyw/YCnviqX5yxRvx1Vyr2dQZ00XyhBW49q3yK6nme2HfdkoAsKYjmz4hZDVY2OyFCP4AJA==@openvz.org X-Gm-Message-State: APuU4Z/TOS81XXgO4WxC38BxH5OihzRaeRgAqhuBI9p9VyRVpQrK6ppJ RRFAkc/3GwWFNsosmT2GJ6Yzmbo6YUY/AYIo0rWmVXhq1Pn6awOazpTbZ5V9zEBBY5DbUn6QGEv ilh1HhpdB/0Nd5OFqivowRIJIT1DbghjRRj3mGq0ZdgpFwnbey8r5Ww== X-Gm-Gg: AYBFou0eagmpgTcukNjai+r/wC0Avfxdx3VfldtN50N57UwnlAGAYER/u+tOyZeia+K uXznXnnDPtuzD/s22y3STEWWqsyg9y2eL4VIHp5KkSCnJ5lA6iRLDXO42/U9EX09IZ6IaeNjfjb HbUsJ/1NFzEZqVBY7QVE4uuYnjkqXgqyFtXqZUwI3arkrNcgUKe4OJYdqlRyV34Y9/Oe87rjlhe N7M+Pan15jjzYR3alb1/eZXh641vzL8zmecICNTf8VV9XPO0vT03A0+wNSlM5oMrDhd1tD/i+80 EhGO6tzK2WlmcwMuAp9QFBL+7sZjRtpYZvgVSpI5n/OvplUKu2UQhQI9JcfecOeLSeborTLSLpE N6N3SVPfoef+aPnqt/w== X-Received: by 2002:a05:600c:870f:b0:4ba:495c:3798 with SMTP id 5b1f17b1804b1-4bb55af1377mr72374765e9.35.1794598906863; Fri, 13 Nov 2026 11:41:46 -0800 (PST) X-Received: by 2002:a05:600c:870f:b0:4ba:495c:3798 with SMTP id 5b1f17b1804b1-4bb55af1377mr72374475e9.35.1794598906357; Fri, 13 Nov 2026 11:41:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794598906; cv=none; d=google.com; s=arc-20260327; b=qTrFXX1uuZ+cGSO0FNuDaeEFl4AP1KNUomfobDPvdmyMxrsDbtBSUbidyFAS7/G/lZ eHOSProhICCF/Y97Isb7+umCBbKKAo49vSBvScejmdOEMHSxgTCkSPQ/cQBN5NhyHVzB 1zRN+cWcBLH3XpTLA3UOEyZkwow872OzKdX4OeREOh0VVxggaJvPaxBSVqWebhy9OiVQ Ybdof+ZyytQOuIb3yhluQkdNiqCgrMdkDCiyM9lzkGeHAx7qlWa9Z3gSgmzJ//nrWKFj JZ7nBFezJZM/lSJhkmKzq11ZrIDtaxEuffj0+xhB79PQqlXQa+VLXxKb2TJ42+nMZcQk INuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=SZWRR1EqI8tiaWamEA7MsLky2Qse6Mr5ZDCiDmGClrg=; fh=D+fpfNE3eS/JDEf1ElWXHuM/4IOsf9Zyu3iteEH/Ms0=; b=lT5ZXQLrWVeWYWJcGhwWrlfov9gqFTlN7BJawno+hsa5Vu6PVZ1FPoENSzFmI4EUQD ZIbD6DhhMPBqCTLwgf389/5P1sS/Wxn++UauS0Jz1sGfQabbU9sKTT9dIm0Zcg8ZRelZ awX5DFuXfspNtWdAh+oSolTfNfDq+y5uSDN4JNuTsc305EONj32CRvvXw3mCUagXznLh A5wvA4flzEZjQQQCpZEpTGMcyuvCG3ew8CPLLLzEy9/2a3HOSYBRj4a3B2VvA0gUEdoN Kn3F/GpzZR0bmBgEkDOeeTJ8j1rtXSxrdS1LQk7y5vsGMnmX0VISYGLGHfUpN+cG3Rq/ GISg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="Zg/bYgzN"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c7f8e0063si6217940f8f.491.2026.11.13.11.41.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2026 11:41:46 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="Zg/bYgzN"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=SZWRR1EqI8tiaWamEA7MsLky2Qse6Mr5ZDCiDmGClrg=; b=Zg/bYgzN8Bs4 KBlbv/2sglLJbOjtOjS8Vn25xD5kG6jhAjG+zYIfjF63c8/aerIGMWku5YXuz4PFhxUWgmdcV9Sr1 M5pojfwchRlU+rWwYNpjg19+9QYQnWpIFGd4Kw3KcNrq0DdocsVJ+AXN8LYNmwz/0VYxx13XNs+RG 8aQzg1U9DUTUrIV6CqxSA+yV4UVNxXZKvXXAowBP92GyGD/7eShYhW5lz5jcidZ2MWfQNsUkIK19b sjm/5yPcFJoCmGaPG70JgCc8TO2pBmvvO90sGS12wY7YSNfxuTUWDbyRe1HCSQjs7mMEcAfCOV8Va /kF5bCjiuphJnf/VM1J1Pg==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRx5T-00GMcb-0e; Fri, 13 Nov 2026 20:41:41 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Pavel Tikhomirov In-Reply-To: <20261113-pr-ptikhomirov-vstor-154129-aio-pseudosuper-ring-v1-1-7d35d143fdc3@virtuozzo.com> References: <20261113-pr-ptikhomirov-vstor-154129-aio-pseudosuper-ring-v1-0-7d35d143fdc3@virtuozzo.com> <20261113-pr-ptikhomirov-vstor-154129-aio-pseudosuper-ring-v1-1-7d35d143fdc3@virtuozzo.com> Date: Fri, 13 Nov 2026 20:41:41 +0100 Message-Id: <179459890135.57567.12439437565244725963.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2123; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=FjBY3ss4eYEaMtPGEWOHbFHQ5lzKY0djIj+IA41HmFk=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq92f3cpqrgQy6nx9YX8yrcYkxQ7LkKRP1kewdw 2v1oGmfIumJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavdn9wAKCRBRlgpH+WFc Kh4gEACpQ2LgQP4/7yg8bqBw0QCK5ZcEpp33ziyTns/okGJZBKnbsaEJ37vUrn3msEqPiN9tKnB lD1mA+/XxEUjzIJc4slAomn52phg/tJjnMEyk/OZ+P++LFGDNBwjfCv/YUZALQ8gesdkz5sm0g9 cPZpk6OmHVxLH/i6vJntD7gq44ihSYDrmX7PrWC39DuPTn9s86bV4M4PJrUGXVm1eNigsK0iWag exHDL5zo5Xo6hhemjW1szraTtpeCYip+wPRUprTMjM6igvVUQfOk3g1Qc7PHljMY1pH9rGiKImb LFHOILKu4mL6MZvtD9XjaSm+Woqr9DmCxaPGucbnmMijQmF6MHt55j61RrLz1Bn7pzV5XH1P0+B 60Hm9eIWZ+1SwD2UhDSCgDaybpiwW7L7f7/yQSmcWcyoL7JWa4ff5t9c3TUiOUlGjX/2BbwUsIm PXVuiGABBH8hLrMIUukML1TkjPgX5soUb3E6UpHzfIzgHiDqxliH63oF61Nee2M12jOHRucFDQm HXRybudDLJaqCieEPPyJxwwYF4ZODOWLvm1DeUf5raYGcg1UI9XjFNlzoge6iyv0WIMDBs/onZd ZdW4ghdSbKsqWh7lPKGlg/lX7jDCi5eXyT2UxNopMjMiMNzguwK6pLbiATYHDVS+kY6BWy4j+Vn 6R4uIn7tGrVM5QQ== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 1/2] fs/aio: restore the AIO ring of the dumped size in a pseudosuper VE X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2 with the changes below. On Fri, 13 Nov 2026 16:08:44 +0100, Pavel Tikhomirov wrote: > After a migration to a node with more possible CPUs an AIO context can > be slightly less reliable: io_submit() can return EAGAIN before the ring > is full, while free slots sit in the per-CPU caches of other CPUs. Item 1 of the cover letter reply: keep a restored small ring out of the per-CPU slot caches, or state the real bound here. Why: the doubling relies on the heuristic: with at least 8 events per possible CPU, the slots cached on other CPUs stay below half the ring. A restored ring has no such floor. req_batch drops to 1, and put_reqs_available() leaves one slot on every CPU a completion runs on, which only a submit from that CPU takes back. A one-page ring dumped on 4 CPUs comes from io_setup() of up to 62 events and has 126 usable slots. Restored on a big node, io_submit() returns EAGAIN with fewer requests in flight than the application asked for once completions have run on more than 64 other CPUs. Once 126 CPUs hold a slot, it returns EAGAIN with nothing in flight, and an application that then waits for a completion hangs. Before the patch this migration failed cleanly and the CT stayed on the source node. > Skip the CPU heuristic while the VE is pseudosuper, which it is only for > the restore. Keep the other adjustments, the doubling and the rounding Item 2 of the cover letter reply: the VE is also pseudosuper during every CT start. Why: libvzctl do_env_create() sets ve.pseudosuper on every start, and the CT's first task clears it just before it execs init. vzctl runs no AIO in that window, so the code is fine, but the message and the comment ("skip the heuristic on restore") say otherwise. > gets a bigger ring, and the restore fails. E.g. io_setup(1) makes a Item 3 of the cover letter reply: say what the user sees. Why: CRIU's restore_aio_ring() compares the new ring with the dumped one, reports "wrong aio" and the migration is aborted. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel