From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id DECA6803F7 for ; Fri, 13 Nov 2026 19:44:08 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ADJfpq0019433; Fri, 13 Nov 2026 22:41:53 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ADJfpq0019433 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="USYlN4PB" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ADJflHE019416 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Fri, 13 Nov 2026 22:41:47 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ADJflHE019416 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-48c6a1d4034so968816f8f.0 for ; Fri, 13 Nov 2026 11:41:47 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErGzduRyb4R9C8H+e3YNrTdlOhu6c7Xc93KcJm2ZSetpeMD30LXKgbuFEsE2HAzjCzHzP315zQ==@openvz.org X-Gm-Message-State: APuU4Z8zr3IS6ZBcUlovIx2X0u2QjF7eZPx5R8OAvRlQo7BmE1uL+jdk WWqiERw+eMzBbHP7IW4u+63JwSQJt30Gv+nxLXWdSERY44uDFnFTXvMJBNnwkbIZvmQ3oGj+LZO L3bLlK+afo4Y1UKsQ85WXhVVE2Cm80nESkFefprHJ6oOrOyVjLJiMAw== X-Gm-Gg: AYBFou3e/JhlLXLFwwDyFN9e3ULwCXvogNRXj+yOMeYlXy/KQoWJWIxmfprTzuVwY1I DfSqU+O1SAi7ag5kIjFvQZxPYLWpJtTaYd4zWWqB0jBuiGJyAUhTqo+yZCtkRPN/ba0GHXSyZFC 6yfUR9u/4KhXozd9eMQa0euhvP7WeMgjTLmjedV+qfho9rNpTppaFErh67V33X1o3eNFP5RuYwR ktnxHQc/B6AIE2pfgJgHdRtCL5fmvBDhgsZJWFwEL9SRMJELM8qFtns8ouiX7NC3BsxzrbdrUSf zUiHQJSx31XDBV/AXfUn5W3emwdU7RtsS1DMIta2/BzqTXJaoG25Y0+apYfpuzvKg3nLwDDPcLl QF1oM3JIKi/PiNfmG/g== X-Received: by 2002:a5d:64c9:0:b0:48f:ead0:631a with SMTP id ffacd0b85a97d-49c72ba5d3emr8373451f8f.47.1794598906890; Fri, 13 Nov 2026 11:41:46 -0800 (PST) X-Received: by 2002:a5d:64c9:0:b0:48f:ead0:631a with SMTP id ffacd0b85a97d-49c72ba5d3emr8373421f8f.47.1794598906439; Fri, 13 Nov 2026 11:41:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794598906; cv=none; d=google.com; s=arc-20260327; b=MGSvsvBb4JMETg0g7aOu9n3oYiAK+kURYh46Ee6ib0aEEZPu+g5ZDjWVrwofiAacjG dsmqMtECwAenfGo492VvyIV61DmpKjn6qnXayvKvuPGlU/AgTSXErDB7OMjHT3WNQnz8 Xql+FJOvzuvOGR3fQ4z0C02Si+KCxj+6YSs3+5v6lY7IV9cKxLm/09J8kqul5O3MzAHl HmPkT7/lfe4cotSLgB6/QJmkB9XGp5NvX3xzYCIRqINZuPknaTxEPUdR6Tq8J731L9qj VqNfXtWe9+XYhRjXjBFFiFsY/3w2i4VjNJ1cWwTsXpFxVApQiWz5em8rD7VHEwxTbNM5 Bblw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=QOh2+0bcauoibtnUi7IooTrgEhnxzaVnJsY4Doufq+0=; fh=D+fpfNE3eS/JDEf1ElWXHuM/4IOsf9Zyu3iteEH/Ms0=; b=cianQgUAYrpRHIPuhVEQeHbg/kacrR3vd/JkSTKRgu4fyDnC2DDNC7HzlnkK0aK9IV WNdoyhYM5c6alKO2ryUwzxZZwdec7nf5FIcp41bCledqa6fENpc9+ppgevrgyNh4WpW/ T72ZIusdI73G8XwT3tVy0tAOFJfemVAhHFTVv3/yxCBicFtDEeM3mAlOwJgcjrtTXuXm +oDb6Kqw79VERjtvGpCPkoKO6bVctUbLIYMGCG69obNlLPMO/5clprbAs9glLIvLmUI6 mCQvdnrExZAuq+p1r1aDBOUIAeCpbK0XpzOTPtRouVav8h+WOIJcN4hex2GJ6ps2uec7 vpeA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=USYlN4PB; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c631221d2si7390486f8f.73.2026.11.13.11.41.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2026 11:41:46 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=USYlN4PB; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=QOh2+0bcauoibtnUi7IooTrgEhnxzaVnJsY4Doufq+0=; b=USYlN4PB5Ngt ZlTUAf+qSVRaqBmVHvkWMDd9L5Ye2HKJqfLS32wGA9v9cfRdNVKww04pUzgYR98pwFQVC17Zciuuk k6P0S2j0LSrUqccr6KzToY8NhNCLgVEprjQtemPM5i2XMkBpFinstLjHsW4se+hb+YKF4MZ+S0Sx0 QyT48Hz2QS6A1Clpy0CgfoWZxsP6kmzDoHwLvG3u2ofz0W7QpP/b4qJOskY9qqNLOl+o3YWjkVper dcFw3vouf9ZGrugcU6A8t/JJ09gA3j4igAmRuIZK5nr/DQ9lKy/9R01iaMWMXzO7uDP1Qgl86BxJP LIIdCrQlsgUn8FfsZV3cOQ==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRx5T-00GMcb-1A; Fri, 13 Nov 2026 20:41:42 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Pavel Tikhomirov In-Reply-To: <20261113-pr-ptikhomirov-vstor-154129-aio-pseudosuper-ring-v1-2-7d35d143fdc3@virtuozzo.com> References: <20261113-pr-ptikhomirov-vstor-154129-aio-pseudosuper-ring-v1-0-7d35d143fdc3@virtuozzo.com> <20261113-pr-ptikhomirov-vstor-154129-aio-pseudosuper-ring-v1-2-7d35d143fdc3@virtuozzo.com> Date: Fri, 13 Nov 2026 20:41:41 +0100 Message-Id: <179459890135.57567.4896919865662693695.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1215; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=qaZB/CcwoA/QAictDnoha+XkUYWsmG5kjjVZ4dFj7IE=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq92f4WyjYrnIa6ZvcPaYTdzqyH7+Su0aBiNxeO iyk9GusjoeJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavdn+AAKCRBRlgpH+WFc KlRxD/96QXjiNA4eDEKEOE8B5eZFo+ULMZwiv0bo8XRHIoptqDSu8CJGaVESoxLLGhNWp8/JnAv vheT0hjEfWlDcebqe9REutz1Ds/X4YFqdZE529+iNVa4Vnzx0mbQnupNgDoh0Ty6llmQ++gnc7Z tRixbDBRbntdieKbsrMVoplp9vZBfRvgvrip9Y1O78RP8aigDFJKXmqbnue9AmSOp0nbX25uHSo 1sepmOl/d3CuSnZBRxtSM5ypyWZ3dg7Y+2DpzcQvC07yMOkWQe4fS+PmA0VCkmIQFI70XOEbMaV GjbTuvdT8b9MrEh2rv6kscFzNeKdJ4adFAgLKq8UmbWfwySD9x675KIpzVTOEXC7ZinbXRWc9fh U08nBh+fOCVZf2womD5NB4s+awP9hbFYCcwdw4fyHhIbcc7iRjK0cLpzLln4QIT4SxU7n/4OzAe 8U2O/PLTTuSYiDyOZfTVK0XmiJTgyYtFVchGz/M/fG2oPGe93FRjrcG4wSzjbDARAXcJXjTu/wB 3E+tFZHgkqfByRO/n6MJZQv9M3VzzW/BW17Fjbq5tzsZvjEjj7o4NrfxKU/R1NnKTanOOWjXwlk DjM+Ys/gniMjONLzt0mKKI4+LLT7dFE3U9qq5W4xxfw//pCSBgBZcmcVEQLC+p878HQHGeuZxWJ BHMCzkFHn5ri6CA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 2/2] selftests/ve: check the AIO ring size in a pseudosuper VE X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2 with the changes below. On Fri, 13 Nov 2026 16:08:45 +0100, Pavel Tikhomirov wrote: > + cpus = sysconf(_SC_NPROCESSORS_CONF); Item 4 of the cover letter reply: read /sys/devices/system/cpu/possible here. Why: the kernel sizes the ring by cpu_possible_mask, and what _SC_NPROCESSORS_CONF returns depends on the libc. On a VM with CPU hotplug slots the two can differ, and the test then skips when it should run, or expects the wrong ring size. > + self->ctid = make_ve(self->cgv2_fd, CTID_MIN); > + ASSERT_GE(self->ctid, 0); > + > + ASSERT_EQ(prepare_namespaces(&self->ns_ctx, CLONE_NEWVE, Item 5 of the cover letter reply: clean up the VE cgroup when setup fails after make_ve(). Why: the harness skips FIXTURE_TEARDOWN when setup fails, so a failed prepare_namespaces() leaves the VE cgroup in the host hierarchy. > + EXPECT_EQ(set_pseudosuper(self, 1), 0); > + EXPECT_EQ(ve_ring_nr(self, 1), ring_nr_pseudosuper(self, 1)); Item 5 of the cover letter reply: ASSERT_EQ here. Why: if the write fails, the test goes on and reports a ring size mismatch, which hides the cause. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel