From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id CA7A2803BB for ; Fri, 13 Nov 2026 19:50:57 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ADJmj9a019530; Fri, 13 Nov 2026 22:48:46 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ADJmj9a019530 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="VvLybc8b" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ADJmYAa019500 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Fri, 13 Nov 2026 22:48:34 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ADJmYAa019500 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4a359c7f47bso12074635e9.2 for ; Fri, 13 Nov 2026 11:48:34 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErH2rQFHr7It+XdtZup0ufyYQweNBhOzNhaUmaXqRFpVhHO8cAoaNCxwxpTIcA6l8rZNKDeOyg==@openvz.org X-Gm-Message-State: APuU4Z+xu5EjYjt4Yu4rg3hnOuevXu3Ht+FIHDq1SQRh46XsUNEUk3sZ 7xaSh18M498ZYSr78ZyVUs2YYWeV+5K1CFbwUq1Ztk4hO9nezUeQ4TP044X5jUPKeC5ythzpuFU uzj0BaEePS3/TFnL6eJOfDtPzq++ocBkAPlxAjIuWHp3ITXixXkHufQ== X-Gm-Gg: AYBFou1TppeC+ExXjDeurEirJutPXFCaNZMewLL2t8K9RSmH9Wh9NEPTZAfVKwjhK/x U7Iywf1FjSUXJ95oRDo4lhIpl1t29Tg9aY/ieDFgM1jXdoYTLDjoYsZNu4SLYtPPLQpocR7MeBj 15AD1H/ArRB3dOI+SdtdDkyb8Q8f6OtuXskgGoKX6pw8XmNwgER0uqS6aycgjOmMsxmEbbnzNpH JxQrWRIB79OggWExz/VwNbTsVe1Lw4pSdpmkqEyjLTwbCtSmRs7pFFe88n0H4LI78uhWp5E1/At UHL/zjbFRdO/Pvavgq3lHWjJCubPmEtuPV59E9/YksXLaYbS0DmvZQmR6LonWF8h/PZU55u7q6c v7b++K5dD9SVRATng X-Received: by 2002:a05:600c:3e19:b0:4a1:fe26:24f0 with SMTP id 5b1f17b1804b1-4bb55a5bbd6mr73169865e9.20.1794599314195; Fri, 13 Nov 2026 11:48:34 -0800 (PST) X-Received: by 2002:a05:600c:3e19:b0:4a1:fe26:24f0 with SMTP id 5b1f17b1804b1-4bb55a5bbd6mr73169535e9.20.1794599313762; Fri, 13 Nov 2026 11:48:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794599313; cv=none; d=google.com; s=arc-20260327; b=IfVq/e9vBFX4LJfCLyL+zQ2EnitKWEy0HaeU33i/LnUCy1pAivmakYuaus5XlpPv0w +P7LJLxz1goSe6cp2ylBy/V19dzIAI8PIj94y6rTkPdjptRUbroAEfbDR9G7jmwsn0q1 /d1h5LurVaWbibswTXQ8C1oSxOPCBFkMOgX0PcAaA10RY7MV8AHKlFBcLmGEDRfsUjWW mTxEXTARnE+g5RvQLpsBZf+B3232MZMfzI1QEQBXyVoI9nzAgYRxU5TsbNo8gR/H6dRR 2fCHdJbYZMXFTRP233qJeUChnFGE6HOVDs82w/KFW4j1kQPTHWAhfm7jYoLQj0ZHP1E/ 2reA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=5/AOqON0RtLC46RSMA104XbQQ/upCNAs1mI7ZhyqJsI=; fh=NNIHAR0oQq9xcHtG6fvuNrouibWQy9PtHjAIRR7/XzE=; b=GcVOa0DwE0Ehpfa4LwFT019ZjQweB2DLUy1zFdsqe3d15BpXdeBfwK/iLnduxk+urR uAJsvEcqm3FyPUbp6wOcqoXuyyG4tBEYMQsG6IOyJVP7VFT5HKIA1lYv3Fu9O8uuJTAm 3II7r15IlZlX67HECPoUtpFj6xKOfZF9LEbjLcCNKIJ3I69W1ay+MhtJEkz+zLMy1Aav 2k26+nw1RYHvUstvpSirTHRYC3nf1OKSdMDDFwMTnU7XuyXNgRmTOsVmQxhHKJV/c858 4BqARm88k8/3U4Of9VE00EAWvx6SVo1AYAGbpsDPYiQIODJTIkzrMXiW52i/YD/TPfht h08w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=VvLybc8b; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c64fd6577si7202041f8f.462.2026.11.13.11.48.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2026 11:48:33 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=VvLybc8b; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=5/AOqON0RtLC46RSMA104XbQQ/upCNAs1mI7ZhyqJsI=; b=VvLybc8bN9TL SoCaORtnoK1ClW47C2EP4d8BsX0WnoAQ8CXTR7Q8kDnc6sXNf+0kIYyUcMeCUVtCH/KdZPb1G71a2 AgPIvCPsW83/MJC2szHwunKho6vCyyz7SraKxDDgiHZW8s+Tu2+D+nL2twM6gpEueh251Z6Wpleu1 TlROPwCZH1td5CGxuKMdr/z6r+8W39vwRGQaH0YHAAzmFkf3lNKumExSze7ox7ki+URClsxrVNsr9 0pakxNBcJiQOLhaNtne+5toKqlEr1YD7i0B8oLG+rikBbFg7uIAZRTM6LTqPmSaCeTGC3ZiGoLuNo 9CQ4h2hdSODdcNx7BZRHzQ==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRxC2-00GU0E-29; Fri, 13 Nov 2026 20:48:29 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Andrey Zhadchenko In-Reply-To: <20261113111126.793039-4-andrey.zhadchenko@virtuozzo.com> References: <20261113111126.793039-1-andrey.zhadchenko@virtuozzo.com> <20261113111126.793039-4-andrey.zhadchenko@virtuozzo.com> Date: Fri, 13 Nov 2026 20:48:27 +0100 Message-Id: <179459930734.57567.11006874228731139099.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=890; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=8z5AhTNc7C0tbtBqTOhThymxhMgpbDpbDtx2W4YSf2g=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq92mOUEB6zKKgYn/4/Hn7ThPG6rZzYlCMtzM2q eYWGc3jPeyJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavdpjgAKCRBRlgpH+WFc KnVaEACeb1Z1Qmr1y4bl0h/KYGRcQDU7bJD+DrXwNHpGfePHt7chMMZbr+pLn64LGAqvXeUDsoh pVYxSPfqVQwmfN9/eyT7K5B2RLxKEIfkBHnSVIQZR9hf2UJBHAQ3XkyYnJtXQAbUGaaM5BWppQE Af1CIb6sMABEWPrTy3sQfMI/Da8E/DAuLWtsLF6CoaHBRCgT4HrbxTPdcIUGfGn2c/R2L8M8eaN TvEEfzInsJMcWz3Y6m3WTAm20Rw//WsA2Q1Sh/KAEo6HNWW/ieaXccMVpnAnA4LhOyIHKWQON75 YA3Ii0cmQbp04Ix+sUPqiP5T9kYBnhicbI/7v9CKEoYrc8dgFqQSD17xFcsH/oAgWawIiWnkn8G B7RrEsYyabundYxcOpNwcDXrlmrcVSt41KDMmskKVGC6/CgFp0Tdb74hn8iACm0ocKWz0oCU/6R KELWIqCPQqPvk19F4tBOA/nsUOfEiEjccLE9BLWtbkxrZyJht0hdpXIOi64cPJgQyMhw32PQo3I BjnQBBdELeAK9GQ0TufccBFnvZEYdgkA2bJUEAFrNTHIYsuLpGWKG9w/3gmgiPU3q91YXDdqcT3 L4BpZ/w+sbNETBZlXpliYuTzwbjrTtfUs6LR1j5HA4/kDitNhCLmKZTIG/HQ8A2I8zDynZXzLi2 G8VqrEaj40+UPBw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v3 3/8] dm-qcow2: count fast path writes in parse_metadata() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org No objections to the code, a text change below: I fix it when applying or you send v4, see the cover letter reply. On Fri, 13 Nov 2026 14:11:21 +0300, Andrey Zhadchenko wrote: > md_pages_lock hold, which checks the L2 entry. A discard switches the > writer generation after it clears the entry under the lock, so > either the fast path sees the entry cleared, or the discard waits for > the write. Drop the count, if the qio goes to main kwork afterwards. Item 2 of the cover letter reply: "sees the entry cleared" becomes "sees the index locked". Why: prepare_cluster_discard() locks the index under md_pages_lock, and from then on parse_l2() parks the fast qio in delay_if_locked(). The entry itself is cleared only later, in process_indexes_write(). The mechanism is right, the sentence names the wrong guard. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel