From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 98D098176D for ; Fri, 13 Nov 2026 19:50:55 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ADJmfLE019523; Fri, 13 Nov 2026 22:48:42 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ADJmfLE019523 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="RBe5kTZW" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ADJmYPa019497 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Fri, 13 Nov 2026 22:48:34 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ADJmYPa019497 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-49166c8a60dso812648f8f.0 for ; Fri, 13 Nov 2026 11:48:34 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErE9taGa0HmtZHLJv+2UQI8KjGBAXLkAvdzK4Kalr6DfHOpsQHsqbdiIjThOfkLJmcm5MuGMIQ==@openvz.org X-Gm-Message-State: APuU4Z8zmwXN92dRIgjt6xE+dy/hK0JyrBtxiinPb0hGs4lbRD6+7PF3 vnMMwHvqyzoIRXgmrh0im2FGbnlgzx8W53Zhn+qeONosJ3DxKs6depdBgL9YA/29xTVEnKCH06W uTUZo1KYKekRpnZyJ2LRCf5qX2r/Ycl7Xvq1yZ9d79lMIYsK+hIo+vw== X-Gm-Gg: AYBFou2hjFMST+SB7ECagpR/c+0wn6bT+kpgU5tSP5Z0AoQVDWKGTYR4vZVabBJrgGW MR2kL470V349OhA7+2w3sFknBJPd1pSaxTUwQbrHpCFdlGjngeaD+iLPph+PVzoMQAHbb7M7w7c FF3phS2ylFw3l5GAfBFi1z4AxRwcjNpm10Xpvo3GjG5Nu2BVC8JlO2c9PX+6vcEvtqytECbRYaR As35bR1++W7mQbsa11k7X3z32biNVwAnN/odQi57fwxtmgL1ML93EdBD93ydhj/6T3s7h8cqLlO 9Ac2bHg9HKIHVW4b2hKLdGFYwY6np1ZQuniplqoacjUZ+0Zn4/cyB7XDv1lr6YMkVXNlYzfbvZy G83tvXwI9z6Q+0FpYgg== X-Received: by 2002:a05:6000:2c02:b0:498:7be6:8d69 with SMTP id ffacd0b85a97d-49c6e68daeemr8311613f8f.6.1794599314021; Fri, 13 Nov 2026 11:48:34 -0800 (PST) X-Received: by 2002:a05:6000:2c02:b0:498:7be6:8d69 with SMTP id ffacd0b85a97d-49c6e68daeemr8311587f8f.6.1794599313582; Fri, 13 Nov 2026 11:48:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794599313; cv=none; d=google.com; s=arc-20260327; b=Vo9HCjiTKHbGJAdWu0SkGANPGYDaukzlqqH2zLmp1RZFE5dsFcZAPCPx5EytlI4Ka3 Elt8jeyQdlbJqdZYMcgo5Qzpq0EU7WbHhjcNRvdndrOWCH+4OksZWgbfVFzpI92DnyI8 WU4Bi7fdnNdOlVdMEMm7DAYyGTuidBkPGxs9KfS/DbkV29hh+p+UYFkPehc6NRPojBMk dfqgMBOU+kcWl48/pb5gIHoNU+PQfVhzyLnh3Os35x10iSGzHvErrcJWsTqqeq3f7A30 GW9RpuM7/q7R3ZfCdVIHpzRLkaB6Yqg8B3by90QLUP5CjuTrLUdWcxJlY01rENRfGks4 sD5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=yc2iMkK28tZgVXxTKCWoxqljlq3FCV6ec2j0tbrmRCA=; fh=NNIHAR0oQq9xcHtG6fvuNrouibWQy9PtHjAIRR7/XzE=; b=MQoVsQrR8RbYxvGnWGMTN7ZHGwz1rnkMnrz+yhxCQtyUM/gDJ+vRZP7GCg/tO/E7k4 n18jKuxftwM95qkHkreWly7XxKhZmie/WYOE9PQvSVqeirvbUOtBjgJPee8LHVQduQkO aT+nwN8Ycdo0ddK6CdQF9RgbE0AW0yrKelCkALgnn30HbbkhAhNFbzKxGs5Td3aA9zyj NfH+am5AyyK8+r+ZGvVJoqhrr1EVaOyR7NlexqIoT3gPgkjxX2jKm6mW8R/L80fv2uNe XlGOPREq8o+eSI/CF/vXVKQxCGsTXvQavvprP9eAn5BlskgIPscgoBtMrUsygrf9tfe4 /5Mw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=RBe5kTZW; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c636ee282si7060398f8f.167.2026.11.13.11.48.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2026 11:48:33 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=RBe5kTZW; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=yc2iMkK28tZgVXxTKCWoxqljlq3FCV6ec2j0tbrmRCA=; b=RBe5kTZWgBfE ixTKo3UlBi99F2g8gonxxsJo52vvPDkRQ4MT2xAvU3IyTOf++1xD7mlW4wMMtljB1qHMLW9X1i0ap 5ZF9byK6MO76IC6NcF1FR9T42xK3Vd8/afXPTEOb8cdelWMMSyGd5xmmc6LcyyN3I1aI6oBoJ7IOk t/BNnOGDL+gDKcUEdZZvX//JKUNqJcU2OaNycc6QR+H5NOdw2SI0U6I39sZf0yVsY9VIqbQQTPZ9K qH/+xSSplXCOl23kh3eoGUPP6DbvpLJTho/NR+s8oWxgulBJsKiQxZbDaLMzq+QUEUdKXUeadxR9P N5rgZcm4Fh7iCGU9V1uXhQ==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRxC2-00GU0E-1W; Fri, 13 Nov 2026 20:48:29 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Andrey Zhadchenko In-Reply-To: <20261113111126.793039-2-andrey.zhadchenko@virtuozzo.com> References: <20261113111126.793039-1-andrey.zhadchenko@virtuozzo.com> <20261113111126.793039-2-andrey.zhadchenko@virtuozzo.com> Date: Fri, 13 Nov 2026 20:48:27 +0100 Message-Id: <179459930734.57567.5530019081330720926.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1098; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=wcTrTh6kOy8xI5+1MZOqO92M9HakWMCL3MQMtvmHzRw=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq92mNciZNe/fRW/RjsSBZNkpQy33x4nmkvHiZF TTBaOnPtGaJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavdpjQAKCRBRlgpH+WFc Kj0KD/4wurk3ozWSWa9OxML78wam6ir8xfygEGCGkU6ReZvvt73v+C+ZGHWXSZr3M9VQ4oqTGX7 dXSMYmvIgJjHdalkF44hdvQuvnEfVh+/MkLpge72sBjDbRooTZw6KW6mfFK3MiMbXa3ItZmhWDC jNbIF4EV3tTxMf0ha89J5+7zv1JJe/o1GNxR+RneXJ1E3hC2xm9zloyVOA65/DPyyNzUQQO/tz1 +wLsxhl8jhbanEvHduaGe5HiBD2DMuxXFGTMj72Yth43niLAFtcSXAmQwStm4sOSPta0Qp5Jz++ 1fdLHQOQgJGzao+40rZDd6PJK8JtA7g9aZwi5GmF5x256/RZrMW4HWU6WQK5sN2UBA4mTvjJAv3 yn+3pXdUlEgCoilRLAHeorodNDXaiFJR0DMlYu1eXvz4OTzcjHO0gB1czCyh+Pm+MAX9rU+KtBd k18azVr2pMJDsfu0ZG2MhIVxSByqepvYE6UAqF21HRDHySmQ3gW3EWDyb9iDJosesP9c0IoCnC+ 42M1Z1xXVwMILAeMSi+Cv1xqeVbotT7xmnEbGYHf6K2wK1XqIUnk7Rtlz23FSD6tnotQmdzij5Z kBa9jgWJZFyE0FBExkmilRxZO4UKSoUWzNvzVBQK+2V2b+LKajY2Zpx9bJp0PdCaCCBPPjbaA8A lQkQ2DNp1mxwpHA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v3 1/8] dm-qcow2: repeat md page lookup if it was inserted in parallel X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org No objections to the code, a text change below: I fix it when applying or you send v4, see the cover letter reply. On Fri, 13 Nov 2026 14:11:19 +0300, Andrey Zhadchenko wrote: > Repeat it once only. The second lookup misses the page only if its > read failed and erased it in between, and then the qio fails with > -EIO as the qios waiting for that read did. Item 1 of the cover letter reply: describe what the code does on a second miss, here and in the comment below. > + * submit_read_md_page() drops md_pages_lock, so the page may be > + * inserted in parallel. Then it is looked up once more. It is not > + * found again only if its read failed in the meantime, and then > + * @qio fails too. Why: Sashiko is right on v3. When the second lookup misses, __handle_md_page() calls submit_read_md_page() again, which inserts a new page, queues the qio on it and reads it. The qio is retried, not failed. -EIO is returned only if that second insert gets -EEXIST too. Both outcomes are fine, only the text is wrong. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel