From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id B003D803F6 for ; Fri, 13 Nov 2026 19:51:07 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ADJmqGJ019544; Fri, 13 Nov 2026 22:48:53 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ADJmqGJ019544 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="b4OVV+89" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ADJmYA0019510 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Fri, 13 Nov 2026 22:48:34 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ADJmYA0019510 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48fbcf023dcso573778f8f.2 for ; Fri, 13 Nov 2026 11:48:34 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErGETgWPocTjhEMmLaHepHk3wPDFfYogxEuZa8ABPcGn3rqHPhRjmMSukiThgzu82+VBxMn0wA==@openvz.org X-Gm-Message-State: APuU4Z+pa0G9rGZxUAZsLWxMhzKRwX3Os72QSUesb8q3fwPvo4CKWYi8 vDnHz1vNS4sEoM/WxW8FljxavNIfp8boIoaLMJ6N4lEQvjyDnZGpezSopCyQ094NUSqiuzFjalw TZqT1hs5O9rXIiz1wCTkejwfwLVMfwlkAJtt6A7s/nPMozwXbKIY0dw== X-Gm-Gg: AYBFou12nekTTwa6g1Pqt3gzajoTjuoljpE8QND14Mlr15g/UiHBDLNrh1LCmsRLQCv YT3baZ4eVcDtIZRgdUjQMtHaK+6VmRWeEfzm7/Id+xWX+UyVMi7pJPq5dthndarXaUjkuuhVZWX PZcxAZBuIqSRRaJIz+FFzxFToPJfKWw4ckuleTT4OgGxmc7B2XRH9FBR7+uRc6fngHggou44hFn m7PwnZK/MTv7nxuZ7JvYFyqHWah3lntsZ964UllmyXNixChcGhA4+47bcdA+JkI85mC+Vg/yHiQ 1zYAGhUU2/2vhnS6OLeP+0kfSPNvpBuwDWkzBhKyujGDecnF/6nt9SJfsTEk1t0i8Y3utWTFrIK 0OjkGsmbHiFh0y0jcTA== X-Received: by 2002:a05:6000:2382:b0:48d:f851:ee5f with SMTP id ffacd0b85a97d-49c7381b478mr8677653f8f.24.1794599314611; Fri, 13 Nov 2026 11:48:34 -0800 (PST) X-Received: by 2002:a05:6000:2382:b0:48d:f851:ee5f with SMTP id ffacd0b85a97d-49c7381b478mr8677623f8f.24.1794599314156; Fri, 13 Nov 2026 11:48:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794599314; cv=none; d=google.com; s=arc-20260327; b=P4ZPLWDoQA97TzjJZUuW8upOgo8DdJHHWn0Rk5xgolXW+zBRerOL2qb5wzLqyRaV79 cqSOyj2a4A7S/X2Ksp+rRb5zaDlBVqOjbmSIt86XU+u1etlK4a2HoupCvgk4nCF78cFR hvIigR8Vl8OEllGC1/IHuX8qmUtr3L2+Mb30CsOLfTq86idtuOMGIJWvACLoS3vXAr9I 4fzjYp5dhwlBRSx6/FlQJNTBMG2PQtEcH1aqIg+z2ydNTyjeoVp5aS309J8raDwbr6+D OIFJ80xISqwZmIhWrZBsJhWeR6CLrLMc/hFXSEN4Bxhn+s7VQCmFXEUG4T/eEMzvqN5P 3n6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=pyeib2UwL4VbM+R1mGkzVCscHbv2yrBUINiWw2VBkZI=; fh=NNIHAR0oQq9xcHtG6fvuNrouibWQy9PtHjAIRR7/XzE=; b=DW4TzzUnSiUYdxgz4aFxZcguYZmX4ewqtm3RrhMDv7NSLZ3Ig+Y8k5ImPGeBOcVSa+ Oeu4RePpfv6VHJUd5I8xnivcWrcgf4ZXQkKZJEjsZlplKAxRPUPsbNDXZPoSaRvcNZNK efempmIiUTasCtjQfSrO9oFeANIjvfbK8XettNOtNJ/k6xgAFsmPpy42mHkRSvXZYLa4 7ydIo31u0c+bO6TyvGDC8r9FDgDv+/RF4kTlz1/zCqhHWu5TlTXv8I+aHMPzX/OeuEBh w+0D4RahokjnECTJyBb0EN8HnAL4ej5UKkZ5yxfhgWn3HfiYdegN1wMeobWXpRBGfpXe xlJg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=b4OVV+89; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c6426d402si7466510f8f.299.2026.11.13.11.48.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2026 11:48:34 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=b4OVV+89; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=pyeib2UwL4VbM+R1mGkzVCscHbv2yrBUINiWw2VBkZI=; b=b4OVV+89kPc0 kYp28EnJK/SUWxDhPeKXsnf8CD6z1zkPQVe43/BPSEhu84cBiZ87MW1lpYn6TuMVh1UuqTwcrd2QN Zr9tIBm3hgiMLU85pMzvFHS0OXxzwlNh3lb8binSZeM7+0btzG/WcXAPfmu3gSf+fh+6YZjoawRA9 teOBUq1ZFleTs45vzw+WMwVGW2n2/Gd/5qYfuFGg5E1/DJ/g/7wMIrVMLtmfW5dGbvxV5np7/f92Z xjt5Iho6VnabcCz8GhrsFJr4E4fQSnBLusHUtIosWaOC6emR6THv9rJH023lCZAOyZtL7SCuBtBdY A+2TECcPJzjZL8JSlt1HvA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRxC3-00GU0E-08; Fri, 13 Nov 2026 20:48:29 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Andrey Zhadchenko In-Reply-To: <20261113111126.793039-8-andrey.zhadchenko@virtuozzo.com> References: <20261113111126.793039-1-andrey.zhadchenko@virtuozzo.com> <20261113111126.793039-8-andrey.zhadchenko@virtuozzo.com> Date: Fri, 13 Nov 2026 20:48:27 +0100 Message-Id: <179459930743.57567.2937759188511960772.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1126; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=il7ryBiZSzwpgUmcoAxCA+2fcBh92XsRZBrrch0VSYo=; b=kA0DAAoBUZYKR/lhXCoByyZiAGr3aZCiIa37mzRivY5XTCN1+qIH4d1vbX47salzn5HdGksuq okCMwQAAQoAHRYhBFYPbcg9xdPQY70ILFGWCkf5YVwqBQJq92mQAAoJEFGWCkf5YVwqMjYQALw/ pfD9nvRC+jDh0SxN6XDQmlZ7rbrGOotRg7PnopswU5iPBe4EX4HQw3nDvtjuSk3loatDJuacI70 OVO7n0cB/Rw33jffZ8MucQPAzYUR5UM6S7a4fGlN1Mfpiu3hL0jOBo6xCRf95q9eUt8uSbQKjpN eziQR/rN8AiBuJzLVbW2SLCAtEvXiLhpDVhfGiUz86vyrBz4aigSIjeWAvKcptiRTXibNUK1wCp jXX3OZHQ3SM2zCDBOVmK8iU4YsUsbK9f08dI152kc+fw/e7zNU732qp8YDEdd8Duqc/AqpTDjWI OQO8ZeYiazEmewKIipSLL5KVVDmbShj/eUxdkdivGh2kpAhh7y4HWluvCJvYsl6XNKkrpPXA3lH XCLCVWCMj9uv/9jmCLf8zCGKFv9ffJsXEl6mFbCGBlUgSgq71IUQyz39lny+6vqMeaWOfGpxMxc +wLXs1U3HOdhGTvqLWcoTyrSQFPeJ+StqqmHsCnkGXTQJLaVmoD71qLsx88LfTrFlinzp3saSBQ KtxMcDar3XOGshMV+XZMzatKVcJ3fwtx9CDqyl2g6XgaAWh0qz6yj1/8P0Q/sIKEmf1oUcxm0Bw 1MsbmggVPm363J4PgmSeNLwE3x0duL3jRZoQv5WQruPMBw/AA793Fmwkc7TFNN1J10ysSxa2NsU g7R0a X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v3 7/8] dm-qcow2: process fast path qios in per-cpu batches on a workqueue X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org No objections to the code, a text change below: I fix it when applying or you send v4, see the cover letter reply. On Fri, 13 Nov 2026 14:11:25 +0300, Andrey Zhadchenko wrote: > - a partial discard punches the hole synchronously in the worker. > None of this is new: before the fast path main kwork did the same > allocations and submissions for every request, and a sleep there > stalled the whole device, not one CPU. The punch hole case is the > notable one, as it waits for all direct I/O in flight on the image. Item 4 of the cover letter reply: - add to the list: an md page cache miss in parse_metadata() allocates the page and submits its read from the worker, and process_read_qio() splits reads with mempool_alloc(); - "it waits for all direct I/O in flight on the image" holds on ext4 and xfs only. Why: the v3 changelog says this list is complete, and these two sleep in the worker too. fuse_file_fallocate() does not call inode_dio_wait(), and images on vstorage are on FUSE, so there the punch does not wait for direct I/O. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel